From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Nick Piggin <npiggin@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Memory Management <linux-mm@kvack.org>
Subject: Re: [patch 3/9] mm: speculative get page
Date: Sat, 23 Sep 2006 12:01:32 +0200 [thread overview]
Message-ID: <1159005692.5196.1.camel@lappy> (raw)
In-Reply-To: <20060922172110.22370.33715.sendpatchset@linux.site>
>
> @@ -325,16 +328,25 @@ static int migrate_page_move_mapping(str
> }
> #endif
>
> + SetPageNoNewRefs(newpage);
> radix_tree_replace_slot(pslot, newpage);
>
> + write_unlock_irq(&mapping->tree_lock);
> +
> + page->mapping = NULL;
> +
> + write_unlock_irq(&mapping->tree_lock);
> +
> + smp_wmb();
> + ClearPageNoNewRefs(page);
> + ClearPageNoNewRefs(newpage);
> +
> /*
> * Drop cache reference from old page.
> * We know this isn't the last reference.
> */
> __put_page(page);
>
> - write_unlock_irq(&mapping->tree_lock);
> -
> return 0;
> }
2 consecutive write_unlock_irq() calls seem odd ;-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-09-23 10:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-22 19:22 [patch 0/4] lockless pagecache for 2.6.18-rc7-mm1 Nick Piggin
2006-09-22 19:22 ` [patch 2/4] radix-tree: use indirect bit Nick Piggin
2006-09-22 19:22 ` [patch 2/9] radix-tree: gang_lookup_slot Nick Piggin
2006-09-22 19:22 ` [patch 3/9] mm: speculative get page Nick Piggin
2006-09-23 10:01 ` Peter Zijlstra [this message]
2006-09-24 18:01 ` Hugh Dickins
2006-09-25 2:00 ` Nick Piggin
2006-09-25 11:47 ` Nick Piggin
2006-09-25 13:04 ` Peter Zijlstra
2006-09-25 22:41 ` Nick Piggin
2006-09-22 19:22 ` [patch 4/9] mm: lockless pagecache lookups Nick Piggin
2006-09-22 20:01 ` Lee Schermerhorn
2006-09-23 2:35 ` Nick Piggin
2006-09-22 19:24 ` [patch 0/4] lockless pagecache for 2.6.18-rc7-mm1 Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159005692.5196.1.camel@lappy \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox