From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B720EB64D7 for ; Tue, 13 Jun 2023 21:36:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 811196B0074; Tue, 13 Jun 2023 17:36:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C0F28E0003; Tue, 13 Jun 2023 17:36:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AF9C8E0002; Tue, 13 Jun 2023 17:36:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5C72E6B0074 for ; Tue, 13 Jun 2023 17:36:23 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 310901C827A for ; Tue, 13 Jun 2023 21:36:23 +0000 (UTC) X-FDA: 80899033446.07.74CFF13 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 578D91C001F for ; Tue, 13 Jun 2023 21:36:21 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b4olZ5kh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686692181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ds/y7lH76obKk3se56kRnUXeuApDjVV7xaTlhnaSY1k=; b=PpLqAwsCtKFVunWGgfOaLmvLYXVLnrIxesdgKvKWXZZUQ1Cw7JbKaTtU+qO67vuDpv22YH 1eprtQpCWi81695q3/+0AtA2G0lVF1kmMlRJuQ9K7lPn7pz2C9JygGxVWrYk1NPsZSXVjX BhGWYapAINm2cKiZBwN+gS6zqHB42Ng= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b4olZ5kh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686692181; a=rsa-sha256; cv=none; b=WNMEETXAkczj1GAjWTKLZgRMXoX6ll9NbsbWny3y/GphZ11PTw6VXRWN9b1p2cEV1qrloj nXMKlrhRLS8F/QhTBBLY113mJSG0+sbFTu8xivb2+uJWZWoIa5tG0hBp07NNQOSoWJoBUE aE5eSoSFTQTABgNAPkPxhn4iF0uYeD4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686692180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ds/y7lH76obKk3se56kRnUXeuApDjVV7xaTlhnaSY1k=; b=b4olZ5khCAoYI7d3CmYbLcpP2WsXu4TidVpvHYr5Ne5R6hhntSdShb+3scbRV7l+/QKPDw 4bmbZ8SWlRNuDzpFgqzASMUovdlkFHZpzA3Xriy9tZ3mfX0TEUU2S6ToVFc/KCjNm7qCFk sLzki9WKL9WH0tJ0Vx5xStghjpjGt6g= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-eu5Jh_yLPdaKczsKDCMpHA-1; Tue, 13 Jun 2023 17:36:15 -0400 X-MC-Unique: eu5Jh_yLPdaKczsKDCMpHA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C4F90811E8D; Tue, 13 Jun 2023 21:36:14 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3D5D140C6F5D; Tue, 13 Jun 2023 21:36:12 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1156283.1686692027@warthog.procyon.org.uk> References: <1156283.1686692027@warthog.procyon.org.uk> <431929.1686588681@warthog.procyon.org.uk> To: David Hildenbrand Cc: dhowells@redhat.com, Jens Axboe , kernel test robot , Christoph Hellwig , Andrew Morton , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Lorenzo Stoakes , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: Fix dio_bio_alloc() to set BIO_PAGE_PINNED MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1157973.1686692171.1@warthog.procyon.org.uk> Date: Tue, 13 Jun 2023 22:36:11 +0100 Message-ID: <1157974.1686692171@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Rspamd-Queue-Id: 578D91C001F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: yghjwx8ci35wjy1j8emp4esrfg4t81co X-HE-Tag: 1686692181-721229 X-HE-Meta: U2FsdGVkX1+EATixmSJn2l/fIKkR85fQGsdh7XObQJit5oenNe1nnET6NQWTT6vGM5A+zA1C4vv0mePJYJWHInlxsIuC38+nRRw/CWYDznEB97jFWkGEnB279Gp7GIT4ZOJIZo/WfyMquKTynVefHxT/E4t6nRqbcHBzFerzCbzCo6bkJSHSuJC9Ug6XMDM9s0b7XOxAwbXk+P2wB2q9myHvcPB7Mj9t+D8ncXf/jUvuZJy51FvPT1WR2RB70Ugvrr65mzrH4q1md8nMz36GqzxwJP2hn6nZzgW5FNv0uj7OOmNd+hNwVlgVAlkJd8NkXrlYoEe0MgxxMnp36b9S4RMlIa69BjxQlqRPjYcRnuTlgnWd+KDAXhcajcTfn3jQA6Qnqlc9KQH9nnv7yMqxrTXm/8nj9+4WFm+LytCHcTNA1TKYNib409a+8EtsyK7EXISW6sTqwxdyS8X94D5Ik9GYMq37lQhc4+H4EpBsJYMl4GIxRESSyW6laQSntcStvt+HyHGTXfskHR0oHmTl2gmx5e3zpE2t3Vcq1jQVSWdzG7r+/z+pgaQGWXh5BYOrc4XjVvEdL+03b638F6A0kEqi+j83DAtEQcuRLBRlDXQCJjwwkgcVS3DT1eprRyzAy8zqcjiChIvBvJkm9LfZIjNHfOhuTduIofW86lOC2I4m8UBQmXBuUcB30lKcDOC8V4hpNumXctTwAje/WrDxI7RRfqmTX6Z0Qt7tPcUjSRG06jbA/Cg4GDqy2CSUxLZFFg1evHB21NAC+DptJ8E2oCX0bk+cAXxPrqbVb2VjFsYKobqkmMeDc4R1PYBuQ2GmSGvT6vtziz505uH5oS3iCfHXy/mTJp6yE+AlTqzsjgDtg7TX409KH3Hn3bsDXezdodmLdzH1GIJjNV1W3nKdmB0NYFyFknjYINcRGlfGVzDn4Pve0wHNyI6VC0QKkdw3QjtiNxXcx1zsOOt4ZXV NM9lMAST Q4/8FGb7iHV6B2syqlnSb+bhJ0MRSW1mwP6ZvbPqLlnLwkFpVhGd1otuyQfzTSHARl1l1ptOKVxZry5E6jOTUtvYBWrBo5Q+iYxhwlJPwxZUK2uXwnxCiDokgSUaNObBLsBpCBdYNepIszwFkCYbzTADf6uZ+sC6WnPGZnhowhHk6Zmz02MiThVBzQbEXLdUKDrkwHAIEaYdulZo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: static inline void dio_cleanup(struct dio *dio, struct dio_submit *sdio) { - while (sdio->head < sdio->tail) - put_page(dio->pages[sdio->head++]); + if (dio->is_pinned) + unpin_user_pages(dio->pages + sdio->head, + sdio->tail - sdio->head); } /* Meh. It's obvious. Need to advance head. David