From: Dave Hansen <haveblue@us.ibm.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: linux-mm@kvack.org, linux-ia64@vger.kernel.org,
rdunlap@xenotime.net, lethal@linux-sh.org
Subject: RE: [RFC][PATCH 10/10] convert the "easy" architectures to generic PAGE_SIZE
Date: Tue, 29 Aug 2006 14:13:29 -0700 [thread overview]
Message-ID: <1156886009.5408.183.camel@localhost.localdomain> (raw)
In-Reply-To: <617E1C2C70743745A92448908E030B2A728D28@scsmsx411.amr.corp.intel.com>
On Tue, 2006-08-29 at 14:06 -0700, Luck, Tony wrote:
> > Note that, as promised, this removes ARCH_GENERIC_PAGE_SIZE
> > introduced by the first patch in this series. It is no longer
> > needed as _all_ architectures now use this infrastructure.
>
> Either I goofed when applying these patches, or you missed one
> in mm/Kconfig. The version I ended up with had the "Kernel Page Size"
> choice still "depends on ARCH_GENERIC_PAGE_SIZE" ... so make
> menuconfig didn't let me choose the page size.
Yeah, during all of my repatching, I managed to forget to rip that out.
Thanks for finding that. Just killing that depends line, or applying
this should fix it.
-- Dave
threadalloc-dave/mm/Kconfig | 1 -
1 files changed, 1 deletion(-)
diff -puN mm/Kconfig~fix-mm-Kconfig mm/Kconfig
--- threadalloc/mm/Kconfig~fix-mm-Kconfig 2006-08-29 14:11:25.000000000 -0700
+++ threadalloc-dave/mm/Kconfig 2006-08-29 14:11:26.000000000 -0700
@@ -4,7 +4,6 @@ config ARCH_HAVE_GET_ORDER
choice
prompt "Kernel Page Size"
- depends on ARCH_GENERIC_PAGE_SIZE
default PAGE_SIZE_4KB if MIPS || PARISC
default PAGE_SIZE_8KB if SPARC64
default PAGE_SIZE_16KB if IA64
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-08-29 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 21:06 Luck, Tony
2006-08-29 21:13 ` Dave Hansen [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-29 20:19 [RFC][PATCH 00/10] generic PAGE_SIZE infrastructure (v3) Dave Hansen
2006-08-29 20:19 ` [RFC][PATCH 10/10] convert the "easy" architectures to generic PAGE_SIZE Dave Hansen
2006-08-30 10:05 ` Paul Mundt
2006-08-30 14:56 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156886009.5408.183.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=lethal@linux-sh.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rdunlap@xenotime.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox