Re: [PATCH] call mm/page-writeback.c:set_ratelimit() when new pages are hot-added

[Dave Hansen <haveblue@us.ibm.com>]

On Mon, 2006-08-28 at 15:23 -0700, Chandra Seetharaman wrote:
> --- linux-2.6.17.orig/mm/memory_hotplug.c
> +++ linux-2.6.17/mm/memory_hotplug.c
> @@ -141,6 +141,7 @@ int online_pages(unsigned long pfn, unsi
>         unsigned long start_pfn;
>         struct zone *zone;
>         int need_zonelists_rebuild = 0;
> +       extern void set_ratelimit(void);
>  
>         /*
>          * This doesn't need a lock to do pfn_to_page().
> @@ -191,6 +192,7 @@ int online_pages(unsigned long pfn, unsi
>         if (need_zonelists_rebuild)
>                 build_all_zonelists();
>         vm_total_pages = nr_free_pagecache_pages();
> +       set_ratelimit();
>         return 0;
>  } 

Hi Chandra,

It would be great if you could put set_ratelimit() into a proper header
like the rest of the functions needed by memory hotplug.  These kinds of
externs are ugly because they can too easily get out of sync with their
definitions and cause problems.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>