linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Chandra Seetharaman <sekharan@us.ibm.com>
To: linux-mm <linux-mm@kvack.org>
Subject: vm_total_pages and page-writeback.c:total_pages
Date: Tue, 22 Aug 2006 16:53:23 -0700	[thread overview]
Message-ID: <1156290803.6479.129.camel@linuxchandra> (raw)

Hello,

I was looking at page-writeback.c and found that there is a static
variable "total_pages", which is same as the global variable
"vm_total_pages" except that "total_pages" is not updated when new pages
are brought in through memory hotplug.

Looking at the usage of "total_pages", it doesn't look intentional. Can
somebody tell if it is the intentional or it a bug that needs to be
fixed ?

Under the same context, "ratelimit_pages" in page-writeback.c is
recalculated every time CPU is hot added/removed. But there is no
recalculation happening when new memory pages are hot added. This also
doesn't seem to be right. Comments ?

regards,

chandra  
-- 

----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - sekharan@us.ibm.com   |      .......you may get it.
----------------------------------------------------------------------


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

                 reply	other threads:[~2006-08-22 23:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1156290803.6479.129.camel@linuxchandra \
    --to=sekharan@us.ibm.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox