From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F99EB64D7 for ; Tue, 13 Jun 2023 21:33:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B7448E0003; Tue, 13 Jun 2023 17:33:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 466F58E0002; Tue, 13 Jun 2023 17:33:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32E738E0003; Tue, 13 Jun 2023 17:33:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 193808E0002 for ; Tue, 13 Jun 2023 17:33:59 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E7016C0500 for ; Tue, 13 Jun 2023 21:33:58 +0000 (UTC) X-FDA: 80899027356.15.7D2AE52 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 19140A001C for ; Tue, 13 Jun 2023 21:33:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f8bs9A3G; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686692037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sq4Gobht14PLhIrlUF3qoMat2z47BnhfNavxp+vbMx8=; b=pKhDTs2FuOAsMMtxqGNq4xBnhEK5d0IOSeKuR2jgpe1gu/bFsN1dGxK6gwS6ELH+fLE2si 66KMElZPSO31ZY8VC5g/LR4AxFojpitBasNRF4V55XDbv6qDNfUft/ZfK3eMepd2jm9bQ4 1EgJzw9J7w0NtlPh3OXBeiayk/9hCrw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f8bs9A3G; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686692037; a=rsa-sha256; cv=none; b=lCJIZwEgz9IXD5trMjHF4Ygq+eTdmd+hfQ8dMEaScKBAM8lNCSuQcOZnjCdF/IkHRUF1Je CT7X9jbpEuKCDsQeIyZAEWHVh9IBC8YbkL3YScM/BIX4Y16S0MDwOceEeq/vvp/Ky+d4q7 B6N3IVRgn6OySEKTd9ZpMuXLfvZl3c0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686692036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sq4Gobht14PLhIrlUF3qoMat2z47BnhfNavxp+vbMx8=; b=f8bs9A3GD4b6aJDbvXd9edq4IRVgsEHJx3hhkzKFhvQBquU1clUT/Rkyu4SXA5FsNyFJWg hm1b3olhPF0jSb9YOU1c/pTwBJJdnwXDiFB8mUWdORYSM/pm8H8AvB65EVV9yrQlfv7ctV YvKx8yxs37XdsWmZSfzIM07hafLOuZE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-26-n-lhBdEfO5-ebbjiGfLzWQ-1; Tue, 13 Jun 2023 17:33:52 -0400 X-MC-Unique: n-lhBdEfO5-ebbjiGfLzWQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5184F1C0512F; Tue, 13 Jun 2023 21:33:50 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7C0B140E951; Tue, 13 Jun 2023 21:33:47 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <431929.1686588681@warthog.procyon.org.uk> To: David Hildenbrand Cc: dhowells@redhat.com, Jens Axboe , kernel test robot , Christoph Hellwig , Andrew Morton , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Lorenzo Stoakes , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: Fix dio_bio_alloc() to set BIO_PAGE_PINNED MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1156282.1686692027.1@warthog.procyon.org.uk> Date: Tue, 13 Jun 2023 22:33:47 +0100 Message-ID: <1156283.1686692027@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Rspamd-Queue-Id: 19140A001C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9bdnxwndy5g13815rmxzj9bhx4wgpnan X-HE-Tag: 1686692036-815361 X-HE-Meta: U2FsdGVkX1+LhwLgIuWFpnRW2I458eQyej6LN/gObFL7xjhrsVstpjd7T+DP12Ru3FVcMlX/GoOBu5sWL+jau1dAgjFVxJCOKymQndnQa9gnX8DSGVFccdmsMUNT2FSSuxfNtmxo/bRV3KpEEaf3vnfnkGhk+B3Pl4RQYUwWJK7ctKq1GCG6VbteAhP3Od4BZZjySSZFO15KYQrYurpvG4xJeNjdXCDUz6j7xjwQJHufRR/gWJdfsu/G/5D7t041Cx36Zb/WiAJN3MeS10/sOXkwSFEX6GyOImM1p7MT24VtLvdPyUWzpbX+xiEZlb1kELSaFpsR/0hMxdMJ0G0/M9ylu141ZwlJtJbTBnWOhXDWiSAPCnfvTkcR263yqz8ONiXjB7mdBwP9xwUZfyvkyUwDmpUm/cA8Z9iBUUemd3n5jxbmibu0HIHzuQbMWLbikgE0cfbfmaf6wlO1O0AdTJfZ24ocUp/leFwZL1PbhLPpNqoqPNsjPOWTcvBEFQH3cU/nccaBXQPtdgAcdNQvLVT+a4+njkjlMe4SUUM0naDS+HXFMOhT+zPOavi7HMTYiA3pK9OTD4wIB3B4PYOp3bmvi9Oo3yFpzdipjrVu6hl5bXYPpybIUfRBwtaNrxhuxRcyG6RNtNMr2bTNQhH4YI8znDn3l7uEQKFZzDhm8XeSTim4CItcTPd28AoOa/+JNxeyo/Nr9ucvC9EJ1bcuNhI2Z2eMSqYUk2TCbBmiV4xMHXINd7RNcpYoERPxi2LcGAbLH2dm+aumAvjCSfqmgMXtXNcBFp1BqbRwbBAYTiAJxlzyYMFOR/x2qg1Iv2dJAGDj9YCgKv2HcGhLRlSwU9w1bz4mfnvinIelYErrdUBGBE9WO2F1O6NmMKMOG1gO4KWDiF6j/UECeAObP8r3v2eAhJQG4By1M3Z3h8vybYgV/Djs8AatklslCz2QX1eTvR2tGUbd+K8J54xnAR9 20QGGcZp xRf/twq2B2VghTigKg1jsbEGWd54dCUAHQ7pZFcoG+qY4xW1ynlpbU1ElpscfUTJu9MH4B3Bc5sduoobJXQ5IlsU6bU4kVYQYc2sHv6rTbOyKiK18g2dGKqVjqWumowLpV5Cr4XDKweKPbj2IExdd7YtyNIH1Y53sKTKTTMVFpLeEVWiZQKMyAkcVqEuuwkW+YrVH0dNvaekbvG8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Okay, it isn't this. The problem appears to be that __blockdev_direct_IO() calls dio_cleanup() twice if do_direct_IO() fails. David