From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3345E6FE33 for ; Fri, 6 Sep 2024 17:20:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D7BC6B0089; Fri, 6 Sep 2024 13:20:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 360C66B008A; Fri, 6 Sep 2024 13:20:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DAA56B008C; Fri, 6 Sep 2024 13:20:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F292B6B0089 for ; Fri, 6 Sep 2024 13:20:12 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A044F160B09 for ; Fri, 6 Sep 2024 17:20:12 +0000 (UTC) X-FDA: 82534976664.14.A4126AA Received: from fhigh1-smtp.messagingengine.com (fhigh1-smtp.messagingengine.com [103.168.172.152]) by imf27.hostedemail.com (Postfix) with ESMTP id 8335140009 for ; Fri, 6 Sep 2024 17:20:09 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=GUTFNgtQ; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="U 9R9wPK"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf27.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.152 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725643137; a=rsa-sha256; cv=none; b=Ul7c3QCMvMV2oIuAn1R7ODCva4aRvCpsNCYotY8/maIrot+H2mfNaxhvGZhMcB6QXRxS4d Lf/IWM4v9+u57Di039qRd/TRtI4150QrZeiIsDubT/4lhJuIIH6xhH15SfNGY2lIMVCLz5 N4iDn8Mf6iwWzwukJmZnuK1zyf2wC7I= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=GUTFNgtQ; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="U 9R9wPK"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf27.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.152 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725643137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pGqQNxsj9qfH9QsO5+3KB74ZxiKlh96u9meajutmSw8=; b=SAddeJ3zZxcRlU28Fx2SFnBLkuWSYhx8okPUbsbJBNVBaJde0ll3pEj7vcUTczcBX226w3 ogzfqdD2JGWTg8mdKaITWEBWzW61P9V76b/TAXPIHD9kUBkv2W/lcpChMmY/jM3+CniwCP bJLkiV3V10DIHO8+rvuNBhbcBBS+JR0= Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 8FB57114017E; Fri, 6 Sep 2024 13:20:08 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Fri, 06 Sep 2024 13:20:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1725643208; x=1725729608; bh=pGqQNxsj9qfH9QsO5+3KB74ZxiKlh96u9meajutmSw8=; b= GUTFNgtQFspoqY52oTwNT8LGQnoU4H5uEN9RCeE6gsv3bwEHDlnVhLP50Pdu9Fu2 2kdGuRC787ra70SOi0UHXcegX3AHoLHukGeHXAxg56kIS58HVYC7w0+P/Sm2cSLN DlbIi+sdAUcRaOLVdAU1qUpy/WCbNDNwKiSA6lU8WR8S55y1WdO/oJyoHm07EssY osYOgAcVNnf8/sawYqWKezWV/nLNODEen6w+s2P8IiLxkOjLiI4YkBD/VLV0Q/Nl 6LgaZTm7eHbRfQmgYIxXLKmyMpGoLDZRf0mr70S4kMDxBizzrN9ysSeLtNhthK// LeElrKukKR3n4/4pKHbsYg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725643208; x= 1725729608; bh=pGqQNxsj9qfH9QsO5+3KB74ZxiKlh96u9meajutmSw8=; b=U 9R9wPK1G+49xOApyDsYUf3Fu3yQ5Vpd576/nOMIoIbwoax7odlvHHdYUQdZREVmx QM0CI//E+Bd1YBnjFtXWJqWAI/+gS2W6Br6mrc9hWBYIotQZp/LIjc1yeih9r2RK YSX5FTqLJ28Y/ekzoUfrJHsdpTQx1lH9uBInGAazEeAImpPc248R57rdLjcJKh7b FC0zG3bUZ7bgUI1Ypp1mUO+ZpoF4QLx2p8qce88pDSkAhmKPZFCRg7cpuojXe9Zb uwIPs45uyLTqZzS06qMWOb1tRyHBPRe70+6F2cKBNHPLL0PizwmXMCaEqWbgDz02 WNjstbFo++LL9oHYolAiw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeiuddguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredt tdenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusg druggvqeenucggtffrrghtthgvrhhnpefhtdfhvddtfeehudekteeggffghfejgeegteef gffgvedugeduveelvdekhfdvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggvpdhnsggprhgtphhtthhopedv tddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepsghpsegrlhhivghnkedruggvpd hrtghpthhtohepvhhinhgtvghniihordhfrhgrshgtihhnohesrghrmhdrtghomhdprhgt phhtthhopegthhhrihhsthhophhhvgdrlhgvrhhohiestghsghhrohhuphdrvghupdhrtg hpthhtohepmhgrthhhihgvuhdruggvshhnohihvghrshesvghffhhitghiohhsrdgtohhm pdhrtghpthhtohepmhhpvgesvghllhgvrhhmrghnrdhiugdrrghupdhrtghpthhtohepnh hpihhgghhinhesghhmrghilhdrtghomhdprhgtphhtthhopehrohhsthgvughtsehgohho ughmihhsrdhorhhgpdhrtghpthhtoheplhhuthhosehkvghrnhgvlhdrohhrghdprhgtph htthhopehmhhhirhgrmhgrtheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 2F9C7222006F; Fri, 6 Sep 2024 13:20:07 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Fri, 06 Sep 2024 19:19:46 +0000 From: "Arnd Bergmann" To: "Vincenzo Frascino" , linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org Cc: "Andy Lutomirski" , "Thomas Gleixner" , "Jason A . Donenfeld" , "Christophe Leroy" , "Michael Ellerman" , "Nicholas Piggin" , "Naveen N Rao" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , "H. Peter Anvin" , "Theodore Ts'o" , "Andrew Morton" , "Steven Rostedt" , "Masami Hiramatsu" , "Mathieu Desnoyers" Message-Id: <11527a80-7453-4624-b406-e88c5692b015@app.fastmail.com> In-Reply-To: References: <20240903151437.1002990-1-vincenzo.frascino@arm.com> <20240903151437.1002990-4-vincenzo.frascino@arm.com> Subject: Re: [PATCH 3/9] x86: vdso: Introduce asm/vdso/page.h Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8335140009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: tb1p7suu65eiiqtkjy9xgq3b15x139ex X-HE-Tag: 1725643209-503364 X-HE-Meta: U2FsdGVkX19G69Nn49LJVCUUiUnl1oPrvTvilPKUX2lwpNNveoVNtTlkkP0UwNQE/AKk4nUAliEpQz7mn7VRquG8/NAaVx+NQMY/qbaWLdAOgzMRymqwQOneKWFZ+vhL3kwa6p0EAMctiIIP4jfQ+pjBSlAqqBZMoumiNmeCMe54L6LV4nsf5Mc6eKqn/QL81A4xnppNzXYVJ+Z+jdB78JHjn5sfV+p0dAoiejSml3tI5OAslo8hA9wEPn6AcEREOG0RU6pbFGr/BXENCO4zvHe/5rc6Qj2gc9zi6AQHVxy7laOxaBFEN8YUQOKAd2Mo6JIlQF+uRlU39gZOegpLpOPuLlpKt6Yy0C7hjzV09KPS5aLTBHjPyjVzQARe6gUkX2gCaJNbhvy1YbeEkJSxqZ5GXV/XOBPO+2QlC4ARsORlDR9BZn5XiAS6c/0b0cupyxkAnzP298qTDDYoRUWfC96lm4EG1RDHJLdYatCNOdmhx5w8Pn88wPGLJJ8Yp8O7Hu5Asijwo2Exc4R/lWOHQPk6mxiLelr79lluzoWnaz5x32TNXcDfGsghZOGU0vdDNPNsjy6wdoUWm25oAIco2FfB6g1Pg7epx6ig4JtV1O9FP0Kk/SpA+ceC505JCK8aUaXnjg6Z0Em+5GRGeV9hTJcnGIoFi6WMGHW/RDs2sMim8sj3tPH+sOSQs2yeif4yyM0oWdhoJfTUijB5Mz35B/HxmmA3Xkl4eS+siL60BEgMDwlLa2LkzS0dwwb7dCs9nMG2WhOgpzehMc5gBXYbWlByx85iqBz9a3M2ZNS5MFwdZzWkRFlpvlOgTtyTThV0UeZH9COafMr0GWw00IHmgScMIa7wHVdv586PsYEIUmnDUxBqY7C1GhJvxuHFeemP+cYPVFP9rS4KJMzP1aTfFdq2/HYwPK/ab7nXwGcIIv4Bj49SY7/aY78vF05a5l36psH2psUGw+iWiDKvyct nNOvH2Dk noHnqWshAV8a8ySyjzlYvKHP2sH/bB+Ii70vadk02k9OUrAuVbTD8cKKRzetE0DiTIr07v7KCsptnJqCUlGUXNbceET+S0aDKzCcJymRSGTVqxwLOqiQ8Wn2GGv1HTLlQBJFOdpgsNm211tEyPZzZd1qA4DfbQ8hOfkQZioRfDYsd8RrIHC5Wy6BB/ydQkFumyg7oeIyv9UPPf1tx2jAsU1AH9Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 6, 2024, at 11:20, Vincenzo Frascino wrote: > On 04/09/2024 15:52, Arnd Bergmann wrote: >> On Tue, Sep 3, 2024, at 15:14, Vincenzo Frascino wrote: > Looking at the definition of PAGE_SIZE and PAGE_MASK for each architecture they > all depend on CONFIG_PAGE_SHIFT but they are slightly different, e.g.: > > x86: > #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) > > powerpc: > #define PAGE_SIZE (ASM_CONST(1) << PAGE_SHIFT) > > hence I left to the architecture the responsibility of redefining the constants > for the VSDO. ASM_CONST() is a powerpc-specific macro that is defined the same way as _AC(). We could probably just replace all ASM_CONST() as a cleanup, but for this purpose, just remove the custom PAGE_SIZE and PAGE_SHIFT macros. This can be a single patch fro all architectures. Arnd