linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Christoph Lameter <clameter@sgi.com>
Cc: Rik van Riel <riel@redhat.com>,
	Linus Torvalds <torvalds@osdl.org>, Andi Kleen <ak@suse.de>,
	Rohit Seth <rohitseth@google.com>, Andrew Morton <akpm@osdl.org>,
	mbligh@google.com, hugh@veritas.com, andrea@suse.de,
	arjan@infradead.org, apw@shadowen.org, mel@csn.ul.ie,
	marcelo@kvack.org, anton@samba.org, paulmck@us.ibm.com,
	Nick Piggin <piggin@cyberone.com.au>,
	linux-mm <linux-mm@kvack.org>,
	Nikita Danilov <nikita@clusterfs.com>
Subject: Re: [RFC][PATCH] inactive_clean
Date: Mon, 19 Jun 2006 22:46:10 +0200	[thread overview]
Message-ID: <1150749971.28517.122.camel@lappy> (raw)
In-Reply-To: <Pine.LNX.4.64.0606191308470.4203@schroedinger.engr.sgi.com>

On Mon, 2006-06-19 at 13:11 -0700, Christoph Lameter wrote:
> On Mon, 19 Jun 2006, Peter Zijlstra wrote:
> 
> > > Hmmm.. My counter patches add NR_ANON to count the number of anonymous 
> > > pages. These are all potentially dirty. If you throttle on NR_DIRTY + 
> > > NR_ANON then we may have the effect without this patch.
> > 
> > Sure, but what do you do to reach you threshold if there are not enough
> > mapped pages around to clean?
> 
> You reach the threshold and the writeout happens. So there are enough 
> clean pages available.

I think we look at the threshold from differ sides, what I meant was:
we want nr_clean > nr_wanted_clean, where nr_clean = nr_clean_anon +
nr_clean_mapped. Now nr_clean_mapped = nr_mapped - nr_dirty_mapped, what
if nr_mapped < nr_wanted_clean?

You need to increase nr_clean_anon to reach nr_wanted_clean.

> > At that point the only thing left is to make sure some anonymous pages
> > become clean, that is write them out to swap and have them sit around in
> > the swap cache.
> 
> Thats fine. The threshold just insures that you can write out the 
> anonymous pages.

But you need slightly more than just writeout, you need to create a
clean anonymous page, so you need to keep it around.

> > The next question is: 'which pages do I write out?', and there page
> > reclaim comes in; however are you only going to write out anonymous
> > pages and violate page order for file backed pages?
> 
> I would think that one would first write out dirty file backed pages.
> 
> What page order are you talking about?

LRU page order, and having a preference for file-backed pages breaks it.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-06-19 20:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-19 12:20 Peter Zijlstra
2006-06-19 15:45 ` Christoph Lameter
2006-06-19 18:10   ` Peter Zijlstra
2006-06-19 19:03     ` Christoph Lameter
2006-06-19 19:10       ` Rik van Riel
2006-06-19 19:24         ` Christoph Lameter
2006-06-19 19:27           ` Rik van Riel
2006-06-19 19:58             ` Christoph Lameter
2006-06-19 20:05               ` Peter Zijlstra
2006-06-19 20:11                 ` Christoph Lameter
2006-06-19 20:46                   ` Peter Zijlstra [this message]
2006-06-19 21:48                     ` Christoph Lameter
2006-06-19 20:28               ` Rik van Riel
2006-06-19 21:45                 ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1150749971.28517.122.camel@lappy \
    --to=a.p.zijlstra@chello.nl \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=andrea@suse.de \
    --cc=anton@samba.org \
    --cc=apw@shadowen.org \
    --cc=arjan@infradead.org \
    --cc=clameter@sgi.com \
    --cc=hugh@veritas.com \
    --cc=linux-mm@kvack.org \
    --cc=marcelo@kvack.org \
    --cc=mbligh@google.com \
    --cc=mel@csn.ul.ie \
    --cc=nikita@clusterfs.com \
    --cc=paulmck@us.ibm.com \
    --cc=piggin@cyberone.com.au \
    --cc=riel@redhat.com \
    --cc=rohitseth@google.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox