From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A58C282C5 for ; Mon, 3 Mar 2025 10:25:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DCAE280007; Mon, 3 Mar 2025 05:25:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18CE1280004; Mon, 3 Mar 2025 05:25:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02CF2280007; Mon, 3 Mar 2025 05:25:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DB15B280004 for ; Mon, 3 Mar 2025 05:25:52 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8FA84C0615 for ; Mon, 3 Mar 2025 10:25:52 +0000 (UTC) X-FDA: 83179858944.05.9ED29A4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 2FC49C000E for ; Mon, 3 Mar 2025 10:25:50 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MLQJgK14; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740997550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/4KOg+srD3osUkcxLxbpxfwxBiZZhDfZ2shC+b7IsFQ=; b=tzMKvEFqv3Ba7r2qN4ovZ8PBcOdPUF/MiziSOzP3A9dBkXPnIsmR4Du2XafUoG4ham7adA m+LHhSDaUWBgP+sje/SqFHS8wBzRSzWULwMS43xITQG4md8NDPvGKWTUuhPhA6YbkWAmO3 Xkqsy8Bv17WOuHXWgU57N3KMEw2GZRM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MLQJgK14; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740997550; a=rsa-sha256; cv=none; b=egcrn3ONhWOLrcfNDG1BmSZ3bi6aIvDFm+YeXtis/MCwKZW0mVt0X8Wpuo2nCz5AFSUJrW p9ZfP8IX1d2+VMvMqhEcL6QgTaPQrlbU37XLlG87nVPL7ln5I2ka09tYf1XSU2IJlnLN3/ Ej2TU932RQgyqmspsFLhnj0x28PycFU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740997549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/4KOg+srD3osUkcxLxbpxfwxBiZZhDfZ2shC+b7IsFQ=; b=MLQJgK143x8bWX4fxB7VviHHzNRLaFZuJCGdQKh866JG+yM3dyTjKxSHgZX0NMNUqdytoc Y/RXgS0Nsw1z147zJNNHgmCtrNBjHAg4WH12nVVRkiqci8L3yN0sAREhTd5v3LUI/kFb2X Xp8IZn742WAA9o/sqMbf2oQCskE3pWY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-bfwWGG78PyeA-Zi7mySCXw-1; Mon, 03 Mar 2025 05:25:48 -0500 X-MC-Unique: bfwWGG78PyeA-Zi7mySCXw-1 X-Mimecast-MFC-AGG-ID: bfwWGG78PyeA-Zi7mySCXw_1740997547 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3911218d81cso260038f8f.1 for ; Mon, 03 Mar 2025 02:25:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740997547; x=1741602347; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/4KOg+srD3osUkcxLxbpxfwxBiZZhDfZ2shC+b7IsFQ=; b=OQn+PKkqxqXkh5qobg8jbYG0RbGwEVDwzttM0qlSVMvq9VW+dWEIO0iMGrg1TfAs64 NMNhh0Z1Dswi4XAymjK0C/8LFd0zv4siMwHaAkK9mkivxTeck1BbyNul3pDn7rBBi2j4 7ig53XfIAEjr8kwOmok+Kt+55i0211IkHwMeTDHvxoxHqWvdotb5tfhSmEEvGchuF4nk tC2Q/9a4ouiL+4xdfO7nvYHPAqaHJc8VtT+VBbrz+kohg/lmXj9+V9fDv5J1Cuoh7EYg yOUeszzbHqxJ9BGxSaBSe8hs/mn5tFIMmVpi+bUq7iwrJcYgPkrkxMa+67XLzMI30qpB a2uw== X-Gm-Message-State: AOJu0YzRsQVAnanyxsWlyooxcYJorS4Fr1/1kPSu+pqUBpiLYdgKU5mT fhN2zKmKyVZh1Ig7jlYj9U/HGLDMBZplb3TSt/epUxKv2wMqKNWsE1fpSTldKzKVDbskdAXfri6 KFLtR0Xh3SZut74y+5QZYJbhvc3T1vq21MlttmCP1eYCtN7MS X-Gm-Gg: ASbGncudXfNIbLRz87uzHVL6c62VTVhfXERl1YNoOG+BO7SyZ84pvufguRJMj/WUFU7 UU50t4E8uCLmukT6AJyaOuvDCH94ct13C+zY7GNDs00iYtUdShnwOzTCbFjZsYMFGu8SQotLzKw B6B6nRxw2q+S+RHhoea7r2LSNJ2jng2wzbVthRhqstZX/33OBDBwulW2sdjm1DnmzBCq6hnEOWX mbiwJ67QzDZgHjcfsciOMZl79xzNVCx3mtPYL+Djbj+AposxtWS3p0Vcr36DgqVHDLYcpPndO0j 5NM7ZtHpx23/DrJEooS40OTedvfin11bWhjzyx29aqshwFqiJmUFvqDp2fcqvryNSIGV7S45YhD ZbrQEG+6viFntiUPGmWo3+XTQuRPYlrAUScd7CmZXlo4= X-Received: by 2002:a05:6000:178e:b0:390:f1c1:d399 with SMTP id ffacd0b85a97d-390f1c1d4dfmr8558032f8f.41.1740997547101; Mon, 03 Mar 2025 02:25:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFh7unzqY5XSF990DK9I9PYSxBWZglnnblmXNgMo9J8zLl6TgZ6/XPm2tyQJgVSh/0s8OZEUA== X-Received: by 2002:a05:6000:178e:b0:390:f1c1:d399 with SMTP id ffacd0b85a97d-390f1c1d4dfmr8558013f8f.41.1740997546770; Mon, 03 Mar 2025 02:25:46 -0800 (PST) Received: from ?IPV6:2003:cb:c734:9600:af27:4326:a216:2bfb? (p200300cbc7349600af274326a2162bfb.dip0.t-ipconnect.de. [2003:cb:c734:9600:af27:4326:a216:2bfb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e485d6cdsm13954057f8f.84.2025.03.03.02.25.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 02:25:46 -0800 (PST) Message-ID: <114987e9-a449-4cc7-b897-b5b00a3cf445@redhat.com> Date: Mon, 3 Mar 2025 11:25:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: fix surplus pages in dissolve_free_huge_page() To: Jinjiang Tu , akpm@linux-foundation.org, muchun.song@linux.dev, osalvador@suse.de Cc: linux-mm@kvack.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com References: <20250303060920.2886263-1-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250303060920.2886263-1-tujinjiang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -zLvI59fMfWdvV1-SGTQuQx_D2eQPe68wVATHJyj0yw_1740997547 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: aqebapqrdyz1a4nmmw9hib9xyjsqckqu X-Rspamd-Queue-Id: 2FC49C000E X-Rspamd-Server: rspam07 X-HE-Tag: 1740997550-558941 X-HE-Meta: U2FsdGVkX18i6BNxP6nXujK3g4pXVigjbpOGtWHD6k6l8ER0j4ywL2LUf2iFFmnSAmqzoQ4gJjcrKymcQp6L3hxI5mK7HrarsxCjzafS+zV/l4TS+ZwxggU6AmkEAF7jJpPXFae6HL7FalTLN395PZhcuaN9EJpcIcXKZntmiQ2gWevuO1KJL8EnUOQHP5e1o4AiZN0N1DwrlwnQrswRnoAetkfz/PBVrC0bnIxE4yHyNjXRotx8bTEw3Wluwzdi9enWe15ZbDI4OOw0jaTz9a4Mt28t27/7Ztnz4KwfOeud9YJhMiHWWLGPYfyfMLGudKRQMVCOvv44I1TVjYYmD7hAboS0/Bf+VDZUS7Hwm6yDzIliSonaeMEl/T1j8A0gLtgk8K3RFr4dK7jHKUJ3m0YhpYkA71dk3JlB1kGK/MHZ7POZK1NRXSKTGEKMrGasG3L3NN9lBZS0foIjraH6OeNqIsozrYnO9L8mIGaVEz1jTLgHr/VXBN+ejvnN6/9wUbMRc94D0CS7kxkKj5v7TdFyLplpNkjAKawoFOjZqzqzwg6ePFuGNtDEuUEv0oH1SdRB4wprkzTO/DN0/PWO38n76Th7/OyS4x46nx7ix5jlum8CzOCu4xLujOSk5iKIt1MPJTd8Ol8bV4Sm6BgeG8SWWkk0DH3oCAxnmRWLHirZbQisk1X04JLv/Banu6Q4T0kY01R091Eau869+YUH+7BfUf4aPM6P7sLYVzYhqiiyjLf7nenX+ChUfqEzK6ADmf/dyboh+OVrwmYgQWvP/Ca+eVixlcHsyjz7YYUiSbcJcRb81cUdHcpD0lKa2XM15T+JKOJleZ5/EGMkC4KxsxWVFx7Ef1unX2Ena8YmuPNNVhkuW+i6GCETaPIQO2or5zMFITQ66HVtXh6CLUMsBjX0hbLIDCTp4ox6qjIhPFtN3TwXjPwm5z8HaS4VE6l+0J6GtFg60PH8weCCUBL VgDcMhn0 4AdNdoQIrH+9xeY1R13iM75uz0yLYULM9Mnj9AghiY8LynCDbNBMI4WUDmYjGID0Q0tNBs0+FzXiShFJyqGXxCG2kQ87guQ8eGJw/vklPFYtX4JROWsVGUzfVlfvvtWuk6u+eKb4rd18SDabMDYg+SGGdF7SduO71WMp8WhI5eDerfbfti9FKfYiA86jw+Jz1EdX1r5Ryp3sspQ7mG9HXIleQVMLMMd9NJiD1rwclfN9ftLy48bK+okSbRiU4oJ3a5cAYWZVsT1bQlA68azSRJmDfSzxqt0+AZAtsr79wnKLGm3AlDrS89r+8ZqBnQBZNfRrV5TA55twyPaVRVO51ZcUqSfplNTRkSLxm+Ad3ABUhHqgEDVPOPYQQsbRYIWhYZUez2clGl2Pk13gVEUUOextoAuhD/vfnALl4/3Ue7hmiyCVj3PCQL7TOqW0BhDqkjQY4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.003386, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.03.25 07:09, Jinjiang Tu wrote: > In dissolve_free_huge_page(), free huge pages are dissolved without > adjusting surplus count. However, free huge pages may be accounted as > surplus pages, and will lead to wrong surplus count. > > Steps to reproduce: > 1) create 64 huge pages for node1 > 2) run a program to reserve (don't consume) all the huge pages > 3) echo 0 > nr_huge_pages for node1. After this step, free huge pages in > Node1 are surplus. > 4) create 80 huge pages for node0 > 5) offline memory of node1 and kill the program in step 2) Can you elaborate the "offline memory" part? How much are you offlining (the complete node vs a single memory block?) If I skip the offlining part, it all works as expected on a 6.12 kernel. -- Cheers, David / dhildenb