On Sat, 2006-05-06 at 23:47 +1000, Nick Piggin wrote: > Yep. Let's not distract from getting the basic mechanism working though. > balance_dirty_pages would be patch 2..n ;) Attached are both a new version of the shared_mapping_dirty patch, and balance_dirty_pages; to be applied in that order. It makes my testcase survive and not OOM like it used to. > BTW. It is unconventional (outside the read hints stuff) to use macros like > this. I guess real VM hackers have to know what is intended by any given esoteric > combination of flags in any given context. > > Not that I hate it. > > But if we're going to start using it, we should work out a sane convention and > stick to it. "StudlyCaps" seem to be out of favour, and using a vma_ prefix would > be more sensible. Not a real fan of "StudlyCaps" myself either, just adapting to whatever was there. This macro was born because I find writing the same thing more than twice a nuisance and errorprone. However if ppl feel otherwise I'm fine with either writing it out explicitly or renaming the thing, suggestions? PeterZ