linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Adam Litke <agl@us.ibm.com>
To: akpm@osdl.org
Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
	'David Gibson' <david@gibson.dropbear.id.au>,
	wli@holomorphy.com, linux-mm@kvack.org
Subject: [RFD hugetlbfs] strict accounting and wasteful reservations
Date: Thu, 13 Apr 2006 12:36:42 -0500	[thread overview]
Message-ID: <1144949802.10795.99.camel@localhost.localdomain> (raw)

Sorry to bring this up after the strict accounting patch was merged but
things moved along a bit too fast for me to intervene.

In the thread beginning at http://lkml.org/lkml/2006/3/8/47 , a
discussion was had to compare the patch from David Gibson (the patch
that was ultimately merged) with an alternative patch from Ken Chen.
The main functional difference is how we handle arbitrary file offsets
into a hugetlb file.  The current patch reserves enough huge pages to
populate the whole file up to the highest file offset in use.  Ken's
patch supported arbitrary blocks.

For libhugetlbfs, we would like to have sparsely populated hugetlb files
without wasting all the extra huge pages that the current implementation
requires.  That aside, having yet another difference in behavior for
hugetlbfs files (that isn't necessary) seems like a bad idea.

So on to my questions.  Do people agree that supporting reservation for
sparsely populated hugetlbfs files makes sense?

I've been hearing complaints about the code churn in hugetlbfs code
lately, so is there a way to adapt what we currently have to support
this?

Otherwise, should I (or Ken?) take a stab at resurrecting Ken's
competing patch with the intent of eventually replacing the current
code?
-- 
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2006-04-13 17:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-13 17:36 Adam Litke [this message]
2006-04-13 19:18 ` 'David Gibson'
2006-04-13 19:51   ` Adam Litke
2006-04-13 20:01     ` 'David Gibson'
2006-04-13 20:06       ` Adam Litke
2006-04-13 21:32         ` 'David Gibson'
2006-04-14  1:55           ` Chen, Kenneth W
2006-04-14 17:33             ` Adam Litke
2006-04-14 17:40               ` Chen, Kenneth W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1144949802.10795.99.camel@localhost.localdomain \
    --to=agl@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-mm@kvack.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox