linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [RFC/PATCH] Shared Page Tables [0/2]
@ 2006-04-10 16:13 Dave McCracken
  2006-04-10 17:22 ` Christoph Lameter
  0 siblings, 1 reply; 5+ messages in thread
From: Dave McCracken @ 2006-04-10 16:13 UTC (permalink / raw)
  To: Hugh Dickins; +Cc: Linux Kernel Mailing List, Linux Memory Management

Here's a new cut of the shared page table patch.  I divided it into
two patches.  The first one just fleshes out the
pxd_page/pxd_page_kernel macros across the architectures.  The
second one is the main patch.

This version of the patch should address the concerns Hugh raised.
Hugh, I'd appreciate your feedback again.  Did I get everything?

These patches apply against 2.6.17-rc1.

Dave McCracken


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC/PATCH] Shared Page Tables [0/2]
  2006-04-10 16:13 [RFC/PATCH] Shared Page Tables [0/2] Dave McCracken
@ 2006-04-10 17:22 ` Christoph Lameter
  2006-04-10 20:11   ` Dave McCracken
  0 siblings, 1 reply; 5+ messages in thread
From: Christoph Lameter @ 2006-04-10 17:22 UTC (permalink / raw)
  To: Dave McCracken
  Cc: Hugh Dickins, Linux Kernel Mailing List, Linux Memory Management,
	Adam Litke, wli

On Mon, 10 Apr 2006, Dave McCracken wrote:

> Here's a new cut of the shared page table patch.  I divided it into
> two patches.  The first one just fleshes out the
> pxd_page/pxd_page_kernel macros across the architectures.  The
> second one is the main patch.
> 
> This version of the patch should address the concerns Hugh raised.
> Hugh, I'd appreciate your feedback again.  Did I get everything?
> 
> These patches apply against 2.6.17-rc1.

Could you break out the locking changes to huge pages?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC/PATCH] Shared Page Tables [0/2]
  2006-04-10 17:22 ` Christoph Lameter
@ 2006-04-10 20:11   ` Dave McCracken
  2006-04-10 20:20     ` Christoph Lameter
  0 siblings, 1 reply; 5+ messages in thread
From: Dave McCracken @ 2006-04-10 20:11 UTC (permalink / raw)
  To: Christoph Lameter
  Cc: Hugh Dickins, Linux Kernel Mailing List, Linux Memory Management,
	Adam Litke, wli

--On Monday, April 10, 2006 10:22:34 -0700 Christoph Lameter
<clameter@sgi.com> wrote:

>> Here's a new cut of the shared page table patch.  I divided it into
>> two patches.  The first one just fleshes out the
>> pxd_page/pxd_page_kernel macros across the architectures.  The
>> second one is the main patch.
>> (...)
> 
> Could you break out the locking changes to huge pages?

The lock changes to hugetlb are only to support sharing of pmd pages when
they contain hugetlb pages.  They just substitute the struct page lock for
the page_table_lock, and are only about 30 lines of code.  Is this really
worth separating out?

Dave McCracken

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC/PATCH] Shared Page Tables [0/2]
  2006-04-10 20:11   ` Dave McCracken
@ 2006-04-10 20:20     ` Christoph Lameter
  2006-04-10 20:27       ` Dave McCracken
  0 siblings, 1 reply; 5+ messages in thread
From: Christoph Lameter @ 2006-04-10 20:20 UTC (permalink / raw)
  To: Dave McCracken
  Cc: Hugh Dickins, Linux Kernel Mailing List, Linux Memory Management,
	Adam Litke, wli

On Mon, 10 Apr 2006, Dave McCracken wrote:

> The lock changes to hugetlb are only to support sharing of pmd pages when
> they contain hugetlb pages.  They just substitute the struct page lock for
> the page_table_lock, and are only about 30 lines of code.  Is this really
> worth separating out?

Ia64 does not use pmd pages for huge pages. It relies instead on a 
separate region. I wonder if this works on IA64.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC/PATCH] Shared Page Tables [0/2]
  2006-04-10 20:20     ` Christoph Lameter
@ 2006-04-10 20:27       ` Dave McCracken
  0 siblings, 0 replies; 5+ messages in thread
From: Dave McCracken @ 2006-04-10 20:27 UTC (permalink / raw)
  To: Christoph Lameter
  Cc: Hugh Dickins, Linux Kernel Mailing List, Linux Memory Management,
	Adam Litke, wli

--On Monday, April 10, 2006 13:20:59 -0700 Christoph Lameter
<clameter@sgi.com> wrote:

>> The lock changes to hugetlb are only to support sharing of pmd pages when
>> they contain hugetlb pages.  They just substitute the struct page lock
>> for the page_table_lock, and are only about 30 lines of code.  Is this
>> really worth separating out?
> 
> Ia64 does not use pmd pages for huge pages. It relies instead on a 
> separate region. I wonder if this works on IA64.

Sharing of hugetlb page tables is enabled on a per-architecture basis, so
if ia64 doesn't use pmd pages we shouldn't try to enable it.  If it's not
enabled all the locking in hugetlb resolves to using page_table_lock, so
the original semantics will be preserved.

Dave McCracken

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2006-04-10 20:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-04-10 16:13 [RFC/PATCH] Shared Page Tables [0/2] Dave McCracken
2006-04-10 17:22 ` Christoph Lameter
2006-04-10 20:11   ` Dave McCracken
2006-04-10 20:20     ` Christoph Lameter
2006-04-10 20:27       ` Dave McCracken

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox