From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e3.ny.us.ibm.com (8.12.11/8.12.11) with ESMTP id k2HI1VQ1018720 for ; Fri, 17 Mar 2006 13:01:31 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.12.10/NCO/VER6.8) with ESMTP id k2HI1Vvj156526 for ; Fri, 17 Mar 2006 13:01:31 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11/8.13.3) with ESMTP id k2HI1Ujk030012 for ; Fri, 17 Mar 2006 13:01:31 -0500 Subject: Re: [PATCH: 017/017]Memory hotplug for new nodes v.4.(arch_register_node() for ia64) From: Dave Hansen In-Reply-To: <20060317163911.C659.Y-GOTO@jp.fujitsu.com> References: <20060317163911.C659.Y-GOTO@jp.fujitsu.com> Content-Type: text/plain Date: Fri, 17 Mar 2006 10:00:34 -0800 Message-Id: <1142618434.10906.99.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Yasunori Goto Cc: Andrew Morton , "Luck, Tony" , Andi Kleen , Linux Kernel ML , linux-ia64@vger.kernel.org, linux-mm List-ID: On Fri, 2006-03-17 at 17:23 +0900, Yasunori Goto wrote: > +++ pgdat8/arch/ia64/kernel/topology.c 2006-03-16 16:06:27.000000000 +0900 > @@ -65,6 +65,21 @@ EXPORT_SYMBOL(arch_register_cpu); > EXPORT_SYMBOL(arch_unregister_cpu); > #endif /*CONFIG_HOTPLUG_CPU*/ > > +#ifdef CONFIG_NUMA > +int arch_register_node(int num) > +{ > + if (sysfs_nodes[num].sysdev.id == num) > + return 0; > + > + return register_node(&sysfs_nodes[num], num, 0); > +} > + > +void arch_unregister_node(int num) > +{ > + unregister_node(&sysfs_nodes[num]); > + sysfs_nodes[num].sysdev.id = -1; > +} > +#endif I don't have a real problem with you cluttering up ia64 code, but if these are useful, why don't we put them in generic code? They seem quite arch-independent to me. -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org