From: Dave Hansen <haveblue@us.ibm.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>, "Luck, Tony" <tony.luck@intel.com>,
Andi Kleen <ak@suse.de>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH: 017/017]Memory hotplug for new nodes v.4.(arch_register_node() for ia64)
Date: Fri, 17 Mar 2006 10:00:34 -0800 [thread overview]
Message-ID: <1142618434.10906.99.camel@localhost.localdomain> (raw)
In-Reply-To: <20060317163911.C659.Y-GOTO@jp.fujitsu.com>
On Fri, 2006-03-17 at 17:23 +0900, Yasunori Goto wrote:
> +++ pgdat8/arch/ia64/kernel/topology.c 2006-03-16 16:06:27.000000000 +0900
> @@ -65,6 +65,21 @@ EXPORT_SYMBOL(arch_register_cpu);
> EXPORT_SYMBOL(arch_unregister_cpu);
> #endif /*CONFIG_HOTPLUG_CPU*/
>
> +#ifdef CONFIG_NUMA
> +int arch_register_node(int num)
> +{
> + if (sysfs_nodes[num].sysdev.id == num)
> + return 0;
> +
> + return register_node(&sysfs_nodes[num], num, 0);
> +}
> +
> +void arch_unregister_node(int num)
> +{
> + unregister_node(&sysfs_nodes[num]);
> + sysfs_nodes[num].sysdev.id = -1;
> +}
> +#endif
I don't have a real problem with you cluttering up ia64 code, but if
these are useful, why don't we put them in generic code? They seem
quite arch-independent to me.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-03-17 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 8:23 Yasunori Goto
2006-03-17 18:00 ` Dave Hansen [this message]
2006-03-20 9:57 ` Yasunori Goto
2006-03-20 16:39 ` Dave Hansen
2006-03-21 4:11 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1142618434.10906.99.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox