From: Dave Hansen <haveblue@us.ibm.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>, "Luck, Tony" <tony.luck@intel.com>,
Andi Kleen <ak@suse.de>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH: 011/017]Memory hotplug for new nodes v.4.(start kswapd)
Date: Fri, 17 Mar 2006 09:55:47 -0800 [thread overview]
Message-ID: <1142618147.10906.93.camel@localhost.localdomain> (raw)
In-Reply-To: <20060317163538.C64D.Y-GOTO@jp.fujitsu.com>
On Fri, 2006-03-17 at 17:22 +0900, Yasunori Goto wrote
> +#ifdef CONFIG_MEMORY_HOTPLUG
> +/* start new kswapd for new node */
> +extern int kswapd_run(int nid);
> +#endif
I'd move this code down to where you actually use the extern. I'd also
take the #ifdef out. It won't hurt anything to have the extern there
all the time.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2006-03-17 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 8:22 Yasunori Goto
2006-03-17 17:55 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1142618147.10906.93.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox