From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1CF0CD4F5F for ; Fri, 22 Sep 2023 11:38:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3EA586B02BE; Fri, 22 Sep 2023 07:38:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 373726B02BF; Fri, 22 Sep 2023 07:38:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 214446B02C0; Fri, 22 Sep 2023 07:38:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0EB966B02BE for ; Fri, 22 Sep 2023 07:38:58 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D7D8EA0A49 for ; Fri, 22 Sep 2023 11:38:57 +0000 (UTC) X-FDA: 81264036714.24.8165603 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 1456CA0035 for ; Fri, 22 Sep 2023 11:38:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dr+UW6BG; spf=pass (imf15.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695382736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vqnEy0wH1bRBI/JHqHM2nHKGqTGkN0LbDHJj9EUZRuk=; b=MAI8YdPmnio3WyBqrbo4dmnlp9ueiKJcPRTW2uN/jmVB+2wLYGh8Cg7xsQ6/rO9pCde4OQ mRshJshY9mttT763XR/SmLA+GHrFX5Fs1oZrb/dO/vmQRPMbQqVfm+iH77/NubCKKskx8B qA/uPY3GyffWuLvm3PgprzNuBhml/nw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695382736; a=rsa-sha256; cv=none; b=t1YwF0ypnHcBMO+rjwJByvgARpWDlcTz8dlXWaTxsnax2rRHr/CAy+3czidgNuIQDM5Roa +CS2WNXL4qu3O61yF/yJCtAYH1NgL9nQhZEu0pZxdh+QIYNy8OwQbjZ/5ldQp9CaT7byIQ mlrKq4W2slle5vmZMFpM8kr1ULFZxRg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dr+UW6BG; spf=pass (imf15.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695382735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vqnEy0wH1bRBI/JHqHM2nHKGqTGkN0LbDHJj9EUZRuk=; b=dr+UW6BGF3dmh9fG9k75NlXjHEh8PSSq8g+z9/lH5SEsEszcOEJbWrj+pUM8af5CRgNiTe ppDBSmnLEMzllFOh/4lKOiHp6p5NtiqysBWglQacwgfK5NCkQnbL4GYxFvn0zrFcK/BaYI xUhaEYzCCnUGsAanDE/6/Q8v3czKbpg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-360-HVMKZAOLOw-KxFRtFcPAbA-1; Fri, 22 Sep 2023 07:38:49 -0400 X-MC-Unique: HVMKZAOLOw-KxFRtFcPAbA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 51A108032F6; Fri, 22 Sep 2023 11:38:48 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4DB871128A; Fri, 22 Sep 2023 11:38:46 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230922093227.GV224399@kernel.org> References: <20230922093227.GV224399@kernel.org> <20230920222231.686275-1-dhowells@redhat.com> <20230920222231.686275-6-dhowells@redhat.com> To: Simon Horman Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Linus Torvalds , Christoph Hellwig , Christian Brauner , David Laight , Matthew Wilcox , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 05/11] iov_iter: Convert iterate*() to inline funcs MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1142468.1695382726.1@warthog.procyon.org.uk> Date: Fri, 22 Sep 2023 12:38:46 +0100 Message-ID: <1142470.1695382726@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Stat-Signature: w8tqs7xjjxffs97afqr8ntakzt7xbifs X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1456CA0035 X-Rspam-User: X-HE-Tag: 1695382735-249816 X-HE-Meta: U2FsdGVkX1/dUah+BvfYgzqoytzhNdWp8bUvTT4YkEa+veg5/8D/4NhBjjdpEOTSDuK6ZMIh0zBg1LLUKg81JNMLSn3RlsMX9DP236eDfhjySuyQHoTAyjVQXPW5Y1tQKV+/qYnSKaGUgjAtHybD2OrfPL3IKW3FaijQ4HfFiA1vLGgydmiEugdQr+v/pGEpsHWpxIKlUecVgz1RPBghpfrmRTRl6WuDI58L1ujsaSO0mtd1eT8arp9vPMu9gTbClBX2s5xrsIY3wCL6/Ier/JZTHEU+jL34SSFZpc+YCYa3/1fcELAUDKt/TlVIdi3bUCYx9lJSHZSHzDuCVWZBYTeqGkps4qgcPnWHODJt5QMyO8AJXYaft5zsbvN3M0ADMLNK/Jatk+eSeNKKwHIf1TrEL7GAr6YOK0MEBXzxnKVG+LgmS/7VZjSCFrcuCXYqBlSpJ1PZ2HLbOnp4BeUN+/BDAXngiNrLJopPPLXw9xP0cC7RuAQwz6lwORnYo9FGdD150fPkfwDigJUy6hMJ3KbyQBDCmuvzE4eFfzl6IuTfAXge9ZdGrszFK4lXEytGmu+gw95Iu56tkXFtN0gkDj2zp25LGwcxXkejMPzJwD8x76OTfHRFLdflM0xgNkJ31rtlb+UujW/TNg8EBQD18eSCtTaPWzCPwdapdOJ/aPsmyN9KnN++Ce7wBI2PDegBqkNws6QVhpDdY4Cj9N/oMNqHLXtXuXMg0R4M4Cn4IhVV8JnLyEj3b8W1FTGaKwIJALOdcOUnnXVdbbeiT047iLrcvCvb8WFoaOOLxDc068zHSt69FB6hL+kwzfR08NxxBy6oYbCmtUtwGmmz6fFfSboBp9kb4ddIcBZwzzxcLXhTXR5fMVMIjRJ10gCn4YIUTiCeNc8955U8iAbFrAXLUd62Bs4giG+6ur6gfuPydro7EaBv0Bs4oSCNcsBhUnJE9uqHRxAraA5+vtBXkHI C2mjOS8q +7B1mjsySd+AxSbY0xHsDBNKjnjiDo9ZALlFWW7bwHGsHb18BaUb0hGOw0SnSn54f36S/KP88nXjqjLv0liaA69yagn3/MgN/ziH54VspKsfoULVIUNQi1rDoolfIbjrvK0lej5bSkc02OWlaXMJ+1meqDkKPm1UjDlOKyzmdYxNZiR04XT9r9Q/uBJaDFnPpN5GaLk3CeiuYy5ve1FaluX3pguygwWPbWd7p+i3Bd9THEB29bC5x8Nrp6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Simon Horman wrote: > Sparse complains a bit about the line above, perhaps the '(__force void *)' > should be retained from the old code? I've added a patch to add the missing __user to the x86 copy_mc_to_user(). The powerpc one already has it. David