From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E35DAC30653 for ; Mon, 1 Jul 2024 09:23:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6214C6B00B3; Mon, 1 Jul 2024 05:23:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D0CF6B00B4; Mon, 1 Jul 2024 05:23:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 498716B00B5; Mon, 1 Jul 2024 05:23:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2B6726B00B3 for ; Mon, 1 Jul 2024 05:23:53 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7528241A79 for ; Mon, 1 Jul 2024 09:23:52 +0000 (UTC) X-FDA: 82290646704.29.B58B1DC Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf08.hostedemail.com (Postfix) with ESMTP id 4493B16000F for ; Mon, 1 Jul 2024 09:23:48 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of zhaomengmeng@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=zhaomengmeng@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719825802; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z4px4spfm6Wh5gEcHUzDtmXM+WL+7mH8MX2nH+C0EPw=; b=pdBFg2pyjKyByFx7Y6kqHY89sKIONKAZQmqgltBGCwYVP1vj+Ijh6sSyE9FNGSU36zG5Ah pz/Q5E6iE+7KeBGz0bl5g0cUaWNq8OfHPR6zwsA5AS6HEnCtoCQ7T8q8ZDoRT6ZDFg9y0A XhxTzQZLfZsFne/X16Ii7dwmlmj8Hss= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of zhaomengmeng@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=zhaomengmeng@kylinos.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719825802; a=rsa-sha256; cv=none; b=N57V0+CrJ0WzW0gtNlizi33SUwvGQi+1ckSMwFTg0Dq9PizxdPJwWw5Myb+0rwDmYKIYcY qSbvfyQBTG6q6+KMtgtDyeyhnfsj9/VcRPpH2flXjteZl++Kn1Uy+5Z4alyexaurlhkzLC J75MHGb9P7boaa2MsK9FBejfQaidICw= X-UUID: 9b78bbf4378b11ef93f4611109254879-20240701 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.38,REQID:13c0e2da-aab1-4f07-b9bf-c24fa7a263a1,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-INFO: VERSION:1.1.38,REQID:13c0e2da-aab1-4f07-b9bf-c24fa7a263a1,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION:r elease,TS:-5 X-CID-META: VersionHash:82c5f88,CLOUDID:be0518f9baa1d9b65e9bfc58a855e5b2,BulkI D:240701151641C3XG98L4,BulkQuantity:1,Recheck:0,SF:64|66|38|17|19|102,TC:n il,Content:0,EDM:-3,IP:nil,URL:1,File:nil,RT:nil,Bulk:40,QS:nil,BEC:nil,CO L:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_ULS X-UUID: 9b78bbf4378b11ef93f4611109254879-20240701 X-User: zhaomengmeng@kylinos.cn Received: from [172.29.156.86] [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_128_GCM_SHA256 128/128) with ESMTP id 1003373823; Mon, 01 Jul 2024 17:23:42 +0800 Message-ID: <1141ee04-1466-d1c5-e2b7-8512e9f8f78c@kylinos.cn> Date: Mon, 1 Jul 2024 17:23:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v1] mm: gup: add forward declaration for try_grab_folio_fast To: David Hildenbrand , akpm@linux-foundation.org, yang@os.amperecomputing.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240701034052.9988-1-zhaomengmeng@kylinos.cn> <5b9dafac-1561-4dfa-a0ff-9445cddc0932@redhat.com> Content-Language: en-US From: Zhao Mengmeng In-Reply-To: <5b9dafac-1561-4dfa-a0ff-9445cddc0932@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4493B16000F X-Stat-Signature: 37qbsofn8wpari8yai44ncwkxzcsga4c X-Rspam-User: X-HE-Tag: 1719825828-932316 X-HE-Meta: U2FsdGVkX18LvN8LrPDhjjvtQmIibR4YDwAh0Ytii/5/biU8aWzUqKMzm6UPSnnoNwM+ugPjxppYGLEEv8u3RGZWIdiyUdQlR62W+hVaCn2QCuGNQgOYMyF50/LDjOkRX5mfJ7/Bf3HRai/g41fvEwJZv4cSro1cvy903uI9GdrFRAidapKwuyYZNi4euOMug6RpChOezqeiZJobFQZh2D/m/Lj1x6VDVo4pZ2ObQmXVJ0klSe6KGSO/pqX5VUJFYwklWBHPmbHWMBTtnDsXF5f5wPJ5nMwZ9dZaPh8ytXSuxQ8Ymdy0zDIoEG8amHgDRgPkA6ondgDg+rj5WewrM/P0rEy4VswYrnJ+iwHS7nHCL/rbBQ9EL8LtwfgTzrxxMQPxaRdzKDM22PPEbyOdTur1eXamS9LppisSw4aFNWEWwuQxMThl31kZb0OnE0v1MiYf9VykAVRLdSd+cxxeh4AbjUQBkhSPUyCuXyYCzsQ81sSkRcfx4MQ1myhW3jdx8t/mTEh97mIgA0duw8olGM8m93kXEsfj6J9CfQUiqy2ZEf4sMPF8MXheGktYhK5CRcynXpzmWRhVuDy+UzhviS5zzS9ypqjkLJ2dWyEly8dNhX5FPp+X5LAX6DqpxG3d2qSDOlwpFt7Z58173Ote4bFrYJ+9OWPwQIeu7f6gWXvHAUvnubU4H9LsNIKR/yB9Ar9jRGzbZHKp2ouvGvInX3s8n9WeqRi9cX4KNCioOLi1whbzYnmyH1V8pqH3jaxJ37+Gu8zPvWetJ0QhEvfinRHrHfrcxr9HNW+enSDkbFddiB63GaOMidHB9ZD1PEnqYB+fE5DLu99lSQW92/pn/aWf3eFsXgkwY5vN0KTxVcJ2CZHqg2RdGzsB1mcrx3BfWL4a5S8je8bxJtQIq466VhR1iyoT9QSY5TB/0OwaqG4zeRUKJCC4uWV4anwFLpeupR6K+EOnPXYq8W5bqAf UNsiZ/jm dAhsz0Y4UsWlhwZZsP8snYOn19VtUrosCI4qylPLnAsJ1hGbgHtJouIadSMO+bK90iA+iM5lvn1+xwwhIGRJKNfl1Iive2BLi1JIIOBuyoeWulTLwS3mL7sqNGsW40LreZN3pRBQ0KAJQH0QbVLyt5VjDbVBydZu/Bya/85zOiGAdDz/ANHJhMHgLRCQvoYiEJvYmcv2+ub3z8zUpR+k4BnU25Tzj9q4vz3YI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/1 15:16, David Hildenbrand wrote: > On 01.07.24 05:40, Zhao Mengmeng wrote: >> try_grab_folio_fast() was used in gup_hugepte(), while itself was >> defined after gup_hugepte(), so add a forward declaration to eliminate >> the -Wimplicit-function-declaration warning. >> >> Reported-by: kernel test robot >> Closes: >> https://lore.kernel.org/oe-kbuild-all/202407010039.D3sIu3fu-lkp@intel.com/ >> Signed-off-by: Zhao Mengmeng >> --- >>   mm/gup.c | 3 +++ >>   1 file changed, 3 insertions(+) >> >> diff --git a/mm/gup.c b/mm/gup.c >> index 7439359d0b71..222b83a87d7d 100644 >> --- a/mm/gup.c >> +++ b/mm/gup.c >> @@ -488,6 +488,9 @@ static unsigned long hugepte_addr_end(unsigned >> long addr, unsigned long end, >>       return (__boundary - 1 < end - 1) ? __boundary : end; >>   } >>   +static struct folio *try_grab_folio_fast(struct page *page, int refs, >> +                     unsigned int flags); >> + > > This function should really be called "gup_fast_", just like all other > gup_fast_ specific functions. I might send some follow-up cleanups later. > Yeah, looking forward to your patch. Besides, I have seen Yang's fix in https://lore.kernel.org/linux-mm/CAHbLzkowMSso-4Nufc9hcMehQsK9PNz3OSu-+eniU-2Mm-xjhA@mail.gmail.com/T/#m7ff03bf88814d8352052fbd8a1c90fee0ba5b576 and it is better. So sorry to bother you all.