From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH 00/03] Unmapped: Separate unmapped and mapped pages From: Arjan van de Ven In-Reply-To: References: <20060310034412.8340.90939.sendpatchset@cherry.local> <1141977139.2876.15.camel@laptopd505.fenrus.org> Content-Type: text/plain Date: Fri, 10 Mar 2006 15:05:06 +0100 Message-Id: <1141999506.2876.45.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Magnus Damm Cc: Magnus Damm , Linux Kernel , linux-mm@kvack.org List-ID: On Fri, 2006-03-10 at 14:19 +0100, Magnus Damm wrote: > On 3/10/06, Arjan van de Ven wrote: > > > Apply on top of 2.6.16-rc5. > > > > > > Comments? > > > > > > my big worry with a split LRU is: how do you keep fairness and balance > > between those LRUs? This is one of the things that made the 2.4 VM suck > > really badly, so I really wouldn't want this bad... > > Yeah, I agree this is important. I think linux-2.4 tried to keep the > LRU list lengths in a certain way (maybe 2/3 of all pages active, 1/3 > inactive). not really > My current code just extends this idea which basically means that > there is currently no relation between how many pages that sit in each > LRU. The LRU with the largest amount of pages will be shrunk/rotated > first. And on top of that is the guarantee logic and the > reclaim_mapped threshold, ie the unmapped LRU will be shrunk first by > default. that sounds wrong, you lose history this way. There is NO reason to shrink only the unmapped LRU and not the mapped one. At minimum you always need to pressure both. How you pressure (absolute versus percentage) is an interesting question, but to me there is no doubt that you always need to pressure both, and "equally" to some measure of equal -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org