From: Liu Shixin <liushixin2@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Liu Zixian <liuzixian4@huawei.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Muchun Song <songmuchun@bytedance.com>,
"Sidhartha Kumar" <sidhartha.kumar@oracle.com>,
John Hubbard <jhubbard@nvidia.com>,
"David Hildenbrand" <david@redhat.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] mm: hugetlb: fix UAF in hugetlb_handle_userfault
Date: Sat, 24 Sep 2022 11:34:39 +0800 [thread overview]
Message-ID: <11391501-c901-fd4d-5a05-50952aec011c@huawei.com> (raw)
In-Reply-To: <20220923170554.7046bb023f8cf582b5909b77@linux-foundation.org>
On 2022/9/24 8:05, Andrew Morton wrote:
> On Fri, 23 Sep 2022 12:21:13 +0800 Liu Shixin <liushixin2@huawei.com> wrote:
>
>> The vma_lock and hugetlb_fault_mutex are dropped before handling
>> userfault and reacquire them again after handle_userfault(), but
>> reacquire the vma_lock could lead to UAF[1,2] due to the following
>> race,
...
> Patch is against mm-unstable, which isn't appropriate for a backport.
> Could you please something against current -linus (which will be more
> backportable), then I'll figure out the fallout on mm-unstable.
>
> Thanks.
> .
I resend v4 rebased on current -linus.
Link: https://lore.kernel.org/all/20220924034905.2694686-1-liushixin2@huawei.com/
Thanks,
prev parent reply other threads:[~2022-09-24 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 4:21 Liu Shixin
2022-09-24 0:05 ` Andrew Morton
2022-09-24 3:34 ` Liu Shixin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11391501-c901-fd4d-5a05-50952aec011c@huawei.com \
--to=liushixin2@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuzixian4@huawei.com \
--cc=mike.kravetz@oracle.com \
--cc=sidhartha.kumar@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox