From: Dave Hansen <haveblue@us.ibm.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: akpm@osdl.org, Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH] Compile error on x86 with hotplug but no highmem
Date: Fri, 27 Jan 2006 12:02:28 -0800 [thread overview]
Message-ID: <1138392149.19801.53.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.58.0601271014090.25836@skynet>
On Fri, 2006-01-27 at 10:17 +0000, Mel Gorman wrote:
> Memory hotplug without highmem is meaningless but it is still an allowed
> configuration. This is one possible fix. Another is to not allow memory
> hotplug without high memory being available. Another is to take
> online_page() outside of the #ifdef CONFIG_HIGHMEM block in init.c .
If it is meaningless, then we should probably fix it in the Kconfig
file, not just work around it at runtime.
What we really want is something to tell us that the architecture
_supports_ highmem and isn't using it. Maybe something like this?
in mm/Kconfig:
config MEMORY_HOTPLUG
depends on ... && !ARCH_HAS_DISABLED_HIGHMEM
in arch/i386/Kconfig:
config ARCH_HAS_DISABLED_HIGHMEM
def_bool n
depends on !HIGHMEM
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-01-27 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 10:17 Mel Gorman
2006-01-27 20:02 ` Dave Hansen [this message]
2006-01-29 15:59 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1138392149.19801.53.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox