From: Adam Litke <agl@us.ibm.com>
To: akpm@osdl.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Gibson <david@gibson.dropbear.id.au>,
wli@holomorphy.com, hugh@veritas.com, rohit.seth@intel.com,
kenneth.w.chen@intel.com, "ADAM G. LITKE [imap]" <agl@us.ibm.com>
Subject: [PATCH 1/4] Hugetlb: Remove duplicate i_size check
Date: Wed, 09 Nov 2005 17:36:49 -0600 [thread overview]
Message-ID: <1131579410.28383.19.camel@localhost.localdomain> (raw)
In-Reply-To: <1131578925.28383.9.camel@localhost.localdomain>
On Wed, 2005-10-26 at 12:00 +1000, David Gibson wrote:
> - The check against i_size was duplicated: once in
> find_lock_huge_page() and again in hugetlb_fault() after taking the
> page_table_lock. We only really need the locked one, so remove the
> other.
Original post by David Gibson <david@gibson.dropbear.id.au>
Version 2: Wed 9 Nov 2005
Split this cleanup out into a standalone patch
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Adam Litke <agl@us.ibm.com>
---
hugetlb.c | 7 -------
1 files changed, 7 deletions(-)
diff -upN reference/mm/hugetlb.c current/mm/hugetlb.c
--- reference/mm/hugetlb.c
+++ current/mm/hugetlb.c
@@ -344,19 +344,12 @@ static struct page *find_lock_huge_page(
{
struct page *page;
int err;
- struct inode *inode = mapping->host;
- unsigned long size;
retry:
page = find_lock_page(mapping, idx);
if (page)
goto out;
- /* Check to make sure the mapping hasn't been truncated */
- size = i_size_read(inode) >> HPAGE_SHIFT;
- if (idx >= size)
- goto out;
-
if (hugetlb_get_quota(mapping))
goto out;
page = alloc_huge_page();
--
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-11-09 23:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-09 23:28 [PATCH 0/4] hugetlb: copy on write Adam Litke
2005-11-09 23:36 ` Adam Litke [this message]
2005-11-10 0:10 ` [PATCH 1/4] Hugetlb: Remove duplicate i_size check William Lee Irwin III
2005-11-09 23:37 ` [PATCH 2/4] Hugetlb: Rename find_lock_page to find_or_alloc_huge_page Adam Litke
2005-11-10 0:11 ` William Lee Irwin III
2005-11-09 23:38 ` [PATCH 3/4] Hugetlb: Reorganize hugetlb_fault to prepare for COW Adam Litke
2005-11-10 0:13 ` William Lee Irwin III
2005-11-09 23:39 ` [PATCH 4/4] Hugetlb: Copy on Write support Adam Litke
2005-11-10 0:15 ` William Lee Irwin III
2005-11-10 0:49 ` David Gibson
2005-11-10 0:56 ` William Lee Irwin III
2005-11-10 1:52 ` Rohit Seth
2005-11-10 3:54 ` David Gibson
2005-11-10 4:20 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131579410.28383.19.camel@localhost.localdomain \
--to=agl@us.ibm.com \
--cc=akpm@osdl.org \
--cc=david@gibson.dropbear.id.au \
--cc=hugh@veritas.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rohit.seth@intel.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox