From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e32.co.us.ibm.com (8.12.11/8.12.11) with ESMTP id j95HLCPx017422 for ; Wed, 5 Oct 2005 13:21:12 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id j95HM9fK542942 for ; Wed, 5 Oct 2005 11:22:09 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j95HM8aZ029388 for ; Wed, 5 Oct 2005 11:22:08 -0600 Subject: Re: [PATCH 3/7] Fragmentation Avoidance V16: 003_fragcore From: Dave Hansen In-Reply-To: References: <20051005144546.11796.1154.sendpatchset@skynet.csn.ul.ie> <20051005144602.11796.53850.sendpatchset@skynet.csn.ul.ie> <1128530908.26009.28.camel@localhost> Content-Type: text/plain Date: Wed, 05 Oct 2005 10:22:00 -0700 Message-Id: <1128532920.26009.43.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Mel Gorman Cc: linux-mm , Andrew Morton , kravetz@us.ibm.com, Linux Kernel Mailing List , jschopp@austin.ibm.com, lhms List-ID: On Wed, 2005-10-05 at 18:14 +0100, Mel Gorman wrote: > On Wed, 5 Oct 2005, Dave Hansen wrote: > > On Wed, 2005-10-05 at 15:46 +0100, Mel Gorman wrote: > > > > > > @@ -1483,8 +1540,10 @@ void show_free_areas(void) > > > > > > spin_lock_irqsave(&zone->lock, flags); > > > for (order = 0; order < MAX_ORDER; order++) { > > > - nr = zone->free_area[order].nr_free; > > > - total += nr << order; > > > + for (type=0; type < RCLM_TYPES; type++) { > > > + nr = zone->free_area_lists[type][order].nr_free; > > > + total += nr << order; > > > + } > > > > Can that use the new for_each_ macro? > > Now I remember why, it's because of the printf below "for (type=0" . The > printf has to happen once for each order. With the for_each_macro, it > would happen for each type *and* order. Actually, that's for debugging, so we might want to do that anyway. Can you put it in a separate patch and explain? -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org