From: Dave Hansen <haveblue@us.ibm.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-mm <linux-mm@kvack.org>, Andrew Morton <akpm@osdl.org>,
kravetz@us.ibm.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
jschopp@austin.ibm.com, lhms <lhms-devel@lists.sourceforge.net>
Subject: Re: [PATCH 5/7] Fragmentation Avoidance V16: 005_fallback
Date: Wed, 05 Oct 2005 09:53:55 -0700 [thread overview]
Message-ID: <1128531235.26009.35.camel@localhost> (raw)
In-Reply-To: <20051005144612.11796.35309.sendpatchset@skynet.csn.ul.ie>
On Wed, 2005-10-05 at 15:46 +0100, Mel Gorman wrote:
> +static struct page *
> +fallback_alloc(int alloctype, struct zone *zone, unsigned int order)
> {
...
> + /*
> + * Here, the alloc type lists has been depleted as well as the global
> + * pool, so fallback. When falling back, the largest possible block
> + * will be taken to keep the fallbacks clustered if possible
> + */
> + while ((alloctype = *(++fallback_list)) != -1) {
That's a bit obtuse. Is there no way to simplify it? Just keeping an
index instead of a fallback_list pointer should make it quite a bit
easier to grok.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-10-05 16:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-05 14:45 [PATCH 0/7] Fragmentation Avoidance V16 Mel Gorman
2005-10-05 14:45 ` [PATCH 1/7] Fragmentation Avoidance V16: 001_antidefrag_flags Mel Gorman
2005-10-06 15:11 ` Paul Jackson
2005-10-06 15:15 ` Mel Gorman
2005-10-05 14:45 ` [PATCH 2/7] Fragmentation Avoidance V16: 002_usemap Mel Gorman
2005-10-05 23:38 ` David S. Miller, Mel Gorman
2005-10-06 15:12 ` Mel Gorman
2005-10-05 14:46 ` [PATCH 3/7] Fragmentation Avoidance V16: 003_fragcore Mel Gorman
2005-10-05 16:48 ` Dave Hansen
2005-10-05 16:57 ` Mel Gorman
2005-10-05 17:14 ` Mel Gorman
2005-10-05 17:22 ` Dave Hansen
2005-10-05 17:45 ` Mel Gorman
2005-10-05 17:51 ` Dave Hansen
2005-10-05 14:46 ` [PATCH 4/7] Fragmentation Avoidance V16: 004_largealloc_tryharder Mel Gorman
2005-10-05 14:46 ` [PATCH 5/7] Fragmentation Avoidance V16: 005_fallback Mel Gorman
2005-10-05 16:49 ` Dave Hansen
2005-10-05 17:11 ` Mel Gorman
2005-10-05 16:51 ` Dave Hansen
2005-10-05 17:16 ` Mel Gorman
2005-10-05 17:20 ` Dave Hansen
2005-10-05 17:32 ` Mel Gorman
2005-10-05 16:53 ` Dave Hansen [this message]
2005-10-05 17:20 ` Mel Gorman
2005-10-05 17:25 ` Dave Hansen
2005-10-05 14:46 ` [PATCH 6/7] Fragmentation Avoidance V16: 006_percpu Mel Gorman
2005-10-05 14:46 ` [PATCH 7/7] Fragmentation Avoidance V16: 007_stats Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1128531235.26009.35.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=jschopp@austin.ibm.com \
--cc=kravetz@us.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox