From: Dave Hansen <haveblue@us.ibm.com>
To: Magnus Damm <magnus@valinux.co.jp>
Cc: linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] i386: srat and numaq cleanup
Date: Wed, 05 Oct 2005 09:37:42 -0700 [thread overview]
Message-ID: <1128530262.26009.27.camel@localhost> (raw)
In-Reply-To: <20051005083846.4308.37575.sendpatchset@cherry.local>
On Wed, 2005-10-05 at 17:39 +0900, Magnus Damm wrote:
> Cleanup the i386 NUMA code by creating inline no-op functions for
> get_memcfg_numaq/srat() and get_zholes_size_numaq/srat().
> arch/i386/kernel/srat.c | 10 ++++++++--
> include/asm-i386/mmzone.h | 26 +++++++++++++++++---------
> include/asm-i386/numaq.h | 10 ++++++++--
> include/asm-i386/srat.h | 15 ++++++++++-----
> 4 files changed, 43 insertions(+), 18 deletions(-)
I'm highly suspicious of any "cleanup" that adds more code than it
deletes. What does this clean up?
This patch is a little bit confused. It makes the
get_zholes_size_srat() always safe to call at runtime. However, it
still creates a compile-time stub version of it as well.
In addition, you already have the srat.c-local zholes_size_init, but you
still add the has_srat variable. Seems a bit superfluous.
Calling get_zholes_size_numaq() at runtime is unnecessary. The NUMA-Q
is not supported with the ARCH_GENERIC code.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-10-05 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-05 8:39 Magnus Damm
2005-10-05 16:37 ` Dave Hansen [this message]
2005-10-06 10:29 ` Magnus Damm
2005-10-06 14:56 ` Dave Hansen
2005-10-07 7:54 ` Magnus Damm
2005-10-07 13:28 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1128530262.26009.27.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=linux-mm@kvack.org \
--cc=magnus@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox