From: Dave Hansen <haveblue@us.ibm.com>
To: Magnus Damm <magnus@valinux.co.jp>
Cc: linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] i386: nid_zone_sizes_init() update
Date: Wed, 05 Oct 2005 09:12:54 -0700 [thread overview]
Message-ID: <1128528774.26009.12.camel@localhost> (raw)
In-Reply-To: <20051005083515.4305.16399.sendpatchset@cherry.local>
On Wed, 2005-10-05 at 17:35 +0900, Magnus Damm wrote:
> Broken out nid_zone_sizes_init() change from i386 NUMA emulation code.
...
> -static inline unsigned long nid_size_pages(int nid)
> -{
> - return node_end_pfn[nid] - node_start_pfn[nid];
> -}
> -static inline int nid_starts_in_highmem(int nid)
> -{
> - return node_start_pfn[nid] >= max_low_pfn;
> -}
Hey, I liked those helpers!
When I suggested that you make your patches apply on top of the existing
-mhp stuff, I didn't just mean that they should _apply_, they should
probably mesh a little bit better. For instance, it would be very
helpful to use those 'static inlines', or make a couple new ones if you
need them.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-10-05 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-05 8:35 Magnus Damm
2005-10-05 15:10 ` Martin J. Bligh
2005-10-05 16:25 ` Dave Hansen
2005-10-05 16:12 ` Dave Hansen [this message]
2005-10-06 10:38 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1128528774.26009.12.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=linux-mm@kvack.org \
--cc=magnus@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox