From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.12.11/8.12.11) with ESMTP id j93GGiSK014260 for ; Mon, 3 Oct 2005 12:16:44 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay04.pok.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id j93GGim6040736 for ; Mon, 3 Oct 2005 12:16:44 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11/8.13.3) with ESMTP id j93GGhrl030681 for ; Mon, 3 Oct 2005 12:16:44 -0400 Subject: Re: [PATCH 07/07] i386: numa emulation on pc From: Dave Hansen In-Reply-To: References: <20050930073232.10631.63786.sendpatchset@cherry.local> <20050930073308.10631.24247.sendpatchset@cherry.local> <1128106512.8123.26.camel@localhost> Content-Type: text/plain Date: Mon, 03 Oct 2005 09:16:32 -0700 Message-Id: <1128356192.10290.10.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Magnus Damm Cc: Magnus Damm , Isaku Yamahata , linux-mm , Linux Kernel Mailing List List-ID: On Mon, 2005-10-03 at 18:59 +0900, Magnus Damm wrote: > > > +#ifdef CONFIG_NUMA_EMU > > > + bootmap_size = init_bootmem(max(min_low_pfn, node_start_pfn[0]), > > > + min(max_low_pfn, node_end_pfn[0])); > > > +#else > > > bootmap_size = init_bootmem(min_low_pfn, max_low_pfn); > > > +#endif > > > > This shouldn't be necessary. Again, take a look at my discontig > > separation patches and see if what I did works for you here. > > Do you mean "discontig-consolidate0.patch"? Maybe I'm misunderstanding. This one, I believe: http://sr71.net/patches/2.6.14/2.6.14-rc2-git8-mhp1/broken-out/B2.1-i386-discontig-consolidation.patch > > > +#ifdef CONFIG_NUMA_EMU > > ... > > > +#endif > > > > Ewwwwww :) No real need to put new function in a big #ifdef like that. > > Can you just create a new file for NUMA emulation? > > Hehe, what is this, a beauty contest? =) I agree, but I guess the > reason for this code to be here is that a similar arrangement is done > by x86_64... If that's really the case, can they _actually_ share code? Maybe we can do this NUMA emulation thing in non-arch code. Just guessing... > I will create a new file. Is arch/i386/mm/numa_emu.c good? > But first, you have written lots and lots of patches, and I am > confused. Could you please tell me on which patches I should base my > code to make things as easy as possible? This is the staging ground for my memory hotplug work. But, it contains all of my work on other stuff, too. If you build on top of this, it would be great: http://sr71.net/patches/2.6.14/2.6.14-rc2-git8-mhp1/ -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org