From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08545C433FE for ; Tue, 19 Apr 2022 12:53:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 477418D0070; Tue, 19 Apr 2022 08:53:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 402458D0047; Tue, 19 Apr 2022 08:53:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2796D8D0070; Tue, 19 Apr 2022 08:53:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id E54BA8D0047 for ; Tue, 19 Apr 2022 08:53:21 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id B0006821C8 for ; Tue, 19 Apr 2022 12:53:21 +0000 (UTC) X-FDA: 79373619402.09.20395B8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 3F820A000E for ; Tue, 19 Apr 2022 12:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650372800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yFWX1fe131b/DTH6pn8hO6mxcNJSXq3lBnVZqFiI2qw=; b=YnZKggPWjZBNdfHy57B+fGQWdmBvZyOQG4UzCOMFXPT6rQa0iUiUCQflMxE3e1z89JwBV2 A09TwQgKShHmB4F1bxc6xrm/IuZGbwRC0dSqHzbI/V5Z6iWU3abyc3G/Ki+qs4z7CG0euH VQ6AxI7j6z7qtML+LG0G7M6Gk9dzsRA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-623-X0topJXLO9-gIYGZb8QKOA-1; Tue, 19 Apr 2022 08:53:19 -0400 X-MC-Unique: X0topJXLO9-gIYGZb8QKOA-1 Received: by mail-wr1-f71.google.com with SMTP id v9-20020adfc409000000b002079e379921so1894956wrf.5 for ; Tue, 19 Apr 2022 05:53:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=yFWX1fe131b/DTH6pn8hO6mxcNJSXq3lBnVZqFiI2qw=; b=2/xMcEMJtBjn7OC2PCQ/B6ExhSWKPRnkh4Z2cw6OTcpcT3nOPH0t2fqiiEe6N7QMDQ WQcm1ndmETMjKM/3y2819CRaB1IwnUh2yUUn4TiYEUr/MUfSerS7Z5sxO3dHQqKM1TTl NJEsL3ArpGVYg2nKGRgEuMSoo5K1QGvQXJYtT162N5T/sVDTcZlYGR+c95XsNDDyEAQy XmFrerRWws6rXI3c/3dZnDytNMoIMIvxJaKdnV0uOOtzNnh9qzWdLqpgr34MRbCCYGO6 7QZwFOlHOAbvY/R5J+02tG+QYavfamhAU+72U/qtv6juu/sTDjQ3P5mjsbuLdnOTQS4T hx7g== X-Gm-Message-State: AOAM531DNRfISRdFPZEknCIpNdtx+YNSj2eYOQwFk+nqFlgS/cjxz70V xH/t6y+HgvLvkCLJsYENZU+lwFaMFWacpiWL92muVdEbLFJniY9mm9NMSsXNooEYwPJYIUDc3or C012MHMOFHfQ= X-Received: by 2002:a5d:4d82:0:b0:207:a0da:8f06 with SMTP id b2-20020a5d4d82000000b00207a0da8f06mr11711670wru.680.1650372798511; Tue, 19 Apr 2022 05:53:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw11mtYc4J0pW+3pLYQQcVXLgtbfYePDpNhRkKvYgk9JRVRFqGoRNPh8QMia8rDNSqj2C3OeQ== X-Received: by 2002:a5d:4d82:0:b0:207:a0da:8f06 with SMTP id b2-20020a5d4d82000000b00207a0da8f06mr11711646wru.680.1650372798241; Tue, 19 Apr 2022 05:53:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:5d00:d8c2:fbf6:a608:957a? (p200300cbc7045d00d8c2fbf6a608957a.dip0.t-ipconnect.de. [2003:cb:c704:5d00:d8c2:fbf6:a608:957a]) by smtp.gmail.com with ESMTPSA id 3-20020a056000154300b0020a9dcac3c2sm4269185wry.20.2022.04.19.05.53.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 05:53:17 -0700 (PDT) Message-ID: <1126a1ae-8eff-8962-4253-d6e430ecc892@redhat.com> Date: Tue, 19 Apr 2022 14:53:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2] mm/mmzone: Introduce a new macro for_each_node_zonelist() To: Mike Rapoport , Donghyeok Kim Cc: Andrew Morton , Mike Kravetz , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Ohhoon Kwon , JaeSang Yoo , Wonhyuk Yang , Jiyoup Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220416132037.6395-1-dthex5d@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3F820A000E X-Stat-Signature: 8k8syjdp7un5yunqrqikujz45g9o4bhb Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YnZKggPW; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf15.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1650372800-203315 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.04.22 16:05, Mike Rapoport wrote: > On Sat, Apr 16, 2022 at 10:20:35PM +0900, Donghyeok Kim wrote: >> There are some codes using for_each_zone_zonelist() even when only >> iterating each node is needed. This commit introduces a new macro >> for_each_node_zonelist() which iterates through valid nodes in the >> zonelist. >> >> By using this new macro, code can be written in a much simpler form. >> Also, slab/slub can now skip trying to allocate from the node which was >> previously tried and failed. >> >> Co-developed-by: Ohhoon Kwon >> Signed-off-by: Ohhoon Kwon >> Signed-off-by: Donghyeok Kim >> --- >> V1 -> V2: Fix a compile error >> >> include/linux/mmzone.h | 36 ++++++++++++++++++++++++++++++++++++ >> mm/hugetlb.c | 17 +++++++---------- >> mm/mmzone.c | 17 +++++++++++++++++ >> mm/slab.c | 7 ++----- >> mm/slub.c | 8 ++++---- >> mm/vmscan.c | 16 ++++++---------- >> 6 files changed, 72 insertions(+), 29 deletions(-) > > Even counting the comments this does not look like a great simplification. > I tend to agree. -- Thanks, David / dhildenb