From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D7A6EB64DC for ; Fri, 30 Jun 2023 15:17:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE4C08E001A; Fri, 30 Jun 2023 11:17:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C956C8E000F; Fri, 30 Jun 2023 11:17:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B343D8E001A; Fri, 30 Jun 2023 11:17:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9E4468E000F for ; Fri, 30 Jun 2023 11:17:00 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 612D11C909C for ; Fri, 30 Jun 2023 15:17:00 +0000 (UTC) X-FDA: 80959767000.28.2C1A1B1 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf03.hostedemail.com (Postfix) with ESMTP id D766F20012 for ; Fri, 30 Jun 2023 15:16:56 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BvxMnsSk; spf=pass (imf03.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688138218; a=rsa-sha256; cv=none; b=UWPotzWuavP7SxXOHj+ozVPVAMdLsA4BER6DEYvtzHfYQX4nX9L9W+oOhna4eBdszUunqk g1K/kjsaxoo1y5Xz4+SAtOt++maSY2OcHmVdTvetNGuORwYr3MOWGtj4cXORVL4+4nfjsU LFIMDmxbFS5r1kGgDHVrbA9nHS1tu0s= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BvxMnsSk; spf=pass (imf03.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688138218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qtACn5MWvhYUL1jHwAWdyikD/LsMHvovbXAeD+ZqvDI=; b=S52lgyH3QTt3JC3pRD1jmQlEXCtqVzgZCjlO2O7QQ2Y1KHHIfEAd1D/DTjH1lLZMMuqgP7 bOBtyZKJhEnoxYo1LZuv9bb1FFQAZe7b3WvGXhg80I7pSdvgxPJx2QSQRCZglhDRjyAW+V f9Wr7hzFBkf4d3jgHOUmMpUAecz6ts0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688138217; x=1719674217; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=vNkj93/5Q0qPJqdsxO49mwhsALqQK4kXJEFlJaSNhnE=; b=BvxMnsSkKl2gwB9plePtOaEGEDoPLKcbvxitVIL52yFDjjm918vJ2x9Q cR30joop4aVk2DBlozEMeHt5ephdcpmcFJ4LhH8M8xuQKUAv8jVOR5F4+ bGDbypBIwCxID1IgwCW2iTiwK5dhQvhJECy2SUcY2aupbxeSik9fdrJ9F mUnudPNlJx2+gBRJdTjzVO3ivFXEehL7+azsqQ92FXLY6l0EcipE3PPSK P7fmHzDGsAU1hOpoxuIY7+eji7QcGfSJzMfWf0DJm58Ubu2DeG3y0Ockj QJoFdkLi2PTW1DvRVjSZ5cdYe5ysRpVjdaP+paPzprI1Eo6jnvcwcRAI8 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10757"; a="448793789" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="448793789" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2023 08:16:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10757"; a="747455463" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="747455463" Received: from amuruge1-mobl.amr.corp.intel.com (HELO [10.252.133.96]) ([10.252.133.96]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2023 08:16:51 -0700 Message-ID: <1121357f-93ad-9016-36be-8bc34c256b16@intel.com> Date: Fri, 30 Jun 2023 08:16:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v12 20/22] x86/virt/tdx: Allow SEAMCALL to handle #UD and #GP Content-Language: en-US To: "Huang, Kai" , "peterz@infradead.org" Cc: "kvm@vger.kernel.org" , "Raj, Ashok" , "Luck, Tony" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "mingo@redhat.com" , "tglx@linutronix.de" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "nik.borisov@suse.com" , "hpa@zytor.com" , "Shahar, Sagi" , "imammedo@redhat.com" , "bp@alien8.de" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" , "x86@kernel.org" References: <20230628152900.GI2438817@hirez.programming.kicks-ass.net> <20230628203823.GR38236@hirez.programming.kicks-ass.net> <42e13ccf7f27a68c0dd64640eed378c38ef40967.camel@intel.com> <20230630100659.GF2533791@hirez.programming.kicks-ass.net> <88de636ed40786f40c153b392070357f8b3d6948.camel@intel.com> From: Dave Hansen In-Reply-To: <88de636ed40786f40c153b392070357f8b3d6948.camel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D766F20012 X-Stat-Signature: depie6fyitfgtca5iyc8qkffn61sahjj X-Rspam-User: X-HE-Tag: 1688138216-99948 X-HE-Meta: U2FsdGVkX18V93BNGpZqN+sN0HnYW3zS2unICJ7tIHlIvnpoFhyi7sr4EH/kK5SNSCUdMJzCtoeZaWAMQlsCAkSj5vYA+OnolW7zXBopJ8fXm/dPwqMA34EbfzZPcG/ysBUknAP5RpUaVMgDotthbpjHSHCSO6WNNPlClBXaDZkMPRT/rFxDp2KI57JXlBzzufnDobLpiAkl5YgrDgJ5T3FfbFyNSj1N+9Gw4HOfSpsno2mbleVG7rFCnzmbXjE4yRvMb3895+EKR3qsuv5RrzywabmtWoJ1IRUF8+90DdyNGril/33fzX1SXXHtVuDztjcxAQ3p+guauBVWxLCVnBjmV+OFEIIL4f7WKDyW8rPYKd4ZOzwc31T3ZYUALIVD5ElfQsku4m6esucF3MxxuVnZmeJy+ZRTIkUqnc3moGpqAK+gX8aK1l+mrjaHV3JWm8cFPUCvWEoy75zc3BKrguNoB4Jy9OM+WWBUgmQw+fO6R0exLyjCu064m90p8eU0p6nFoeV2pY/nEoswmsvsbYoAeQF55tGXjWzhBECCuT/XshcmEwbr0ak2tqE21sREmf1RvTmemGOvUAvSRX5pEQg4Nl98yEZ70ePy1REz9oExC9P77daXd+D/N7EF62EGi9v2/TfcOTrdUqBr2Em9OA6KhP4VYDhNKUQgg4FNMV+xs2C97irOznm/37d4tpjo7xVqct3xUPKRLKglQgZ1u+XTBtr+KnM7Zb1BEUl6aork+1dUQ21pS76l7MC6lAItUQaIcwEeQOsTMyqbdFgrHBmOGtxp/6Zzc9Ckzyx2TjyJRMUN+xkMc71cHZeY6aaUqmqedGhlwPG9yses1O4yVuH9EpyrSMgXQHgPAmLoGkMl4Xf/WW7llI96zFZhIniGasPZqAMd0JddvhrHHR5TuJ42+5xSsO+60DXHfGLXKzXVrlLqAdrbxhqskpmKzBB6qoU7i5DrPIbWCsXrzy1 WdZCh1SS dN4jFm3VgbW2K4jRTo5Aeywf0iqLfJnNX8FSKF+4PK983D0VmGz3oj2mQWMuN9uLm1e9ncnuxYPaoQvAtNNacpUQ7WPMi9Uc3xs6giOTI5cJbFL2k3La/OefnlBMLob2bYmRnpHGeQetCc1iu4n22SRL+FRj7GvaP0pnQnXaEnbpmjVzVzmoEYC7VYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/30/23 03:18, Huang, Kai wrote: >> Please, because 12,14 are callee-saved, which means we need to go add >> push/pop to preserve them 🙁 > Yes. > > However those new SEAMCALLs are for TDX guest live migration support, which is > at a year(s)-later thing from upstreaming's point of view. My thinking is we > can defer supporting those new SEAMCALls until that phase. Yes we need to do > some assembly change at that time, but also looks fine to me. > > How does this sound? It would sound better if the TDX module folks would take that year to fix the module and make it nicer for Linux. :)