From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF7DECAAD3 for ; Thu, 1 Sep 2022 08:47:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B2F38D0001; Thu, 1 Sep 2022 04:47:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 163696B0073; Thu, 1 Sep 2022 04:47:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02A568D0001; Thu, 1 Sep 2022 04:47:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E68C16B0072 for ; Thu, 1 Sep 2022 04:47:14 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CD4FE120297 for ; Thu, 1 Sep 2022 08:47:14 +0000 (UTC) X-FDA: 79862887188.13.B88CCEF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf07.hostedemail.com (Postfix) with ESMTP id AD75740047 for ; Thu, 1 Sep 2022 08:47:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 54261223F6; Thu, 1 Sep 2022 08:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1662022032; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LGTcfsJkK1Xbb+ogV33V9MNZA3cpuGvzquse6jYX4Jo=; b=umIEJIdqwBDW4uEwTWN9CojVnAwOmwO9BJWm9AfZkKbBHAxu/Ge2LSrZo8iJLG7NscyeD2 LN2l1vdh2BgZGu1BtimhJGYQEz3q9Xk0wIOSPgUISDSWFJO3dakqgCo8qqvZA2vUiW0ZX0 09zB9+p54NwdcOrAzZldAxMroEWANzs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1662022032; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LGTcfsJkK1Xbb+ogV33V9MNZA3cpuGvzquse6jYX4Jo=; b=nuyJH10vtb01s2Rnjxf4mWDFWYX/5gzV1ejZBveVPxXgd3x/o4N6ZttgikHpq8PCz2aPZR YZtZ+/1REV7Zt4CA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3011D13A79; Thu, 1 Sep 2022 08:47:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QmOpCpBxEGP+OwAAMHmgww (envelope-from ); Thu, 01 Sep 2022 08:47:12 +0000 Message-ID: <111e54ab-67d7-2932-150d-3bfd46827b30@suse.cz> Date: Thu, 1 Sep 2022 10:47:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH -next] mm: kence: add __kmem_cache_free to function skip list To: Feng Tang Cc: Marco Elver , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrew Morton , Alexander Potapenko , Dmitry Vyukov , "kasan-dev@googlegroups.com" , "linux-mm@kvack.org" References: <20220831073051.3032-1-feng.tang@intel.com> <7edc9d38-da50-21c8-ea79-f003f386c29b@suse.cz> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662022034; a=rsa-sha256; cv=none; b=2pIkYRtWwUV7TZyp0Td92psM/5TxzMQvMsagjkI7GTanVCn2abIzSUXfUGfua4IkKWMT4G JgwPAWteBpVv4VFT2tDgtBYvKXOh0OYfm8FybA1Z9ecOEMemK2FFbt/F30eRTp8FwtQhgn qriyzi08llLIBX3VDkV5sO1F9iLlyg0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=umIEJIdq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=nuyJH10v; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662022034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LGTcfsJkK1Xbb+ogV33V9MNZA3cpuGvzquse6jYX4Jo=; b=ZyL9+t0V+F22t+nisoFL7RYCzivjkEOJh/8mg0vcxVklPFxZ42AimAqFJZrcXY3l5hb1b3 AEK94aZrtgm8RdntWsQPbOAR/ttlVlpWLRrnvEHtiM/qXt+u3eexWufzhq55LfW/kRYd6t kRoz4KTnjST9tbROFazpDXUujC5oWBY= X-Rspamd-Queue-Id: AD75740047 X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=umIEJIdq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=nuyJH10v; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspamd-Server: rspam03 X-Stat-Signature: otz34px61ugk6iztnzx38dcxzpo58qib X-HE-Tag: 1662022033-189636 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/1/22 03:26, Feng Tang wrote: > On Thu, Sep 01, 2022 at 12:16:17AM +0800, Vlastimil Babka wrote: >> On 8/31/22 16:21, Marco Elver wrote: >> > On Wed, 31 Aug 2022 at 16:04, Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote: >> > >> >> Maybe you can include those functions too? >> >> >> >> - __kmem_cache_alloc_node >> >> - kmalloc_[node_]trace, kmalloc_large[_node] >> > >> > This is only required if they are allocator "root" functions when >> > entering allocator code (or may be tail called by a allocator "root" >> > function). Because get_stack_skipnr() looks for one of the listed >> > function prefixes in the whole stack trace. >> > >> > The reason __kmem_cache_free() is now required is because it is tail >> > called by kfree() which disappears from the stack trace if the >> > compiler does tail-call-optimization. >> >> I checked and I have this jmp tail call, yet all test pass here. >> But I assume the right commit to amend is >> 05a1c2e50809 ("mm/sl[au]b: generalize kmalloc subsystem") >> >> Could you Feng maybe verify that that commit is the first that fails the >> tests, and parent commit of that is OK? Thanks. > > Yes, 05a1c2e50809 is the first commit that I saw the 4 kfence failed > kunit cases. Thanks, squashed your patch there and pushed new for-next. > Thanks, > Feng >