From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFB9C001DF for ; Wed, 16 Aug 2023 17:14:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7AB68D004D; Wed, 16 Aug 2023 13:14:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2ADF8D0001; Wed, 16 Aug 2023 13:14:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF2FF8D004D; Wed, 16 Aug 2023 13:14:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BD77E8D0001 for ; Wed, 16 Aug 2023 13:14:17 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 95CBF809A4 for ; Wed, 16 Aug 2023 17:14:16 +0000 (UTC) X-FDA: 81130616112.06.D0E8905 Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by imf10.hostedemail.com (Postfix) with ESMTP id 7764CC0025 for ; Wed, 16 Aug 2023 17:14:14 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=DXtlJjZU; spf=pass (imf10.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.182 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692206054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bClHJc1J09Uc597SKqIse7SwNgjMDo77yl9cKdngn9U=; b=7BTNcLHTESQReGi1+rg4i+rkPtwWaoOIbfGlV3Pl395y7XNeAX3cb2wCswjnqU9uOGV3uX wtDd1YIRR+QmLwI52yTbl/jePA26cHAsEwCjX6NxqNmbubfvrd/GWg35E8VezYDLlgpcsm 2VkMDIosBiYnS8DnYwBn+ezL5olPGC0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692206054; a=rsa-sha256; cv=none; b=bET4cU9CBwx2aBCT7CI8Vg5kh6nqpcpbYIkhxtFOb2prgnqq3E5wp/2IwtcR3GTtT6kosZ csQsbAOfNV83ygoa2hhbaa7cQgXAneISAHFmNjFcIGOx5ilZlyPgyXUM1zw4W+NZ+X7R2w 8p/8HlZMeRyuxE45kgRLtaPS+jpYaQY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=DXtlJjZU; spf=pass (imf10.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.182 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-il1-f182.google.com with SMTP id e9e14a558f8ab-349177bf6bcso3010405ab.1 for ; Wed, 16 Aug 2023 10:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1692206053; x=1692810853; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bClHJc1J09Uc597SKqIse7SwNgjMDo77yl9cKdngn9U=; b=DXtlJjZUp2yZCW7rYDuyQyY/VXeK1fLyOGPHYMN3WPoUPLdyMOyqdK7Fr8rjhkw+PS nPlufPtvLecFrzr25J/fklFN09Om16H3OYExbNY3VFtVfbJ4pxIU7gUNcV2uY2YUWJDo ZrvHgKxNd+8PhFmOzx3fJ+hfzEfkslslI7igE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692206053; x=1692810853; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bClHJc1J09Uc597SKqIse7SwNgjMDo77yl9cKdngn9U=; b=YHh1DsbRnkimd1weWQx0BsMh76SJ5SoXrZGkConkSQpyq+gGxCkpUUUdh4EbG5/rPA wVvisN0nLwtuT54P5nkSTfE7IZwqCBQG95y7BlcWvSbkS9q+wh7N3TiWLJrVwpyZqa7H XDd2ot9Ue6uJh2hTEF6RddlX7NIxM7kh97hlv9XfbG7S0L7ACvidlyoKWhs6AgCHUzUs H+FwBu9s7EQpAFkxsUMJ3w7riRS45cuDTG6G4SfnykNZhvAofCeyAJxYOR3QyUpUBFOd LuD9u5w3PEe/wQEK3BEB48kNE6T8ZrfpFL0awBRWGviSGgVMblhX7AviULI2Uz2O7KIJ J9fw== X-Gm-Message-State: AOJu0YzI5ibvjn91Rb+AFqJ6yLiXvTzuUPpFx9mpOMislqFQZhkLbfGR bQ8P9J91VDLAYkCXPJhHtYGqiA== X-Google-Smtp-Source: AGHT+IGmANeZ6j/J0szq/EhG3Ckfna1QYShnyfqDtKVX0ELxpzdZHjr0F7+ELeUG7nsvIrvSOF3MKA== X-Received: by 2002:a92:cf4a:0:b0:341:c98a:529 with SMTP id c10-20020a92cf4a000000b00341c98a0529mr3482713ilr.0.1692206053696; Wed, 16 Aug 2023 10:14:13 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id n2-20020a92dd02000000b00348880831fdsm4678665ilm.58.2023.08.16.10.14.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Aug 2023 10:14:13 -0700 (PDT) Message-ID: <111cdd72-05bc-5811-092f-419937a9f1e0@linuxfoundation.org> Date: Wed, 16 Aug 2023 11:14:12 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/3] selftests: cachestat: properly link in librt Content-Language: en-US To: Andre Przywara , Shuah Khan , Nhat Pham , Johannes Weiner Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20230815155612.2535947-1-andre.przywara@arm.com> <20230815155612.2535947-2-andre.przywara@arm.com> From: Shuah Khan In-Reply-To: <20230815155612.2535947-2-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7764CC0025 X-Rspam-User: X-Stat-Signature: 4hwy9mujzcpzejrd53385ajfp8hee693 X-Rspamd-Server: rspam03 X-HE-Tag: 1692206054-486881 X-HE-Meta: U2FsdGVkX19JIyD8EYBnbllgiZpkboSC9WMCAULke97l5XjxalHeVziTA0x35dL5R1HYkjt93Ssh/UNRjAh4DeZcmV4Jk1od8BiE/jq2SZBsm8XFgXq7iY6xVeek9DCxNasJUgStKeNaXE+7PSaKk2tdQ3tPkyQNf7x9Ri7WVIszYsc/06nH3SP2beCpqpXG52O3rMUzE7i/1j/fHYBFBuUaYeZopB9BrWMcAbHk9bNFphv/HZZ5/t3Zf+nzlVu7GkxDR9xwBYCk0d3EHt/PIi6Wq3Hyx/t1O0jSOOfV9+ozEC42Qqs3h/UE9It/VTGySeQ8kHSY5TD/D8NVl2K/TVRWwRlXbeasLhjawxO11LX72lHFkWIH+zadr9ijN3reTId74poJAfq1RotTfK7Rrp6RiZnebCgyJ4s4So9XymNT10fnHI2uBvZCv5aWNIrB+h1kuxY9pUY9Pra3HKwvrMvfTLPDs7tJjhHpmpTrbOCuecZoaO5fsniqGVeTSiUio+PYSAcSzYlDdu/687s901H6nFYL7UODUd6RkJk1F/T0gNA7Cp2LSAoNkJXz7euEu783bkny2nMCrSetq1aGxTjBhcKF9VfcsJeT3S6Fns5s6wR9LrCoydq+n6Rd1h0GaqfI+dWh358kaZp5GIVdC40OkfpRZUUc+ptNiBNa2r1tW5OEf1bJfsJgQYukuKqFTUmL8EjiuzsQqginkO5TkouRrFAew1v2FyXTutAme7juShwvS6IjQrNlkMdpSDUn0D+0LQAARN8OAhmS1HpKWTnTa7+gzGQCPZbYrnMUTsynjSNVp/tfGAScHeb0/ElyIH56q3tXGtXOyXy7js5r35Ef4PTBnD+UpSlmuRnbWqDS5a6+Gdl48r0D5PiV3tpCS245C5k55AIsAq/b/eIXk+Oj2bA1/50ghCeJWX3688j61OGaOiCRHWBACet2KAs+5943SW4W1rbWgTiMZMy BxSdF4fq jjQh6fiTMiImo98o5CBV7JT0MfAbun1x0EnvlpJjMyHFX7f7kEuCB8OsSgnH+RCzYtNwE8Eh4sKB7JbquyuTj44rLXJ48XB/dSVVB9gbCzImFGhAUSojtrRCcThHMl7mkwd7o1HWKGx2MqXcIldFw8a4RMefatw1mfQxglZknzLDYiOt8o0ggsLQ7CuzfPf5O8yhFpiMvhOGtDimZN4u2pObM4eljCc90P+9IX6XKTwVFt6zb9kS/oJcYT1TFq6YMuduG1zr+CmyyMJv5v0e5QJIJh/UNuKWKp1EZkn9ZWR8xPKFkAgLjJh3OgQxQmz3HJhIaBGus/I9DoqCaYJuDWPUNEC5vM5vaH/FhXlzXRBVw9p3UwCSRAuieJXuTaF321UDAgl7dBrVoqdzP14W5KtVALsoRkI8VgY6ybfZI9wFLOh9yrSxHRPzfng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/15/23 09:56, Andre Przywara wrote: > Libraries should be listed last on the compiler's command line, so that > the linker can look for and find still unresolved symbols. The librt > library, required for the shm_* functions, was announced using CFLAGS, > which puts the library *before* the source files, and fails compilation > on my system: > ====================== > gcc -isystem /src/linux-selftests/usr/include -Wall -lrt test_cachestat.c > -o /src/linux-selftests/kselftest/cachestat/test_cachestat > /usr/bin/ld: /tmp/cceQWO3u.o: in function `test_cachestat_shmem': > test_cachestat.c:(.text+0x890): undefined reference to `shm_open' > /usr/bin/ld: test_cachestat.c:(.text+0x99c): undefined reference to `shm_unlink' > collect2: error: ld returned 1 exit status > make[4]: *** [../lib.mk:181: /src/linux-selftests/kselftest/cachestat/test_cachestat] Error 1 > ====================== > > Announce the library using the LDLIBS variable, which ensures the proper > ordering on the command line. > > Signed-off-by: Andre Przywara > --- > tools/testing/selftests/cachestat/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/cachestat/Makefile b/tools/testing/selftests/cachestat/Makefile > index fca73aaa7d141..778b54ebb0364 100644 > --- a/tools/testing/selftests/cachestat/Makefile > +++ b/tools/testing/selftests/cachestat/Makefile > @@ -3,6 +3,6 @@ TEST_GEN_PROGS := test_cachestat > > CFLAGS += $(KHDR_INCLUDES) > CFLAGS += -Wall > -CFLAGS += -lrt > +LDLIBS += -lrt > > include ../lib.mk Thank you. Applied to linux-kselftest next for Linux 6.6-rc1 thanks, -- Shuah