From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8EA3C0015E for ; Tue, 15 Aug 2023 08:58:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 296ED940018; Tue, 15 Aug 2023 04:58:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 246038D0001; Tue, 15 Aug 2023 04:58:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10E4B940018; Tue, 15 Aug 2023 04:58:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0208E8D0001 for ; Tue, 15 Aug 2023 04:58:12 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CA9DE40D15 for ; Tue, 15 Aug 2023 08:58:11 +0000 (UTC) X-FDA: 81125737182.04.D2EA96D Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf14.hostedemail.com (Postfix) with ESMTP id A9D7F100002 for ; Tue, 15 Aug 2023 08:58:09 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692089890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X495J7GDvmtMt/tPE3cIpU197s2E3jwHZa0wQbp4haI=; b=ocHWyLfnfyjUPncep29Ve/t+GvokPi6MEVyg96wmTvnjsJdguBhf5U6rhU+gD+PgudDynd y52MXdPHTkCwpkO4YukhzZ/WQJtx8wKOnfA/v/v+TZnFyHkBEa1iiChpCmhXmcB6vFFbJn yNCbpe4p1nsNimo5kVqmZgdj2YaZeVw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692089890; a=rsa-sha256; cv=none; b=cAwpCzPpROyAnj6ysJP36/+HL9dARkAlpY8uMS8FSO/mPVDmHWo0vXK7fSTTZgzkqagXC0 C2eZ9FA0Q8kqONjFtfWUNQdMDYTu9kDcThmp4TGS/CHK7uOVrXeUP/J/ddVVgmPeu0Z1AV vAyrJDJ7OrSpVL/ay72HL4nG6T+V77c= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VprNF3U_1692089882; Received: from 30.97.48.59(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VprNF3U_1692089882) by smtp.aliyun-inc.com; Tue, 15 Aug 2023 16:58:03 +0800 Message-ID: <111c3142-e20b-3e3c-f107-cbb64a16c2b0@linux.alibaba.com> Date: Tue, 15 Aug 2023 16:58:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 6/9] mm/compaction: rename is_via_compact_memory to compaction_with_allocation_order To: Kemeng Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mgorman@techsingularity.net, david@redhat.com References: <20230805110711.2975149-1-shikemeng@huaweicloud.com> <20230805110711.2975149-7-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230805110711.2975149-7-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A9D7F100002 X-Rspam-User: X-Stat-Signature: 8yb53fysy7we9waynhah4fgru9h7zye1 X-Rspamd-Server: rspam03 X-HE-Tag: 1692089889-476974 X-HE-Meta: U2FsdGVkX19szhyaP0iKPP7mVIQKwyN8bti5pRd3xT/wotO2C3rPONzHO+ysICn7qD/81/OYGC+1pt62vqobfNAgnoJviTRMz5nS35+olL4bodbUgjKj0k+PqrxT/LqPg9BawMNUbPvIqOuKgP9020FtGXgLtRv4wpVb5rRdjFdOmBUfdgk+wVaCVuAdoXJlQFx85/MaAdkZQAHtYozeQlqr7g3seoQa0QLIyIixmaMQdKJSch48NN+i4zvjk8z8M423FrLZx+82Cve3AnN2D8cRsicz1gIxz0ynifo9GaG+fXYPyyvjBrfrpsvK/+K8Dk7+7J5ehVuB98aZtwtoNFv9ZKeDBz8lNkHBxo/wnDkhKTDj+7G0nccZFtarcrYHdE6NVJ9WTvYeOsDA3VIcsRtYE1luKt5m/ez2yaYWnTbjq6B43A7rL4odwRePylivGkGL5O2XlUjzImqgDJdJndDGB60EOmtmMgEtYXdq0nVEDrW/lzgbkH7ZqFViyQjjC3RKvZgn+yS50BYTDzT0d7+8IckKnq1Dw3SvzscQNyXJPQmLWVEE054OvtZKzD0FGunK146AB96Giii3BtDt7Csht0CEzXly5Kj2gSIghw5QSBbQax3FPR0TTHnzkeRqInFIlOBQluy3ZZP6bsQDUHmZqOi0YjvXK24iyOLNzUi5KMBsSEqrAsxbhPf4BGBIGZSinI3ztxAgqbVvvIt1xpD2TYrKs3s8WV3UHCWr0i5WcqYcW0jZfeBkKf3FxB6/1KI8nOIjddZEdSgf+vpk9GFtOFy8soRr9CMb0R5k3OhyMULQ0XVhqHT+dweyL9RZVz4axa8valPaxclKLaERavaqWn8nzNSa0LcS585e6hlWStbwDgw0LXu8AUkJiJJsHzbZn6mt3UU08yl1UC2g1EE4bRJ8GQvtfSmvY/I6/PP1YhELFfVZSexWYzuQGYJn73ah15flfE6aP1/M/FF Hbo4ujLE aqeL/BrtbSqQ3nxHVwG7yP2j+Rla2e9utWewyeuPw4PQCZQqY+PfR4a1n7FUAMpzW+1lkdsLzXd0eZzvtMfPk/v0cNQkr19xtMulrEEZOLqD3odFS0QAsA2noG1ugcKd/CtFMmgfLpE9m4w2uZ62rHghYemY2Z6v1FInV4jsdA7WMJd1vEQ6QSeijKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/5/2023 7:07 PM, Kemeng Shi wrote: > We have order = -1 via proactive compaction, the is_via_compact_memory is > not proper name anymore. > As cc->order informs the compaction to satisfy a allocation with that > order, so rename it to compaction_with_allocation_order. > > Signed-off-by: Kemeng Shi > --- > mm/compaction.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index d8416d3dd445..b5a699ed526b 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -2055,12 +2055,11 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc) > } > > /* > - * order == -1 is expected when compacting via > - * /proc/sys/vm/compact_memory > + * compact to satisfy allocation with target order > */ > -static inline bool is_via_compact_memory(int order) > +static inline bool compaction_with_allocation_order(int order) I know naming is hard, but this name is not good enough that can show the compaction mode. But the original one could. > { > - return order == -1; > + return order != -1; > } > > /* > @@ -2200,7 +2199,7 @@ static enum compact_result __compact_finished(struct compact_control *cc) > goto out; > } > > - if (is_via_compact_memory(cc->order)) > + if (!compaction_with_allocation_order(cc->order)) > return COMPACT_CONTINUE; > > /* > @@ -2390,7 +2389,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) > > cc->migratetype = gfp_migratetype(cc->gfp_mask); > > - if (!is_via_compact_memory(cc->order)) { > + if (compaction_with_allocation_order(cc->order)) { > unsigned long watermark; > > /* Allocation can already succeed, nothing to do */