From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Nikita Danilov <nikita@clusterfs.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH]: VM 8/8 shrink_list(): set PG_reclaimed
Date: Mon, 18 Apr 2005 11:13:56 +1000 [thread overview]
Message-ID: <1113786837.5124.7.camel@npiggin-nld.site> (raw)
In-Reply-To: <16994.40728.397980.431164@gargle.gargle.HOWL>
On Sun, 2005-04-17 at 21:38 +0400, Nikita Danilov wrote:
> set PG_reclaimed bit on pages that are under writeback when shrink_list()
> looks at them: these pages are at end of the inactive list, and it only makes
> sense to reclaim them as soon as possible when writeout finishes.
>
I agree it makes sense, but this is racy I think. It will leave
PG_reclaim set in some cases and hit bad_page. The trivial fix is
to remove the PG_reclaim check from bad_page. It looks a bit more
tricky to do it "nicely".
--
SUSE Labs, Novell Inc.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-04-18 1:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-17 17:38 Nikita Danilov
2005-04-18 1:13 ` Nick Piggin [this message]
2005-04-18 16:18 ` Nikita Danilov
2005-04-26 4:29 ` Andrew Morton
2005-04-26 5:27 ` Nick Piggin
2005-04-26 5:48 ` Nick Piggin
2005-04-26 10:16 ` Nikita Danilov
2005-04-26 10:29 ` Andrew Morton
2005-04-26 10:32 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1113786837.5124.7.camel@npiggin-nld.site \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=nikita@clusterfs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox