From: Dave Hansen <haveblue@us.ibm.com>
To: Ray Bryant <raybry@sgi.com>
Cc: Hirokazu Takahashi <taka@valinux.co.jp>, Andi Kleen <ak@suse.de>,
Marcello Tosatti <marcello@cyclades.com>,
Ray Bryant <raybry@austin.rr.com>, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH_FOR_REVIEW 2.6.12-rc1 2/3] mm: manual page migration-rc1 -- add node_map arg to try_to_migrate_pages()
Date: Wed, 06 Apr 2005 08:39:23 -0700 [thread overview]
Message-ID: <1112801963.19430.151.camel@localhost> (raw)
In-Reply-To: <20050406041701.25060.91114.75958@jackhammer.engr.sgi.com>
On Tue, 2005-04-05 at 21:17 -0700, Ray Bryant wrote:
> +#ifdef CONFIG_NUMA
> +static inline struct page *node_migrate_onepage(struct page *page, short *node_map)
> +{
> + if (node_map)
> + return migrate_onepage(page, node_map[page_to_nid(page)]);
> + else
> + return migrate_onepage(page, MIGRATE_NODE_ANY);
> +
> +}
> +#else
> +static inline struct page *node_migrate_onepage(struct page *page, short *node_map)
> +{
> + return migrate_onepage(page, MIGRATE_NODE_ANY);
> +}
> +#endif
I don't think that #ifdef is needed. A user is always welcome to call
node_migrate_onepage() with a non-existent node in node_map[] because
they'll just get an error when the allocation attempt occurs. The same
is true when there's only one node.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-04-06 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-06 4:16 [PATCH_FOR_REVIEW 2.6.12-rc1 0/3] mm: manual page migration-rc1 -- overview Ray Bryant
2005-04-06 4:16 ` [PATCH_FOR_REVIEW 2.6.12-rc1 1/3] fs: manual page migration-rc1 -- extended attribute system.migration for XFS Ray Bryant
2005-04-06 4:17 ` [PATCH_FOR_REVIEW 2.6.12-rc1 2/3] mm: manual page migration-rc1 -- add node_map arg to try_to_migrate_pages() Ray Bryant
2005-04-06 15:39 ` Dave Hansen [this message]
2005-04-07 0:51 ` Ray Bryant
2005-04-06 4:17 ` [PATCH_FOR_REVIEW 2.6.12-rc1 3/3] mm: manual page migration-rc1 -- sys_migrate_pages Ray Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1112801963.19430.151.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=ak@suse.de \
--cc=linux-mm@kvack.org \
--cc=marcello@cyclades.com \
--cc=raybry@austin.rr.com \
--cc=raybry@sgi.com \
--cc=taka@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox