From: Nigel Cunningham <ncunningham@cyclades.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@digeo.com>,
Linux Memory Management <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add freezer call in
Date: Wed, 16 Mar 2005 12:09:21 +1100 [thread overview]
Message-ID: <1110935361.6454.197.camel@desktop.cunningham.myip.net.au> (raw)
In-Reply-To: <20050315233740.GE21292@elf.ucw.cz>
Hi.
On Wed, 2005-03-16 at 10:37, Pavel Machek wrote:
> Hi!
>
> > This patch adds a freezer call to the slow path in __alloc_pages. It
> > thus avoids freezing failures in low memory situations. Like the other
> > patches, it has been in Suspend2 for longer than I can remember.
>
> This one seems wrong.
>
> What if someone does
>
> down(&some_lock_needed_during_suspend);
> kmalloc()
>
> ? If you freeze him during that allocation, you'll deadlock later...
I suppose you're right. I'll see if I can look into this situation some
more. (Longer todo!).
Nigel
> > Signed-of-by: Nigel Cunningham <ncunningham@cyclades.com>
> >
> > diff -ruNp 213-missing-refrigerator-calls-old/mm/page_alloc.c 213-missing-refrigerator-calls-new/mm/page_alloc.c
> > --- 213-missing-refrigerator-calls-old/mm/page_alloc.c 2005-02-03 22:33:50.000000000 +1100
> > +++ 213-missing-refrigerator-calls-new/mm/page_alloc.c 2005-03-16 09:01:28.000000000 +1100
> > @@ -838,6 +838,7 @@ rebalance:
> > do_retry = 1;
> > }
> > if (do_retry) {
> > + try_to_freeze(0);
> > blk_congestion_wait(WRITE, HZ/50);
> > goto rebalance;
> > }
--
Nigel Cunningham
Software Engineer, Canberra, Australia
http://www.cyclades.com
Bus: +61 (2) 6291 9554; Hme: +61 (2) 6292 8028; Mob: +61 (417) 100 574
Maintainer of Suspend2 Kernel Patches http://suspend2.net
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
prev parent reply other threads:[~2005-03-16 1:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 22:21 Nigel Cunningham
2005-03-15 23:37 ` Pavel Machek
2005-03-16 1:09 ` Nigel Cunningham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110935361.6454.197.camel@desktop.cunningham.myip.net.au \
--to=ncunningham@cyclades.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox