From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 019EBC77B7F for ; Fri, 19 May 2023 07:21:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DBA9900004; Fri, 19 May 2023 03:21:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 262DE900003; Fri, 19 May 2023 03:21:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1041D900004; Fri, 19 May 2023 03:21:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F1CE9900003 for ; Fri, 19 May 2023 03:21:46 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C4379C07EB for ; Fri, 19 May 2023 07:21:46 +0000 (UTC) X-FDA: 80806159812.16.4CC3E4C Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf12.hostedemail.com (Postfix) with ESMTP id C40F140009 for ; Fri, 19 May 2023 07:21:44 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=nFBcGtR+; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf12.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.44 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684480904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aNZ3qyN6oyXbeQpxb9jE35xavW40i2UfsZY947zNi6A=; b=ZDPe9aKaH5pC28FedMmjbq1xFeAbJtLKo7OQbxdQuYxkgASyWrPlsyer/wx7zGhdNkeI27 uGm5KY7UZDDmncTHKR/hvMvddvkfN8f4m6+VOSyGVsWdO5xKd0/VzeUjWSndAqAWZmBM7X tn+I97vGbHYBQchBcNF8bb+U0Ml7hjk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=nFBcGtR+; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf12.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.44 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684480904; a=rsa-sha256; cv=none; b=QWV5V7l1PfSNjdfwZeHC1ywKuOm4K01ROxoASMBOWaKSQigYJ1U3Wvi2d3i1k/JQQ7yGy9 NRTpW+MkXASzFNBgFoM/LDUJrVYSmWxbG/gwTs38e+HEDkp4wP5wQczAiQCj6bynVAi9M6 BICuL4FLvuW5vJmMoT1FbBwF5RijDjw= Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3063433fa66so1836847f8f.3 for ; Fri, 19 May 2023 00:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684480903; x=1687072903; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aNZ3qyN6oyXbeQpxb9jE35xavW40i2UfsZY947zNi6A=; b=nFBcGtR+q6RWN4wIRGCpaNcck/OXxyOWNm+gj3QIv3XT87Go5ZbPZIZPg5Tn9mLkD+ e7ARQa2Nl2KAJluKz35RBPSYkc3c7Ur1zRZoo99U52fVnf0i8tHwBYBtEu2apK8aklYv TA4/dHiDokjBMqyxwZI8t5HMZt1EAvMfS6aZcvxfe4FB9dTVe2fJoCMT5gGYTj9IJYTR 5wyaMqOouDY9++Zoc+dHU4N/TJnmFjtlUs2TGLjvNpRWiNEiabUFnaE9wOBf0YwNhR4y yREwTQyMuDRCt4cpuDYBMHfEJ1G+vIEqnnH6SHxsn21k0czziOvRKAxxqahJ9sQxqRUW 7+Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684480903; x=1687072903; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aNZ3qyN6oyXbeQpxb9jE35xavW40i2UfsZY947zNi6A=; b=V4JsTBJUN6jxnHPsmlJcql6KUwPJjtJPfK9xJFTPv6s4ZqoaeQH0poezAb3oF6y3/2 PJx8dr3xUzzmvGD5PKwIahPP07t4FygLmgiFP1/AORE3M2sMfgQP6l0n7Oqptn16vClc iPQwboVeBa+n6hUj4E9r0RBPXy1mmsp82kFkEC8G29d8/Hg1dAx/4OBRR4zfzVHjrMR0 P9yHkkBzWD+UZbmLtfNhR9DjankbcZxVIRgMwok/VaTucZMNnH0rQogZKh/ygRGrjRX7 E9z6BQhN23mfKL9CnqNmV4FiaYSYM3RapgIOrqL65GakkeTPp0r+29rMu3XYHOADnKfr 6xyA== X-Gm-Message-State: AC+VfDwv//pbfnkWtMi4x8vOUu+aqknWbvgkOsVXuZ2t70c9uWiTr8KY 7syQ2eV1cjv0sYFQamb5D3ECqg== X-Google-Smtp-Source: ACHHUZ6Ezp1L9iAjUVbIXAmlKN/iS9Pt494Dm+7ljsI25DttxqjuqCPZ36RewBvHRz+DFiNOy83/Yg== X-Received: by 2002:adf:f74a:0:b0:306:342a:6a01 with SMTP id z10-20020adff74a000000b00306342a6a01mr853884wrp.47.1684480903233; Fri, 19 May 2023 00:21:43 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id k17-20020a5d5251000000b003079693eff2sm4331182wrc.41.2023.05.19.00.21.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 00:21:41 -0700 (PDT) Date: Fri, 19 May 2023 10:21:37 +0300 From: Dan Carpenter To: Andrew Morton Cc: kernel test robot , Oscar Salvador , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [linux-next:master 2908/3314] lib/stackdepot.c:544 stack_print() warn: unsigned 'stack->size' is never less than zero. Message-ID: <110d728f-b125-4358-9839-13e094597ef9@kili.mountain> References: <202305182345.LTMlWG84-lkp@intel.com> <20230518133247.a0ece8de7c3fc5dca9e1b67d@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230518133247.a0ece8de7c3fc5dca9e1b67d@linux-foundation.org> X-Rspamd-Queue-Id: C40F140009 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: d9k3dk5qkg1s413i7y14ta6poc4cqfb6 X-HE-Tag: 1684480904-762176 X-HE-Meta: U2FsdGVkX1+tSlchyx5jQEvTw/k8aLSd6pyZz4aK6YKtNsggkP7jQ3Uz6Vts7nhDMET7tAR9R/bebZ9X+jRlXgAQJaf9ohMmIseqlhT8wVLcHspc8jF/fH/tdjilYauICXL9ZNdjbwDoQ1PWK0K1CmPw22DYd0h2O3TbWzqDpNIUdok74KS5OuHo/OhmueLpSxWp0KjJ2CrPQi31+InUwJVJOncaLN6WORRQJI00aCz8pRFUsw8TsCdLeLPmHo869io+oKxGDzN6iOAYFNvT3RKJtl490zXI8qmoTQvCbvhO+XGAwJJJJKM1E/SqFJhFcWu5epjYSIJKoP8Xx+G6kBwjhnuSfQ4C98a/467zn6ctyefG1jpdub+ful3cCXBjqYXLO3aUUtOrSByV4+AKT7vaa2bg8Dp37ia919v8hqo+Lddz+vJKfB84pvjcFWkZuaDMzHarGmHQs3ByLSE+5DbGi/bsZMozah+aGN9T5eqOtfXwVHuB5o3Gf9VnH3urSjJFm+g4TnQAbxDsSl1vY5nM0W+RGM4QBlqjoxANpw2r4QPN+2zn+kaHU/o2YPSG+hzWVly2NyWF1eZEDVRLUTGr8ydXuu/PFAbT22aTAoDP1cOWXpdFFya31UBuxXCXmTsOMOWBQ4PvBLY1GFT4ZMO3F019gAeTEtPH4F8eFJc1b50NtbqCSvBLRsaaSXc9s4Er1wWHjzFDORsMOee6QuAZusafVxdOdQO8JiYvjM2PAavBOG/kEmmDYsEylyosSih+F01WzOio9u0MeDbaQYSGK/YPBUQSNgY6Id7GoCHIJdDY296BwIgYzoAJ+oUgCNLpIH6jn9OaGCaa0DtnrBsYQJwGevMfsujDCKjKmlwtGDsCMnk/Y0vkSSkEICvBMtbjLDXutQ+vUtRw0M0pgxbnmv5DEC/bzojTpo5/vdTp073iarUZgYKjjmq8D71VViKPr4+2WREZNSlq+Bg HZysnU/u ZZaOaNtiaiubqCWR7kAJQxnrceQG0/Tt9IisuffJfZhwDP2rFbqHBauGC5oHZ8slIehdkLY4IW3xfwHGY5UFq01bC9tDRd6CkU1rPAYB9/ixEjYpAs1YDc/DysrIOi9HcwdZNljhBpdhvSAQy5RRxk5CWSonW+1GX4lEMoWlYLo4xbOazG9a0V2cmBBN3iUX//yzzcD6hxkAefutih7atChywyuGuGbs6AfAs8U7yZYp1aNmbS/mXBATLu4QKskEN8cNTRj3fDzhB/AU0ei3Nou1qiv2hR0dEY3+MNBy2CCVjF0GhLT24AROUrxVJPWEg4H8whL6qJ2C3GDpy61tuafnxXNh57aGtBqiHzYa4yVlCYp0sZK5Hdmz4QuefYmA5NJnha9ddoeNrTEK/PY0c4m8cYajQMEItuHwqKHXZoDw+Y9OeQ47Op1jC4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 18, 2023 at 01:32:47PM -0700, Andrew Morton wrote: > On Thu, 18 May 2023 23:44:10 +0800 kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 798d276b39e984345d52b933a900a71fa0815928 > > commit: e435b85a4aea7a82259105d5d8025655460052e1 [2908/3314] mm, page_owner: add page_owner_stacks file to print out only stacks and their counte > > config: x86_64-randconfig-m001 > > compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 > > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202305182345.LTMlWG84-lkp@intel.com/ > > > > smatch warnings: > > lib/stackdepot.c:544 stack_print() warn: unsigned 'stack->size' is never less than zero. > > > > Linus would complain about that warning. > Yeah. I hadn't intended that warning to be printed. It's supposed to check for if the check for negatives is paired with an upper bound check. That Smatch check is original vintage from 2009 so it's due for a re-write. > > > > 537 > > 538 int stack_print(struct seq_file *m, void *v) > > 539 { > > 540 char *buf; > > 541 int ret = 0; > > 542 struct stack_record *stack = v; > > 543 > > > 544 if (!stack->size || stack->size < 0 || > > 545 stack->size > PAGE_SIZE || stack->handle.valid != 1 || > > 546 refcount_read(&stack->count) < 1) > > How about <=? It doesn't really solve the problem. Smatch complains about that too. I'll fix the Smatch check. regards, dan carpenter