From: Dave Hansen <haveblue@us.ibm.com>
To: keith <kmannth@us.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>, matt dobson <colpatch@us.ibm.com>,
Mike Kravetz <kravetz@us.ibm.com>,
"Martin J. Bligh" <mbligh@aracnet.com>,
Anton Blanchard <anton@samba.org>,
Yasunori Goto <ygoto@us.fujitsu.com>,
Andy Whitcroft <apw@shadowen.org>,
James Cleverdon <jamesclv@us.ibm.com>
Subject: Re: [PATCH 5/5] SRAT cleanup: make calculations and indenting level more sane
Date: Thu, 24 Feb 2005 11:54:41 -0800 [thread overview]
Message-ID: <1109274881.7244.87.camel@localhost> (raw)
In-Reply-To: <1109273434.9817.1950.camel@knk>
On Thu, 2005-02-24 at 11:30 -0800, keith wrote:
> Why not take it one step further?? Something like the attached patch.
> There is no reason to loop over the nodes as the srat entries contain
> node info and we can use the the new node_has_online_mem.
You took away my function :)
Seriously, though, that does look better. Although, I still wouldn't
mind seeing it kept broken out in another function like my patch.
> This booted ok on my hot-add enabled 8-way.
> I am not %100 sure it is ok to make the assumption that the memory is
> always reported linearly but that is the assumption of the previous code
> so it must be for all know examples.
Hey James, didn't we decide at some point that the SRAT could only have
chunks with ascending addresses?
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-02-24 19:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 17:29 Dave Hansen
2005-02-24 19:30 ` keith
2005-02-24 19:54 ` Dave Hansen [this message]
2005-02-24 20:49 ` James Cleverdon
2005-02-24 22:02 ` keith
2005-02-24 22:56 ` James Cleverdon
2005-02-25 18:24 ` Dave Hansen
2005-02-28 18:54 Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1109274881.7244.87.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=anton@samba.org \
--cc=apw@shadowen.org \
--cc=colpatch@us.ibm.com \
--cc=jamesclv@us.ibm.com \
--cc=kmannth@us.ibm.com \
--cc=kravetz@us.ibm.com \
--cc=linux-mm@kvack.org \
--cc=mbligh@aracnet.com \
--cc=ygoto@us.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox