Re: [RFC] [Patch] For booting a i386 numa system with no memory in a node

[Dave Hansen <haveblue@us.ibm.com>]

On Mon, 2005-02-21 at 12:17 -0800, keith wrote:
>   Attach is a patch that allows a i386 numa based system to boot without
> memory in a node.  It deals with the assumption that all nodes have
> memory.  

The diff is backwards :)

> -                       if (node_memory_chunk[j].start_pfn >= max_pfn)
> {
> -                               printk ("Ignoring chunk of memory
> reported in the SRAT (could be hot-add zone?)\n");
> -                               continue;
> -                       }

Could you print out the memory ranges, or sizes here?  Also, please add
a KERN_* level to it.  We might not want this unless the user has booted
with "debug".

> +               if (node_has_online_mem(nid)){
> +                       if (start > low) {

Instead of indenting another level, can you just put a continue in the
loop?  I think it makes it much easier to read.  

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>