From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.12.10/8.12.10) with ESMTP id j0512Ugg025999 for ; Tue, 4 Jan 2005 20:02:30 -0500 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j0512UAl282774 for ; Tue, 4 Jan 2005 20:02:30 -0500 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11/8.12.11) with ESMTP id j0512UPl021029 for ; Tue, 4 Jan 2005 20:02:30 -0500 Subject: Re: Prezeroing V3 [1/4]: Allow request for zeroed memory From: Dave Hansen In-Reply-To: References: <41C20E3E.3070209@yahoo.com.au> Content-Type: text/plain Date: Tue, 04 Jan 2005 15:45:42 -0800 Message-Id: <1104882342.16305.12.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Andrew Morton , linux-ia64@vger.kernel.org, Linus Torvalds , linux-mm , Linux Kernel Development List-ID: On Tue, 2005-01-04 at 15:13 -0800, Christoph Lameter wrote: > + if (gfp_flags & __GFP_ZERO) { > +#ifdef CONFIG_HIGHMEM > + if (PageHighMem(page)) { > + int n = 1 << order; > + > + while (n-- >0) > + clear_highpage(page + n); > + } else > +#endif > + clear_page(page_address(page), order); > + } > if (order && (gfp_flags & __GFP_COMP)) > prep_compound_page(page, order); That #ifdef can probably die. The compiler should get that all by itself: > #ifdef CONFIG_HIGHMEM > #define PageHighMem(page) test_bit(PG_highmem, &(page)->flags) > #else > #define PageHighMem(page) 0 /* needed to optimize away at compile time */ > #endif -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org