On Fri, 2004-12-17 at 10:17, Hugh Dickins wrote: > On Fri, 17 Dec 2004, Dave Hansen wrote: > > --- apw2/mm/page_alloc.c~000-CONFIG_ARCH_HAS_ATOMIC_UNSIGNED 2004-12-17 09:19:30.000000000 -0800 > > +++ apw2-dave/mm/page_alloc.c 2004-12-17 09:19:48.000000000 -0800 > > @@ -85,7 +85,7 @@ static void bad_page(const char *functio > > printk(KERN_EMERG "Bad page state at %s (in process '%s', page %p)\n", > > function, current->comm, page); > > printk(KERN_EMERG "flags:0x%0*lx mapping:%p mapcount:%d count:%d\n", > > - (int)(2*sizeof(page_flags_t)), (unsigned long)page->flags, > > + (int)(2*sizeof(unsigned long)), (unsigned long)page->flags, > ^^^^^^^^^^^^^^^ > > page->mapping, page_mapcount(page), page_count(page)); > > printk(KERN_EMERG "Backtrace:\n"); > > dump_stack(); > > Teensy nit: better not to cast to unsigned long when it's unsigned long. My built-in s/// got a little carried away. How's this? -- Dave