From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8EDBC27C53 for ; Wed, 12 Jun 2024 12:32:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DFBD6B0095; Wed, 12 Jun 2024 08:32:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18F186B0096; Wed, 12 Jun 2024 08:32:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 055D56B0098; Wed, 12 Jun 2024 08:32:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DC1A06B0095 for ; Wed, 12 Jun 2024 08:32:36 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 88F871C23F5 for ; Wed, 12 Jun 2024 12:32:36 +0000 (UTC) X-FDA: 82222175112.24.D934451 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf14.hostedemail.com (Postfix) with ESMTP id 53AA5100021 for ; Wed, 12 Jun 2024 12:32:32 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718195553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VZJFG1y0v+qT27bi9g9vuN6nDUw9JTkvdIA4UyYL22w=; b=IvfmcoHrnwdM4IZPqg+NV9UkP3eDKjGl+qksAXS0UVlJpR3m7NJ2Vsi/xRPA7SAO95VpnX yU/4Ny4ByusITsS4XLRJbalu9YFmDKc9b+2fCeJpMg5PFzNiNU5o8CytjO0F1+9lZQFNGp tzH4J5P06mjYyM+4eLzWPV1H2Fs8Rbo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718195553; a=rsa-sha256; cv=none; b=J7nEQkbwzW0FutnQ46scuOPPeBZvlDiKtHWcpmp/7G4FZ0M6BOFAKOlNXxadZXbWEMrg1s c7QHUFYXRZtBnnfIKVVsp7yX1cHbgMQBQ8WwF7++qPC2TbLdUc5ra3jnb0lH3dRySBS8PZ zYUtDhCLZDPKTsX6KGI3GQmexJFIzSM= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VzlJQ0TJlzddXm; Wed, 12 Jun 2024 20:31:02 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 766671402CA; Wed, 12 Jun 2024 20:32:29 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 12 Jun 2024 20:32:28 +0800 Message-ID: <10f01c7a-fb91-478d-97b1-9ec4d8675644@huawei.com> Date: Wed, 12 Jun 2024 20:32:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: fix possible OOB in numa_rebuild_large_mapping() Content-Language: en-US To: Dan Carpenter CC: , Andrew Morton , , , Linux Memory Management List , , Baolin Wang , David Hildenbrand , John Hubbard , Mel Gorman , Ryan Roberts , References: <100add53-aa58-44ce-a15d-8438001fb2b9@moroto.mountain> <81da44d7-e07d-4757-9a67-87c35b62512c@moroto.mountain> From: Kefeng Wang In-Reply-To: <81da44d7-e07d-4757-9a67-87c35b62512c@moroto.mountain> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Queue-Id: 53AA5100021 X-Stat-Signature: 5r78karq9ipt9aqm6ayp768q31khqdq4 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1718195552-431853 X-HE-Meta: U2FsdGVkX1+8XrT/rfI0fEtHAJMYjdM66ciVWcOCXaxfwCQ2HxQkoDaZ5CKp6Z5PIHdDW4GqmcdRPU8yBdUNhqVvU8nFiotsgiAqt5ijad/sQFln+hnqisDLqzIc0dFbKcQihJs+svzhp34PxuXFrHgflO2Q9aJ7QFd3B3kKJLag04abYhc/WchLl5/sVGqVL/c7xK39eBLCjOWoE2b2BD3Z7uZTFRmCL24wug/mswwet3/vrqPQh9C3dFxXWvfGZjfaAmykscxkodfwONK9sZzNPv5VdxCNy7NPf3TkxkgyRh4VFfQypoT7RbShTse6lmx4a42Stj5mSJya8rTPiHs2v1iSf9j2b0bikpkQFD01wwZ1AbyR356UZGHC5IGll3UojoeVxM+1kLzs8HOYcMEiq2kC90be+iHfRwYLILAXl0DqzrNQRL5//FPIra110YgxXv7LBR0+kRvuq8HmNXUcpckbAtYuwkNfPQ1SHsz9u/nV8vIzyqFQmuPC1cAXBvsZqeb6OcUX67hUxbNIK2JG9vwLOlLw2pnlXMLjD669l1bi155BbxEJYreoU/IXxWwuLWxRcxza8OWHfBs1vPDMgSQk7tcfWh+uefJOBbAIWh1sSM4Z9zT8YTo5xyxKAGT6t4AAHsXPX2diRhefUqlV+Q5ZihgTEv4II1fWkkdoBWjdPZh/RHXHisP9PGzx3lsA3awJvq8E5YjMfyPCEiqrThvskEIos+l021ODJKt7ne6zWLPuYAWPArtsxVeQX5rGqaT4W8T5RYbsPyX3o1yndyB+Bl/WBzJjtYXedCWGm7czIvtHKxxK1o32khJYOou3f/o9o7YzVrwVXejF/avNTcgnSxMaTc5SFEP5oZOoOInorYdxPSAtmvzmQmGz1md5fqULznA+wAMmtfZRQBa5AtLunml/RP6Jw/vUOms5662ssUCiC5CwCRa70L0jTUEk0vjl7tBqCCtAXcF c1v11AcV mN8Jp4Ih/XHAWeShCicTUsHS+Tem4DNOfBpAeYkK3n3Vq2Y0dT7MphA2tcx72DQxJuuWa+K9R3TZuvY035ZMmwtcZHJ5gebHptk6jegciEq6whKO3GijhXS/MF4Jdcky1AcG65CkfETF7RoJMfFd0lRW6ORHVTqxU0WjfUPenXYkdVJx2WNF8zvhme6fjxtTQFjLf+BLvHxeGNl9r3fYuAPkT7aHlv4kppT+V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/12 18:06, Dan Carpenter wrote: > On Wed, Jun 12, 2024 at 10:50:02AM +0800, Kefeng Wang wrote: >>> b99a342d4f11a5 Huang Ying 2021-04-29 5364 out_map: >>> b99a342d4f11a5 Huang Ying 2021-04-29 5365 /* >>> b99a342d4f11a5 Huang Ying 2021-04-29 5366 * Make it present again, depending on how arch implements >>> b99a342d4f11a5 Huang Ying 2021-04-29 5367 * non-accessible ptes, some can allow access by kernel mode. >>> b99a342d4f11a5 Huang Ying 2021-04-29 5368 */ >>> d2136d749d76af Baolin Wang 2024-03-29 5369 if (folio && folio_test_large(folio)) >>> >>> Are folio_test_large() and folio_is_zone_device() mutually exclusive? >>> If so then this is a false positive. Just ignore the warning in that >>> case. >>> >> >> The folio in ZONE_DEVICE is not a large folio, so there is no issue for now, >> but will fix. >> > > If it's not an issue, then don't feel obligated to do anything. These > are a one time email and then I treat it as addressed. These warnings > are intended to be useful, not a burden. The check is great, and the new version avoids to pass the nr_pages, so there is no more warning, thanks. > > regards, > dan carpenter >