Re: [PATCH] mm: fix possible OOB in numa_rebuild_large_mapping()

[Kefeng Wang <wangkefeng.wang@huawei.com>]

On 2024/6/12 18:06, Dan Carpenter wrote:
> On Wed, Jun 12, 2024 at 10:50:02AM +0800, Kefeng Wang wrote:
>>> b99a342d4f11a5 Huang Ying        2021-04-29  5364  out_map:
>>> b99a342d4f11a5 Huang Ying        2021-04-29  5365  	/*
>>> b99a342d4f11a5 Huang Ying        2021-04-29  5366  	 * Make it present again, depending on how arch implements
>>> b99a342d4f11a5 Huang Ying        2021-04-29  5367  	 * non-accessible ptes, some can allow access by kernel mode.
>>> b99a342d4f11a5 Huang Ying        2021-04-29  5368  	 */
>>> d2136d749d76af Baolin Wang       2024-03-29  5369  	if (folio && folio_test_large(folio))
>>>
>>> Are folio_test_large() and folio_is_zone_device() mutually exclusive?
>>> If so then this is a false positive.  Just ignore the warning in that
>>> case.
>>>
>>
>> The folio in ZONE_DEVICE is not a large folio, so there is no issue for now,
>> but will fix.
>>
> 
> If it's not an issue, then don't feel obligated to do anything.  These
> are a one time email and then I treat it as addressed.  These warnings
> are intended to be useful, not a burden.

The check is great, and the new version avoids to pass the nr_pages, so
there is no more warning, thanks.

> 
> regards,
> dan carpenter
>