From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B9AC0218A for ; Thu, 30 Jan 2025 15:27:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08F4B2800CB; Thu, 30 Jan 2025 10:27:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03CB12800C3; Thu, 30 Jan 2025 10:27:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD3CB2800CB; Thu, 30 Jan 2025 10:27:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BA4962800C3 for ; Thu, 30 Jan 2025 10:27:53 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A5254473E6 for ; Thu, 30 Jan 2025 15:27:22 +0000 (UTC) X-FDA: 83064497124.15.2E978DD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 7261840009 for ; Thu, 30 Jan 2025 15:27:06 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JukHDt94; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738250826; a=rsa-sha256; cv=none; b=bD7qGkqJkwbl4SSIL5h9H/AsjUUYMDkt4w94Tw9jqucKGtFbHa+Clv2+wIq8fVIXuBLUjY +q4M7WbVip25ByncplfMP21ZUmcRq58UyjIgZeD7VL/ZWJXNiDye4ZqjJzVlBaBXIgEc3v somQbMFjrjaCWfh5Zam35YuPzs0KYM0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JukHDt94; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738250826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6EfvH24Zk4QAYrENk+aBxb1nppjMz5tPj3khOZvqEvA=; b=IQIynND9T/0oHg5stmkSQpqMdXzlPeQJi+jGZB0mZpMluqodOYJsvrpVXd0q5wnBnyqTqg K8mNpNTpRsaGA9UhjJffMqb5vzkGjKFw2Ao9EKOvMnwmda6k0Mh1kZQMZOZQaWBO5ihX7p pU50zer5x5pv7R4U7qOSOgXVvRSuWRg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738250825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6EfvH24Zk4QAYrENk+aBxb1nppjMz5tPj3khOZvqEvA=; b=JukHDt946v0qCrwBzpYA6aY3sPz0Qus94jkGina0eFauRBsM+XxNAi65UiYMTJJ26oARva 9HnOrRhoylsq9qlVDz6oZ8JAV420N3v81k7wBBXMOmn98MaPyj6R5Fshb/J83Iais5gTsT X1ayiutu458HBOQUJsb5RkHlBxguCUE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-zFNu3sDKM5y6aNEATMa-MQ-1; Thu, 30 Jan 2025 10:27:04 -0500 X-MC-Unique: zFNu3sDKM5y6aNEATMa-MQ-1 X-Mimecast-MFC-AGG-ID: zFNu3sDKM5y6aNEATMa-MQ Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3860bc1d4f1so666897f8f.2 for ; Thu, 30 Jan 2025 07:27:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738250823; x=1738855623; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6EfvH24Zk4QAYrENk+aBxb1nppjMz5tPj3khOZvqEvA=; b=Y4j2put9ChBdOPM4nQynTfS/5nHQbYDRXYPzndxj/a6V6MxOYyTg29nHN1CrJfMIDX gcFgpcen2mIDW0n4JgIFeahRyHPTlXYTVRXPPTIR6+dfkO9vtlnxmjODpShqW4VFBPeL 7d2Kcc6AotilpFzye2HGYa1UaItvs6+lhyKhAcSBKMHudQmCvpxDG2Mx+gSMgdhhUXYG wz/KfZae14xQj7t2d48RDKseLsnvgkPGEsqNDWsnuiAaBB/GpY33T7jtjWlCnTG4Glh8 /EmOdpPC47qLx9dp8UTouoNdYr2YkNcLIQE69MBybDSCY/tj2QJrNbdnN7mJs457eDKK 1x4w== X-Forwarded-Encrypted: i=1; AJvYcCWcADJTWkSqRH6IJzQDjCkLi+MVcOkXMca/2u7u5/n5XVVtawGn1MFZ1AUa6LJTiy41/eiQK8YnUA==@kvack.org X-Gm-Message-State: AOJu0Yz4fVGtLSZeZ8rOTGoSMjdiSEtTi4wEu8NzICvUzedpF5eLLRWZ LgzbCk88Jtq3r2Cv253HkjpQaShId4pjUeAe0JiCIKm0Qjy8wCm80BreaQ6J3Mdjm43j5BNttV7 EHKuWPv75t37ZOhqnx46+hzW/D9lsZLbTSKZofRDotQD28116 X-Gm-Gg: ASbGnctX9jEiksIjBzxMZkqQeZF7S1CGXQEw+ju66JkoPiEWj6Kxg4EnZ8K2qWrNi4k DdhXmNe+3fWrYNk3mSltWNXc7S3kFM3pMPK4ZWWVyIzLSWCPUukEPV/0kV37Or5RN/jCYQOLTL7 uuU5QUwJnwTk3IHNubQvaJeNAiIvzIyh9wW15tYh2GkptJwFfy6iwNs+2dXDTtvQY1oiWwk+WBK SLBJ5VOZcBFzrv3T5v9YaFk7cWFfYSQmB8Lv2Fer59d7ElkBz8mF2Azwlx7Gykvjs7MLyinm1Yk DZ9ZL50LM0IairOHrh/y2bA0x/wj4LNwptHNOPGZym3QSoTdR/YaSIF/Pg/2YeRCuZ1d39hF4If xiNA4mcCYAHcHsaePffd4gJM+5yYdL16z X-Received: by 2002:a05:600c:154f:b0:436:30e4:459b with SMTP id 5b1f17b1804b1-438dc3ca451mr67421195e9.18.1738250812883; Thu, 30 Jan 2025 07:26:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IF5i55LyvroBppi5sagXhnryW5jxU5Q3lAVRCCxKZvooKz6TsR04LsBL0jQxaaSe4iNmLMxgA== X-Received: by 2002:a05:600c:154f:b0:436:30e4:459b with SMTP id 5b1f17b1804b1-438dc3ca451mr67420875e9.18.1738250812484; Thu, 30 Jan 2025 07:26:52 -0800 (PST) Received: from ?IPV6:2003:cb:c713:3b00:16ce:8f1c:dd50:90fb? (p200300cbc7133b0016ce8f1cdd5090fb.dip0.t-ipconnect.de. [2003:cb:c713:3b00:16ce:8f1c:dd50:90fb]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438e23deedfsm27026195e9.16.2025.01.30.07.26.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 07:26:51 -0800 (PST) Message-ID: <10e0b904-1ddb-429e-bcfa-22b360a841b3@redhat.com> Date: Thu, 30 Jan 2025 16:26:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/4] mm/mmu_notifier: drop owner from MMU_NOTIFY_EXCLUSIVE To: Alistair Popple , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Jason Gunthorpe References: <20250129115803.2084769-1-david@redhat.com> <20250129115803.2084769-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ughrthxo7STOPUL7Xanyo4rdlm26j_VR6KuN2KMNGzI_1738250824 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7261840009 X-Stat-Signature: j4ubkb3r6dcpt4zjiqu51g4d3ip77zm4 X-Rspam-User: X-HE-Tag: 1738250826-228284 X-HE-Meta: U2FsdGVkX18hlGuSLE1SQDb6bP4PxpCp9WXu21U1y8YSEoWHpl3YdtU8ywsNIot++EKekLZQ+dfngqEJxe9cWVtFl0ylU92QStxCcJY2er5lCAYXJ2vBsDO6mmmMfbIuiGE8ou+qM4x1+eKZgBar7R4/TDn1+z02gwiuImOu3R5EF/khNCpks5ffsoilwHpdVSq4GVwq0w0/M00upKz0gya98L3G8ucIeM0IXPckD9eI8A6YwWdExRuNxxl4ClFTNIeYpiGYk9Ew+HYfLMc5jafFwko/vfjMgNXuiw9K5CcUCHF5bZtVqFQaM7HHovlAcUvGwu9SDqhC2kVX3NKcaa64ld+eJHQeFsDbNtdzW/wbjH5VCICJgup/q8tnjA/0GCLDyI71+MBWP+VAClHrh/TT++jwFcffl3UivJtM08E8Rphs4O+y0UoMQcAHQQvLxuCsc2dEfViVSXUnX6toze+VwbV1iAJyIGwp+wiQeQV8bp0Nx1CUp3fvuhvyXg/f5e1BeHbK39B1OtDxFyvKDscWdU6uQqwGw1llIEHj3Vh7gN7nsRxVDTP5Dw4q8qyPJ7nQ6BPH8ipw2z5LFEhlp03FHDpJSUPkePyZVFP3ECZRPtvAoy3V9Nzcv+EwX+EPnaLpHEp0cOfmgJbpv+bDHn6rVPDnT5aukX/dQgl5HA/EZi7Iasnt+g9UAyLM5Qo6AOWwt4XsAmHelTCHoIEPIZ4butBVRdRIe6zNaC8Cdeed+lwptkm7ozY1cx8wrhf5otkkVepR+1weSVvtsceOzC+fUwdWv4fRn9G/SU4KYFYwyyuG2i7CIKrF7AK0r2dXC5cO9lATqVTuQyR0lAtsUMs72o+XRx5TXLNZIr+Gl7uehomRWhQ2OzjY8od2LvWiKJ1X8HGqDJ4hqrv/5WBaJcYbmDkvAL1O3VEEtykF+8iWH0q8IS9Ve6Efu0Elc5QXYNx9R9RvKShnFr7dqnl wu35wpB1 fUaZ8jRDIIDStJHDBmAhABsEuiOqHiTV+TxpBnDLUzRxOIR1HcnwbxDC0FLpsWBeSZZhW/VJ/2J/eWcyJikrhbB3vS2tRvo+uBe2c9ZRHHul4Fx/OyLLirUMltWfBi+J+CTJAF56B9Z1fBcGxFfk2nVWkHxxUAZFyvJFM+Um+B52xUJjMt/WXlnXfqghsGlcqvwvsv4kmoZwbB0pZHKI9hAbsbs1aD6h1xLnyOF9eTTARTZbKAgm/S3iP/RfF0S9lkih+OLorSVJI0sYueFF5nN+34YmNwG+g8nJ6vp7luJnc+MkjAdx1Q7o7+ZLvuXqdWv/JgIU+EvplFgy7HP448B3ti3pNatZYkVTCK7xlqaFMTPaztEeguz2Rr0XkTa9Ul+GO8MJ5shRHp87bgLpc3wDSawKkWbhhORuJAm4OtbYSXjqNsCjIfbPQUIsWJ6twb1pA X-Bogosity: Ham, tests=bogofilter, spamicity=0.159763, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.01.25 14:29, Simona Vetter wrote: > On Thu, Jan 30, 2025 at 10:28:00AM +0100, David Hildenbrand wrote: >> On 30.01.25 06:34, Alistair Popple wrote: >>> Looking at hmm_test I see that doesn't use the sequence counter to ensure >>> the PTE remains valid whilst it is mapped. I think that is probably wrong, so >>> apologies if that lead you astray. >> >> Yes, the hmm_test does not completely follow the same model the nouveau >> implementation does; so it might not be completely correct. > > But unrelated but just crossed my mind: > > I guess another crucial difference is that the hw (probably, not sure) > will restart the fault if we don't repair it to its liking. So the > hmm-test does need some kind of retry loop too somewhere to match that. Yes. Especially for the folio lock spinning is a rather suboptimal approach. So we likely would want the option to just lock it instead of try-locking it. (or getting rid of it entirely :) ) > But might be good to also still land some of the other improvements > discussed in these threads to make make_device_exclusive a bit more > reliable instead of relying on busy-looping throug the hw fault handler > for everything. Right. -- Cheers, David / dhildenb