From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC79EE7717D for ; Tue, 10 Dec 2024 00:12:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 130C16B00CB; Mon, 9 Dec 2024 19:12:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E1476B00CC; Mon, 9 Dec 2024 19:12:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC4526B00CD; Mon, 9 Dec 2024 19:12:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D1D1A6B00CB for ; Mon, 9 Dec 2024 19:12:38 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 47E76C07CE for ; Tue, 10 Dec 2024 00:12:38 +0000 (UTC) X-FDA: 82877121642.17.3DF28E6 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf27.hostedemail.com (Postfix) with ESMTP id C384A40005 for ; Tue, 10 Dec 2024 00:12:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xb3ZYJaZ; spf=pass (imf27.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733789533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ydjttIzPV3bTnYaTafALagMKlXhc79P8oTkSG55qp8s=; b=l3VNbqMg9P8lxBn18sTXqRhbSRF98vXnzwu/QjXLJpnJ61a+5hz0vQcViToKkeBhKT6Bi5 FjeBAxwtp4KMMDgqGkiPvH7tk2BI4FbmL/nIT4CzYpriJ8fGElydRSx4oGSleZ/fTfa4f9 V2kC5aZdzm6zQz9B+ppSoBssG4+HSnY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xb3ZYJaZ; spf=pass (imf27.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733789533; a=rsa-sha256; cv=none; b=FzKrVCK7uFjoWiJpuMaC6a82tkJ/C2AiX1kBgvoxE5/9Cev6H2ABNxaDB2CRRYlug9BqbW wIw2kdyLFk2E+5jUrZSYf2yrnX9y+a3M6K9sVipyrmTXsfAD3u1hNMB7+eqjfFe1epHwGA PGDNUn++D5QipNbm+Ylc1/z27Vz9qMo= Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5401e6efffcso1757664e87.3 for ; Mon, 09 Dec 2024 16:12:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733789554; x=1734394354; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ydjttIzPV3bTnYaTafALagMKlXhc79P8oTkSG55qp8s=; b=Xb3ZYJaZegrbrS6sAX/1iDb3eRtoWxedg6D5FSOd1gaHVikTLK2KdHYi0xzIKilnEU g7pyY65KNxHO8rOIeNtcYGwK7vPzKEpXSw4fcvuWCS7d4mKl8LcvUIFOPnKBSORFxJ39 Ew1w6Z+Vyix0igveZSJMrIIATY/lAm0OJYK51Vj7B2SwE4qP/hX05b7dz6mVmXN3UxBp bygx3/dfKOIF/mD9P7RyxzvsHs2JvScVwiDCeDHYRoBmGO7CMMa6QxhPzG/dHz3NuNbH CHxy+6lzG2UF0BXf/fYHBEFvOqH4+5AZu1WWVd9iGhayxkcXR7KOErsYJ4cMGwTAsuL2 hwPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733789554; x=1734394354; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ydjttIzPV3bTnYaTafALagMKlXhc79P8oTkSG55qp8s=; b=xKZp2y8D1RRWqSzo4okS1zKii/wSK18p5S5ZHYwBXQf5XDWpLNubac7qkXJ1s9oaJh wgRUC+BkdMv7mvRRNeqU2D44UzA69/1T4M/Lc4Mw5DFb1NQ3oKgXG4P4BZDkrkGqcnqP WFfGGM7caYzH1MtOhV7vK4//zQ0mHKVYN47fJed8LKMDBjiJgIT5HUNb7MCN3EMHI3NO CA96ZLrdiFrWNYbmX64bOXV+wQg7qhB/XHPu6Wggy0+oDYepj8uu5yj5A3CwUCMzZlBM bu6l+O/rSN/FHrvVsRjg1Bj9EGae3RSVNVNjlmmpSoYyj+mc6XUz4dl1gr/1hy4pe0/e irvQ== X-Forwarded-Encrypted: i=1; AJvYcCW88kZe89SYVG3EJTLB8xgKaFejvKyOtitMlf1s206bhTeyXv31iw2/07HMz0P0xx7KqlnB69T/Vw==@kvack.org X-Gm-Message-State: AOJu0YyhLrQDPNizSFC1XRBGqRiUkWs69dVIKUYNZsPdkoDQN3NW/+g/ dIFmzhUP+zGW8AYqjhDoUFZpEoln2SEqNKrukqhG2yP86vzFZcuv X-Gm-Gg: ASbGnctosY77b94B8rufgt79vcVdnpoUVYvZdTGlXMfjspXSKofuJlKvqvYxX9PEb6j mk/ECSYyBSJM7AXu5zk0362+f3rL4pbRztLujAu1HBeiI5t92AArCPbslde9TiQcsf9SAsM4bV9 dZmmXYH/O4Ivd5rip6uh89HvGYoKnAY9Fzsqu+0NjEBbFpbhpjxkl4L1pzzP2jUBa+RMl/9nR/i CpO92VShbizy2UnQ3rN8cNVIUYNYScK+ZAzb9TT5+OKDmwjc1F7QSvkvydsLbo85X+1F1du3kIb BnM5yNwa/3RJnUV+0D/WmzRteWn7aEs1Ua/eelw= X-Google-Smtp-Source: AGHT+IEkgRTvfbOQFRL66kZv7c9jxP4bDxQA3ziPXEQ3Z5UPCXU/Iw8RVd1OEeT5XxFBiYJ138ho0Q== X-Received: by 2002:a05:6512:39c4:b0:53e:2ed9:8122 with SMTP id 2adb3069b0e04-540240bd4cfmr1042449e87.22.1733789553960; Mon, 09 Dec 2024 16:12:33 -0800 (PST) Received: from ?IPV6:2001:678:a5c:1202:4fb5:f16a:579c:6dcb? (soda.int.kasm.eu. [2001:678:a5c:1202:4fb5:f16a:579c:6dcb]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53e3c491c19sm880431e87.50.2024.12.09.16.12.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2024 16:12:32 -0800 (PST) Message-ID: <10cef75e-92b9-4005-a9f6-10bc8b1dfffc@gmail.com> Date: Tue, 10 Dec 2024 01:12:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm: fix vma_copy for !CONFIG_PER_VMA_LOCK To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: oliver.sang@intel.com, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20241209221028.1644210-1-surenb@google.com> Content-Language: en-US, sv-SE From: Klara Modin In-Reply-To: <20241209221028.1644210-1-surenb@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C384A40005 X-Rspam-User: X-Stat-Signature: 4jdoydsmu5hmr8qe4f3x96eqate1d1r1 X-HE-Tag: 1733789531-123185 X-HE-Meta: U2FsdGVkX18FsreTafoDw/ptbuq6TBvjUseBG2lSEIaeqwmTUABB+VVu09CHq8Hi8kAv9Me45aTIxH62aoD4fLNaEhW1A4fzYHaLLBsVS+gaoxvinOMM4rRBvgOlCBeWDGQ4YiYxBpzu12+55byWsm4UWhB7mMnygT0KalTT+H+QnSY4b4CKOoo8gysAJfT9Xq42HWvH9EmlkIsXvhKg8Wj7/B+DM5O1IT+cBYNYvauNSZ+J6361h1LKOAflFaOmFf4eItLMycVsJawFRFA+XnHMTqP419t3EIvp4mHVgCkrh4rNvSCcxYxCs2jUoY+KyjlRi3MBYxQ1TwbRS1OnN7zXzcvE61kj2Zvz7TzG3gAKt4hFG1YxohnmUBkjNddInoPLXHanZ0woL0DqdvD7jEAqCqjWCTGo8ymNAUBDVriB8PLLR4RxkRhc4PPXo1r8SVRDNN9oPNmHoiKTdkOwnff9IKhGGsrP4ndpuKKFd1d4voexCllUzfeq3d/PqHPLKDlNDTomim6Dk+JZZbarFIlNqziz4Qj1aSDcQ3oEe6oeYoSDpAJRNcpD6oYrhTMco8UKDzVb7ATQ2pclKLDziEY2CeEDQ4rj9TT7L16hxPJBb2VGQSC9Lzt67dTyTY864MmhG0EuAK51+yAh9YPHthlEeoA96NF2koxx8bOlx7ZaPtCTFJHycsy32zgXGo0cTqM6lSLrXzeMQg+CimLqVO7UMjdqxgkP5534RPyzUi0bQuVR7+We73Th2i0qyjNWkgywtJHVXUB/7utxxg2DNtouOOuBsA1bf33cxxQ6/130Dpm9Ri08YG/jM8SbsV43hIC+WvzJwCL4pOyB1NVQAqozrK6hTwI/9bCZkfkfKjcZxmUoxOEqkYDZG9dKv8I50SvwRH/ALJsMw1EBsUeMbZjG0LkuKYg7MgUuqCG5ur95uiV7pQLM/qHQwKxnwPMjvdIDTzAxr8+AVHe7BXY hA7Ttgtq uC+UvK+atScyxj8zQrC9IqpAawqPm8L9dAc5/0XIf34LN0ClYimWk2aE+Z0HJcSwBlo6PmOaNCSIDePmAFFbAeHaJlTvMNo4jkDNxTVPoB96CXDaM6VRJmcqpj8YdaezZPjde++Fd61yFUCqKC3r/6Pl6O22Zn0rIMclckBNiuYvYMsDL0UO9W7bjjkj+/MAJDye9dILNia6rB9MF+y4cZ1j7Unh7E1GFW5OzhKbVVKBqWA+WmLXDU3hmqWMhbv9flmsX+dYOzF9s0uaXPPMUp4snfMvVKTjzRkO585b4HF/ixubyrIQmsA5zGf0JjmSK3251BLjXqxqz431HRFxN5n2fmXZW/DTjF7eBJhdc4u2zyodS799BEkrEeSgEJxpRnQXOKI53M6rg1gdamWwALE7ZWDPA7g4ivbWjOTqZAPW9Gv87ElJiWD29Oiq8djn1fjxYLpy/ozY6PwQ5g8/SSgoB3q+tOwYyG3/A04A/ffcMFo+tKjNtzSwgL/Wl5m61G4p4DpSVW8sREdA/3F4wFgKQPlOIkjD2uf/Q+PgM5Q5Mo4eqIBe5u3Ld+TI/f+1VSJ4n X-Bogosity: Ham, tests=bogofilter, spamicity=0.372072, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-12-09 23:10, Suren Baghdasaryan wrote: > vma_copy() function for !CONFIG_PER_VMA_LOCK configuration copies all > fields using memcpy() as opposed to CONFIG_PER_VMA_LOCK version which > copies only required fields. anon_vma_chain field should not be copied > and new vma should instead initialize it to an empty list. Fix this > by initializing anon_vma_chain inside vma_copy() function. The version > of vma_copy() for CONFIG_PER_VMA_LOCK is fine since it does not change > that field and anon_vma_chain of any new vma is already initialized and > empty. > > Fixes: 85ad413389ae ("mm: make vma cache SLAB_TYPESAFE_BY_RCU") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202412082208.db1fb2c9-lkp@intel.com > Reported-by: Klara Modin > Closes: https://lore.kernel.org/all/d0ae7609-aca4-4497-9188-bb09e96e7768@gmail.com/ > Signed-off-by: Suren Baghdasaryan > --- > Applies over mm-unstable > > kernel/fork.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/fork.c b/kernel/fork.c > index fec32aa06135..d532f893e977 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -524,6 +524,7 @@ static void vma_copy(const struct vm_area_struct *src, struct vm_area_struct *de > * will be reinitialized. > */ > data_race(memcpy(dest, src, sizeof(*dest))); > + INIT_LIST_HEAD(&dest->anon_vma_chain); > } > > #endif /* CONFIG_PER_VMA_LOCK */ > > base-commit: 6e165f54437931f329d09dca6c19d99af08a36e1 This fixes the issue for me. Thanks, Tested-by: Klara Modin