From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 328A9C001B0 for ; Wed, 19 Jul 2023 18:46:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57453280084; Wed, 19 Jul 2023 14:46:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FE5328004C; Wed, 19 Jul 2023 14:46:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39E05280084; Wed, 19 Jul 2023 14:46:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 26AFC28004C for ; Wed, 19 Jul 2023 14:46:54 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E25C1120499 for ; Wed, 19 Jul 2023 18:46:53 +0000 (UTC) X-FDA: 81029243106.08.43D5354 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 165D440021 for ; Wed, 19 Jul 2023 18:46:50 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689792411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ElcTtlozrMw4cmiZmc3f/rfkbey814vl2obutHICwOs=; b=oDu/rKPLrH1ZU5p8M9wZxB/7QgepqO/Is+nGTUbljnszpmqFp+VnfjCcPOqVo5YlLWx8M6 7kTZeeVf3eyJqp3/jmySQsA/IGnvkl84S1SQzgfskPtdFKrH1jNM6iqoSxx6tu3FWGRJw6 fr1FS1pHA8BtS4FTKD5YKDkHMsG9VH4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689792411; a=rsa-sha256; cv=none; b=Qo6b6spHMMEH7bxgxtbzOaW60qwxyF3DXox32YZIjpSgkDPhKDcJ/1lJkf48488fLGh6JB GK1sxMGGYzfMA71em0jxkO1jAuBtpgQJk4TNUZSOFboAvxjE5KCIeDyVjVmqKgkIsc+VUL a771/FFP0Yn3/N7+aRraXxmSMuDY8aA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 177632F4; Wed, 19 Jul 2023 11:47:33 -0700 (PDT) Received: from [10.57.76.81] (unknown [10.57.76.81]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EF49D3F67D; Wed, 19 Jul 2023 11:46:47 -0700 (PDT) Message-ID: <10cdc414-c2d6-90c0-2810-9cdda0323423@arm.com> Date: Wed, 19 Jul 2023 19:46:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 2/3] mm: Implement folio_remove_rmap_range() To: Yu Zhao Cc: Andrew Morton , Matthew Wilcox , Yin Fengwei , David Hildenbrand , Yang Shi , "Huang, Ying" , Zi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230719135450.545227-1-ryan.roberts@arm.com> <20230719135450.545227-3-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: hy7shmnebtmnjyudge1t3cdmnjnr683k X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 165D440021 X-Rspam-User: X-HE-Tag: 1689792410-780760 X-HE-Meta: U2FsdGVkX1927UW4AnnQv4NbEy7nSRqSYATIiIIwCsOT1xj2LdB88wrngBSFGUIMWAWZ5WrLo63nPcA8rbRMunY89qlzhnEpR0qcCB9Qik+k/DAvJYwCYHNtaXeCzAONgJ935pkyVpxjSGfBwWSPv+yCx1TWA4Cm7SWFnJ74TMk95alZUemhgFHlF4kUDxa00XqR3LVzWu1Kp+nM0iqQ8xxOWNq8ZZQdJxH295mrwMyo42hWQ1n2opZz9wJexh2OllEqxwRjQ0PIVPaj8JXEUJU/CMJuqSkSpWGIck1Ugsg7XlM329ISqZuvAGCoNpSICSujliB2LMDhOgurvCjJFFssoAhYiWZGPrQcUuUVFjqHJf1FsvoiuX5UeSviAtUgpoqDuD+2F2dciLyVla6cIJHdR+AICmbxTqCBBnNu/ltUt9KC+FVT65mz6BAzyMaVUGSPwip/TEqXpAIbpJxmlgoCDV9Uhzhh6yrkhSDkijIiNrFKvKfpbELWTznL/u8KlRLDAQt6/8VdfYvFTSwctI8sxGPp7BNKF/3yQcZaS/SkhBsr9cHMXIBm4517gVwGVnsANgA8XNrPmc5NJVJY3wGvOZ04l/N0D2sMT5LXnEHrsAlhF2EmhMmqPHF0C0NFPU4jOUvHJDe+s3PgqTbO3u2yHmQNOkxmVobfKhdlqpC3fpKRIrhFDyaWApGH07DrcIXhXtk+d6inWaZhUd6yH+BWx08k6s7FM9j4omj/USPj1ivJT2oB/DVC0yWVwb/JrsVDufAX/4freZaHZnuGxmI359gbXatqg3t/KcubJi4zkM/EomfKIaMnJ8RyHzMwFs2cuZ3+uQuj54inOldcNYxsln+jxsIOQOrWrTzXsbxzkxd8RO1yNMPpNeQoDfB3pZokMccRGRoZ5pusF8HGhcDn+xczYmExT2DXdVAF8jpoPNhgNBbpgxeG8JOvt3+RnOCK37KV1NfttDUtQ9g i/lxWICo TCCsCze/Qp0GYbmn1y9eJ12mg/7VHNax0tq3ujl3LKzdQJYYBzn8aCpVlewc1Xoml2v9nUOGzrH12zNWf7zTJIoaY8+QAnwBs+sj73aCDnJSZVUcsY9TQWKixxTtS5iG4BPYxEe1GYCID/Yyt3S38nH9XgIAxVpRMVo24O3zPw/fKOpZj/yr6AFRiE3CWu/ETOZivXwZORw0KBLSj7CS2IP5q+95mTcC61J7Pz+JdCN2/pDq3oYuzmeQHIkECyNSmVr3j6J4cgkgdqBc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19/07/2023 19:23, Yu Zhao wrote: > On Wed, Jul 19, 2023 at 7:55 AM Ryan Roberts wrote: >> >> Like page_remove_rmap() but batch-removes the rmap for a range of pages >> belonging to a folio. This can provide a small speedup due to less >> manipuation of the various counters. But more crucially, if removing the >> rmap for all pages of a folio in a batch, there is no need to >> (spuriously) add it to the deferred split list, which saves significant >> cost when there is contention for the split queue lock. >> >> All contained pages are accounted using the order-0 folio (or base page) >> scheme. >> >> Reviewed-by: Yin Fengwei >> Reviewed-by: Zi Yan >> Signed-off-by: Ryan Roberts > > I have asked for this before but let me be very clear this time: we > need to generalize the existing functions rather than add more > specialized functions. Otherwise it'd get even harder to maintain down > the road. Yeah fair enough, my fault; I wrote this before I had your feedback on the other rmap function and overlooked it when refactoring this. I'll fix it and repost. > > folio_remove_rmap_range() needs to replace page_remove_rmap(). IOW, > page_remove_rmap() is just a wrapper around folio_remove_rmap_range().