From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 250B3C04FFE for ; Wed, 8 May 2024 15:38:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AD076B0093; Wed, 8 May 2024 11:38:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95CEC6B0095; Wed, 8 May 2024 11:38:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84B446B0096; Wed, 8 May 2024 11:38:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 66E9B6B0093 for ; Wed, 8 May 2024 11:38:07 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EF0BC160F40 for ; Wed, 8 May 2024 15:38:06 +0000 (UTC) X-FDA: 82095634572.24.BA47F52 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id B598980018 for ; Wed, 8 May 2024 15:38:04 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715182685; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vV7KWMZHnw3sEezuTUxB8Ey4/IOw0ttc+8jHaQtzz7k=; b=EhDw8OmlYZ8wvqS5j3CDA2jQUkQWarSOIpXCrOT6xAHex2HaWc2fWzHo0Lrl7jjMqt9NL9 YCED6ITUQHiU59NcUYSVTBZiImYMpulnU2xkNEn3fy0+bayiN4DXNSKqcBEx4A5+GaxyRl gpZH0VSiEoUppzfkP3D0dKNbEb/60cM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715182685; a=rsa-sha256; cv=none; b=k8209Gg3ZjGYbsRwPXp3h+GFbP7NbHbayadVGhU29yR7BAHnl9yrB+GyrTa0rp7l7TUILS RcLbpMhG9+Dz8B7k4yjC0wznMP6CSsPgmUqpm+cyWaiCUFXnjpMzMY9yATB45VQHLDYNeu dvf/zF5g3NLwm7ODflZJ/j3RJtCrqYU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E42E1007; Wed, 8 May 2024 08:38:29 -0700 (PDT) Received: from [10.57.67.194] (unknown [10.57.67.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C02F53F641; Wed, 8 May 2024 08:38:02 -0700 (PDT) Message-ID: <10cd4b97-d780-4524-a0ee-89f26a7897fc@arm.com> Date: Wed, 8 May 2024 16:38:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master 10159/12060] arch/arm64/include/asm/pgtable.h:1102:16: error: implicit declaration of function 'pud_valid'; did you mean 'pmd_valid'? Content-Language: en-GB To: kernel test robot , Will Deacon Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Catalin Marinas References: <202405082221.43rfWxz5-lkp@intel.com> From: Ryan Roberts In-Reply-To: <202405082221.43rfWxz5-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B598980018 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 96cubhydhhmuahe5new1hs4otout8ow6 X-HE-Tag: 1715182684-840045 X-HE-Meta: U2FsdGVkX1/dLgsIKnD1UEneZoN9f5XexXSQxAhyWJ4i5o4/2Ijg6TpgHuRLUdLm16nlEVIjqZ8j8lEkHLJyy1KJoX0GyqswPvhc3Ixj16RiOdKbDpiqvxWgGN01Tbb6W60RW/t/97jh7apcvqWjSejNAGDKEO1AQZTHOeIS6OHpZ9HiEdKEw4X4Akz7lHlk1W848LfmtlUpX4pJF5mjmPRiyfXwAJte4LcySl61sEGCjgXQPkyplR4YI9IaT7k9ACGpCDShCMUFHUHZJG5lFMHKZ3cGa4ayojPTpk5Qm/qndWUKZTdfIAuFI1P2TYpPdAQ6amFb71OeUk/rpOq27Oykryuu3StzohxgUjwS2HGlttzW58KUgvl1oQSIAeVrpu5e2Ta+s03jObRMIfq8IwBHNBQCQfuw2MjwytGaRHXfou28/UQrA5VDvwIKH12BcHNlfAaT1Hd/f5cQzRJNI3Yo/q3792G0BPYOc7I9ZsSl/xro7nWztSz3cExoNhonnB3KVgJmpuSJtqMjE0QiBdW7arPbXnZ/j1M7B1IJ6yNenhrqdQNzatKCKdnyuHK/PQdxSr5tvEVRiZ3EM0+IMbX7YpDTPjTWcMynL7YKwh5z4DG4QOiuEHcAize+mJoQWgMuDUPoYOxQX2NIbgZr0oReSu4xJsXxVF/nRfz2wjwpXfyvPzXHcYTS185Fvs+g/XcrLlC2iD76ml3Ped+O5JSD7svRp+3IGcXbJtGo0PrO6NpmJ7eGuY4BJ9nCUykwjtLTZeM07eFDDaBZ0qA/dv0onDD9BbEKDinWDDNk4tSl531PfTEUY4i3ZEQxy5MP0e/BGutyooKzbJWRFRg2IEjbo4VDSxXnLIRtX7J5AJtRJtTfvsllcgsJUYuGTBWvOrYiQhmAuXc96BJjZVhQos4FARm9uWjLi3vcJiGDFH43opgn2iDdq/rapTzefDa0Rc21mU5vmV2zQyFZrcC bbiqd3Ft r/p/4EamRq5NptGDz4WUTBUIwATmjh9q6T/zp/5/zdnFwNVcNVBCXE8v7JB9PNs1hSxaatPuMNIzJBzz5dULgzonc8QC3jyDTfZiQ9CNze6RhvSB7mIyRupBXLp6gBByP7Xv44JSkcPm5Fjq7QJhbkTKNijxURVVgeWhglVXHUzFwOXCueZbeSOgV8jjtazuvQufB3uRXTY8gArOOEMlG/ZAywNK5vQlL0k5x1Vljp0QtUhN6HsZCmMDBUNkuecTOFlMhvVmAFLBaDD1TpGpwPqsJDnjkMbUkHgt6tJVDcu6L9b1zOK5j1hmU/nj7azAA5If7J90AnIgl7KklOB8QjoQROq0qkzwM/RluFHABi2mg3zeZFN70NnAuoUewo703pedB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08/05/2024 15:24, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: e7b4ef8fffaca247809337bb78daceb406659f2d > commit: f0f5863a0fb0fb48a5881c3f6acca1958899dd76 [10159/12060] arm64/mm: Remove PTE_PROT_NONE bit > config: arm64-randconfig-r013-20230528 (https://download.01.org/0day-ci/archive/20240508/202405082221.43rfWxz5-lkp@intel.com/config) > compiler: aarch64-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405082221.43rfWxz5-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202405082221.43rfWxz5-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > In file included from include/linux/pgtable.h:6, > from arch/arm64/include/asm/io.h:12, > from include/linux/io.h:13, > from include/linux/irq.h:20, > from include/asm-generic/hardirq.h:17, > from arch/arm64/include/asm/hardirq.h:17, > from include/linux/hardirq.h:11, > from include/linux/interrupt.h:11, > from include/linux/trace_recursion.h:5, > from include/linux/ftrace.h:10, > from arch/arm64/kernel/asm-offsets.c:12: > arch/arm64/include/asm/pgtable.h: In function 'pud_user_accessible_page': >>> arch/arm64/include/asm/pgtable.h:1102:16: error: implicit declaration of function 'pud_valid'; did you mean 'pmd_valid'? [-Werror=implicit-function-declaration] > 1102 | return pud_valid(pud) && !pud_table(pud) && (pud_user(pud) || pud_user_exec(pud)); > | ^~~~~~~~~ > | pmd_valid Hi Will, Looks like this is due to pud_valid() not being defined for CONFIG_PGTABLE_LEVELS <= 2. Seems to me that this is the cleanest solution. But pgtable folding breaks my brain so perhaps there is a better way? What's the process here? Can you just merge this into the broken patch, or do I need to re-post the series, or post a fix patch formally? --8<---- diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index c60dcb455ebd..f8efbc128446 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -810,6 +810,7 @@ static inline pmd_t *pud_pgtable(pud_t pud) #else +#define pud_valid(pud) false #define pud_page_paddr(pud) ({ BUILD_BUG(); 0; }) #define pud_user_exec(pud) pud_user(pud) /* Always 0 with folding */ --8<---- Thanks, Ryan > cc1: some warnings being treated as errors > make[3]: *** [scripts/Makefile.build:117: arch/arm64/kernel/asm-offsets.s] Error 1 > make[3]: Target 'prepare' not remade because of errors. > make[2]: *** [Makefile:1197: prepare0] Error 2 > make[2]: Target 'prepare' not remade because of errors. > make[1]: *** [Makefile:240: __sub-make] Error 2 > make[1]: Target 'prepare' not remade because of errors. > make: *** [Makefile:240: __sub-make] Error 2 > make: Target 'prepare' not remade because of errors. > > > vim +1102 arch/arm64/include/asm/pgtable.h > > 1099 > 1100 static inline bool pud_user_accessible_page(pud_t pud) > 1101 { >> 1102 return pud_valid(pud) && !pud_table(pud) && (pud_user(pud) || pud_user_exec(pud)); > 1103 } > 1104 #endif > 1105 >