From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CDCFC7EE23 for ; Thu, 25 May 2023 03:01:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0891900002; Wed, 24 May 2023 23:01:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB7936B0075; Wed, 24 May 2023 23:01:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A695900002; Wed, 24 May 2023 23:01:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8CB2A6B0074 for ; Wed, 24 May 2023 23:01:23 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 50FB3140A3E for ; Thu, 25 May 2023 03:01:23 +0000 (UTC) X-FDA: 80827276446.09.90A3DD3 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 775541C000D for ; Thu, 25 May 2023 03:01:20 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684983680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=77tRqUenoFRE4Ltpv3tArv3bNcQ6LClETAHqa1JIsqU=; b=YL7fxnTbE3nzvyq060Dpp5FZHQ1LLlqNJ0ivh0/q1000CYKqoDiaJfEUsocvMn7xFHgt2y I6WIFzS6NRAUe2IpzC3MnGENRuMkDPnlITaOW1NUf3IMKVJWCUZpcXm6MMuCm/5pOUS4WA n0lgeR52I4VHDrpBLH9HUR3Cb6jhz6M= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684983680; a=rsa-sha256; cv=none; b=bRCWeC5RV6c2Hgq5+NdBqsa+2P2eQc3kxNM4SRv5/xjV/oqxmHA+Hpo75G/D4d0fGcsrCd +JZKFwgF2t3aRNFtk8ipAZQ7SP+pHs47XeokB1KkqWVsRqRyb9MuLLII8pliDX7969hdN+ iXdc1HLM1q19HymIOK00EXfc4R/IjjM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F9C81042; Wed, 24 May 2023 20:02:04 -0700 (PDT) Received: from [10.162.43.6] (unknown [10.162.43.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5E8443F762; Wed, 24 May 2023 20:01:17 -0700 (PDT) Message-ID: <10c85f5c-3332-9130-c6f0-d36b9ea4b549@arm.com> Date: Thu, 25 May 2023 08:31:14 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 05/36] mm: Add default definition of set_ptes() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , linux-arch@vger.kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-6-willy@infradead.org> From: Anshuman Khandual In-Reply-To: <20230315051444.3229621-6-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 775541C000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 3bbsnqgr91m84uw6egzaa39sqq9rj1sm X-HE-Tag: 1684983680-890952 X-HE-Meta: U2FsdGVkX19x82aTJiIABJ7pVGKP6uGgbrT6wSlHNSfYYXPlhPFmieBmLXvVV76Ow3+JfoL7TkQT/QMIJsDOmqm4/D5JVG/pOESj2XBm+g4risoLnd9IOvw7pDiSVmk7Lt3rgs+HGpuVKu+nwtKN+z42BwscIU1iM0VLEAHaSEO3Y1INiMgSH5GZncbPEf8VoPsUs3/8w5owklKQ8MlzPwNWM34uJiknAhJCIyN10zC2BMUitOqdCkNWSLbBR3UojJmvn/vOXdMhnkqlUjaGJ76EKL2A5Vn3/CUYfyK/YhAb3gIEDN5jhCz1jgniIHprmdh9kLo3x/59126RLGqfana/Uhvr6IlEsqR9W4bgb7M8SN+BeTFqAFksc0M58Y5zTliyR7mn+Wo6Dt7u/miWR++fqUBJHU5vOVH3JvSlEeKFsTbnYS0XnhEZTK+EYJaKceh/ILCBW2Lo/sCNh9x9zo6QvXB49OXcnGQSwo7EzBXG/KS80TdbJ5q07BgZr0WjHdUCCrPLI6DZEpup7/QGWmxSY3AZVBlOV3w4SksVnKgRnsnsbaYQPlfaEG6DYYLs7/roqHOAUsyv0681kBcPH2gzcNtHCrtVmREkbGrWh4ggvQBvLs4Yzk7Wr5EWS1BcHxd9lZokOKlGb7ggej4ofZUztlODqRWaN8eIfM6FmZ5ZGgkaYOu5jy4zRrcviHl1SIJ+0OA9fwyp2jQ50FVDR0mSUwEcJZw+D/AZXT5EkRbUWPLa5RRSdliYbEqcOahuhqp9XdVb/GjYkfJPtHqa/KQV5lkuyXdnOJZqou2arpt0XV4myzUEYESGJZNiYYs1Up8vAtIFlTRU3MEad5E9p7a0c/66ORg2bIhKMdBLpXRnuKImzfV3kuBCYl79e1XSjoOaRfR+laX4ueHb9zxWxaoTpgbqoF5cqj8S5kgUOAdTcg0P8jlA5H/FRvXFQ219sXIlIpTHNrwcfPimdD6 YpFsORQG EZ2V8JnkDZPqwJuhLJ5UjNWxMEvWuUZUwOfO6rGPnwxuZRPdi+27lE6Lft2YBQ4Ad/DHqjrttV0A3qhriN/raWEOqZdW0cOk8uFqcuphLRoWtpLEtuPaXYzT35aH+4otWAx+0ZAl9PNOaw7wUuEj3wTS0Z0cuA1HgncHtInUbNqY+j+23FVpu4aqTK60/PsZbhVrw5O4X0627hobsleuQaI0Fx1wGTsH/TqQ5QjD0Y42FBZcSaZ0dybJKJuvwdPGc7YEKVijBbx9RueQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 10:44, Matthew Wilcox (Oracle) wrote: > Most architectures can just define set_pte() and PFN_PTE_SHIFT to > use this definition. It's also a handy spot to document the guarantees > provided by the MM. > > Suggested-by: Mike Rapoport (IBM) > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pgtable.h | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index c5a51481bbb9..a755fe94b4b4 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -172,6 +172,43 @@ static inline int pmd_young(pmd_t pmd) > } > #endif > > +#ifndef set_ptes > +#ifdef PFN_PTE_SHIFT > +/** > + * set_ptes - Map consecutive pages to a contiguous range of addresses. > + * @mm: Address space to map the pages into. > + * @addr: Address to map the first page at. > + * @ptep: Page table pointer for the first entry. > + * @pte: Page table entry for the first page. > + * @nr: Number of pages to map. > + * > + * May be overridden by the architecture, or the architecture can define > + * set_pte() and PFN_PTE_SHIFT. > + * > + * Context: The caller holds the page table lock. The pages all belong > + * to the same folio. The PTEs are all in the same PMD. > + */ > +static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > + pte_t *ptep, pte_t pte, unsigned int nr) > +{ > + page_table_check_ptes_set(mm, addr, ptep, pte, nr); > + > + for (;;) { > + set_pte(ptep, pte); > + if (--nr == 0) > + break; > + ptep++; > + pte = __pte(pte_val(pte) + (1UL << PFN_PTE_SHIFT)); > + } > +} > +#ifndef set_pte_at > +#define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1) > +#endif Should not there be a build phase call out when both set_ptes() and PFN_PTE_SHIFT are not defined on a given platform ? --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -204,6 +204,8 @@ static inline void set_ptes(struct mm_struct *mm, unsigned long addr, #ifndef set_pte_at #define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1) #endif +#else +#error "You should define PFN_PTE_SHIFT" #endif #else #define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1) > +#endif> +#else > +#define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1) > +#endif > + > #ifndef __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS > extern int ptep_set_access_flags(struct vm_area_struct *vma, > unsigned long address, pte_t *ptep,