From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B251CE8E99 for ; Thu, 24 Oct 2024 17:23:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9C206B00A4; Thu, 24 Oct 2024 13:23:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B24606B00A2; Thu, 24 Oct 2024 13:23:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99E1E6B00A4; Thu, 24 Oct 2024 13:23:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 798A06B00A0 for ; Thu, 24 Oct 2024 13:23:19 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6962B14147F for ; Thu, 24 Oct 2024 17:22:59 +0000 (UTC) X-FDA: 82709166330.21.5A35172 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf03.hostedemail.com (Postfix) with ESMTP id E17B320017 for ; Thu, 24 Oct 2024 17:23:07 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nmW6t+cb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="gqMfgnt/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nmW6t+cb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="gqMfgnt/"; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729790472; a=rsa-sha256; cv=none; b=WUcKfmxrDOM9zn4lyBohBM5O4N/yuoPRHEYgT8VTutTldRvALBHtpv95x3MbvMQeS7/FTz OKfseLsmY1oub2vmgodBYC096N3ZKBn+1cixNPlN7C2NJqChUKFwusSKnqa1o9xHuz79gA vJnUymXLrWsRNKvFgVUzOWfCdnnY4+4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nmW6t+cb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="gqMfgnt/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nmW6t+cb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="gqMfgnt/"; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729790472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hhg8jQBJ68+p/eQWd3M51shy1IQ6KBiP4eXRMzo+Gss=; b=4W36gUphtywbKo+SpIs75adz7PKHIvd5UGjG1TW9f7YG3gqLggGwihjrTik34fjNKDIGeb 0tUErYXxBia+zs1XOWzu/xP52DMiVcNRyBifUjdEwMqC7UhcCYnzXkTWGADVBUJLOHELHF R+2cwb90YEtK/c43rRyXsqP0RsYg28g= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B82EE22006; Thu, 24 Oct 2024 17:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729790594; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Hhg8jQBJ68+p/eQWd3M51shy1IQ6KBiP4eXRMzo+Gss=; b=nmW6t+cbb8lmUEXqrFfSFXqDkNroJfJCytcyjvSOhy0KYm3ZXiKYBjyq0X4SE31DIiNo8A qoqNrLFbJeCNbSCh3BAw5w8g3pS89pHykxt/UsnTF37NomarH/0U23vpjoPRZHwWD3vauz xHSSIiknNMO6xs0cszRRFYv7mIn9UFI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729790594; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Hhg8jQBJ68+p/eQWd3M51shy1IQ6KBiP4eXRMzo+Gss=; b=gqMfgnt/9IH3UvMoHHuhdq4SBCibCMLnF7ytLM+N1eVQuE0SiKUJfJvNVZB+eH0shoWlTI EvrxFpmDlO1MvRAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729790594; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Hhg8jQBJ68+p/eQWd3M51shy1IQ6KBiP4eXRMzo+Gss=; b=nmW6t+cbb8lmUEXqrFfSFXqDkNroJfJCytcyjvSOhy0KYm3ZXiKYBjyq0X4SE31DIiNo8A qoqNrLFbJeCNbSCh3BAw5w8g3pS89pHykxt/UsnTF37NomarH/0U23vpjoPRZHwWD3vauz xHSSIiknNMO6xs0cszRRFYv7mIn9UFI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729790594; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Hhg8jQBJ68+p/eQWd3M51shy1IQ6KBiP4eXRMzo+Gss=; b=gqMfgnt/9IH3UvMoHHuhdq4SBCibCMLnF7ytLM+N1eVQuE0SiKUJfJvNVZB+eH0shoWlTI EvrxFpmDlO1MvRAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 981011368E; Thu, 24 Oct 2024 17:23:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id tVvIJIKCGmdxZgAAD6G6ig (envelope-from ); Thu, 24 Oct 2024 17:23:14 +0000 Message-ID: <10c78981-998c-41a9-86d0-6282bd1b1772@suse.cz> Date: Thu, 24 Oct 2024 19:23:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/8] mm: isolate mmap internal logic to mm/vma.c Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Peter Xu References: <67d9ba63e203452431c7ee7802d3988bd1258ab6.1729715266.git.lorenzo.stoakes@oracle.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <67d9ba63e203452431c7ee7802d3988bd1258ab6.1729715266.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E17B320017 X-Stat-Signature: mjun6gn4bmwatt5urwb83pjo86kgutr3 X-Rspam-User: X-HE-Tag: 1729790587-583945 X-HE-Meta: U2FsdGVkX18Ze7Itgq38LtCZilLki+9zKBDVOu0Hl42pfeIxS+qDr3mBgtN1ONmxLiMuqUFvXLTx5KW8jDlaNpUH1w3uu7rYsmtKMFfbVNtstS4lVzhhIC+jMntOEcyTtJfzn6bavuCR9yEj02qPyiWK7tGkqp7oZJvqa0ZwCRO6SgvdSzXTCt4356NIdo2I6W8wdEyx19Etj83a04jSyrGd7BrrMA34fS3C5iKwFpQYIZGk56qMPCfx1NXZWQrHsISw8IfPzv4w0nTH5EvX+NjuytdTuusIeo+QRlWN5eySnUFQ7A/KOMEmGOJEEkBLTJj8jOHmjpVIrXo5iSrP6doJbrfYr6ghEd1urSIuqORRF/MFIYDZdEZQsEDpmljCMhEcmpefi0OrPYyWkI2pTkwpikrzlJzzg6+UPI/hR2VHOC9ABuGACwBUiuoIUuK7+dFzbZdo1TGSvgoNZsE693KG+mIq4PZYCR0QF6dvFOkrC4nAdqpgT487dlmN9xNIL5VKeYGa4skkrJFlFOSYuJDVwFAnughICkVwRNUwVmyDMF1CY7cKsDQTQmajz2E6XjCI6577N/jjiAca1b/6mOWjnJFVe2Uen9zoKUq0GdDtrGUlHpX1OT8goWV/oNPq8pxBtU54SFS6Tx2h2Jv7+mvMG4GsIjEHIBnqy7gcjlBKL4OKx4WrHBQI60XYE+LgGdZkv1zYEOKCUSOIehfy7jvQ+58DHshHd9hVxMehLxXmh40kpBMvABbYmA2EcFPHTfb1J9A9XHMkmYpA9ixA6yUSEp9huAbdPWtFlWg/D1hU19dXRuIWKgBrhHgTCJ7OgH+6L71X2c1kF0Crie8ymNC0OKEAyEyEU/Pc/BpyuhM36qFWcKxYn9d1fQa9Q61K33Rst05IFJcM8Ee4ZiF+4pwOLiACYnxSDZlahc5CHyLfHk9sGOoHEUH7MLlMGkpSGFY8FAIGZQS47oG2gNx X+HMxfDC gKtbql56EskCMdB+jJM2crx6tG+9wNCcNkcZlwZGNxGtFE9FuU39M640IFowJ8o1dzvDM53OtzJaqXbL6G34/1tXeKwTM234IXROVRPW4vgB88BBEHQ0mvsl8C0drAG5Bu1tm2ugPFvd9v1xG2p4xS07SiMdSgwIrEYwlwqBt4l49QPkHLbSRB6gBqatUYgVSoAbhZM26lINjJzk3iCiVdpyDg4W9bGgTtEzAoa2mBplWd/bTR9S/r3H9YrkfijxSd0tndLrqLBsUKg6y4MgFiKpiLfkJrQlwxL7zW5Tzhn/1ePka4BtPnQSMnw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/23/24 22:38, Lorenzo Stoakes wrote: > In previous commits we effected improvements to the mmap() logic in > mmap_region() and its newly introduced internal implementation function > __mmap_region(). > > However as these changes are intended to be backported, we kept the delta > as small as is possible and made as few changes as possible to the newly > introduced mm/vma.* files. > > Take the opportunity to move this logic to mm/vma.c which not only isolates > it, but also makes it available for later userland testing which can help > us catch such logic errors far earlier. > > Signed-off-by: Lorenzo Stoakes With help of git's colorMoved: Reviewed-by: Vlastimil Babka