From: Vlastimil Babka <vbabka@suse.cz>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "Liam R . Howlett" <Liam.Howlett@oracle.com>,
Jann Horn <jannh@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v2 6/8] mm: isolate mmap internal logic to mm/vma.c
Date: Thu, 24 Oct 2024 19:23:14 +0200 [thread overview]
Message-ID: <10c78981-998c-41a9-86d0-6282bd1b1772@suse.cz> (raw)
In-Reply-To: <67d9ba63e203452431c7ee7802d3988bd1258ab6.1729715266.git.lorenzo.stoakes@oracle.com>
On 10/23/24 22:38, Lorenzo Stoakes wrote:
> In previous commits we effected improvements to the mmap() logic in
> mmap_region() and its newly introduced internal implementation function
> __mmap_region().
>
> However as these changes are intended to be backported, we kept the delta
> as small as is possible and made as few changes as possible to the newly
> introduced mm/vma.* files.
>
> Take the opportunity to move this logic to mm/vma.c which not only isolates
> it, but also makes it available for later userland testing which can help
> us catch such logic errors far earlier.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
With help of git's colorMoved:
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
next prev parent reply other threads:[~2024-10-24 17:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 20:38 [PATCH v2 0/8] fix error handling in mmap_region() and refactor Lorenzo Stoakes
2024-10-23 20:38 ` [PATCH hotfix 6.12 v2 1/8] mm: avoid unsafe VMA hook invocation when error arises on mmap hook Lorenzo Stoakes
2024-10-23 20:38 ` [PATCH hotfix 6.12 v2 2/8] mm: unconditionally close VMAs on error Lorenzo Stoakes
2024-10-23 20:38 ` [PATCH hotfix 6.12 v2 3/8] mm: refactor map_deny_write_exec() Lorenzo Stoakes
2024-10-23 20:38 ` [PATCH hotfix 6.12 v2 4/8] mm: resolve faulty mmap_region() error path behaviour Lorenzo Stoakes
2024-10-28 18:29 ` Mark Brown
2024-10-28 18:57 ` Lorenzo Stoakes
2024-10-28 19:05 ` Linus Torvalds
2024-10-28 19:14 ` Lorenzo Stoakes
2024-10-28 19:50 ` Liam R. Howlett
2024-10-28 20:00 ` Liam R. Howlett
2024-10-28 20:17 ` Lorenzo Stoakes
2024-10-28 20:22 ` Linus Torvalds
2024-10-28 20:43 ` Lorenzo Stoakes
2024-10-28 21:04 ` Liam R. Howlett
2024-10-28 21:05 ` Mark Brown
2024-10-28 21:28 ` Lorenzo Stoakes
2024-10-28 21:00 ` Vlastimil Babka
2024-10-28 21:19 ` Linus Torvalds
2024-10-28 21:28 ` Vlastimil Babka
2024-10-28 22:14 ` Lorenzo Stoakes
2024-10-29 7:50 ` Vlastimil Babka
2024-10-29 10:23 ` Lorenzo Stoakes
2024-10-29 12:33 ` Mark Brown
2024-10-29 12:41 ` Lorenzo Stoakes
2024-10-29 15:04 ` Catalin Marinas
2024-10-29 15:16 ` Lorenzo Stoakes
2024-10-29 16:22 ` Catalin Marinas
2024-10-29 16:36 ` Lorenzo Stoakes
2024-10-29 17:02 ` Catalin Marinas
2024-10-29 17:28 ` Lorenzo Stoakes
2024-10-29 17:32 ` Catalin Marinas
2024-10-28 20:51 ` Mark Brown
2024-10-23 20:38 ` [PATCH v2 5/8] tools: testing: add additional vma_internal.h stubs Lorenzo Stoakes
2024-10-23 20:38 ` [PATCH v2 6/8] mm: isolate mmap internal logic to mm/vma.c Lorenzo Stoakes
2024-10-24 17:23 ` Vlastimil Babka [this message]
2024-10-23 20:38 ` [PATCH v2 7/8] mm: refactor __mmap_region() Lorenzo Stoakes
2024-10-25 8:35 ` Vlastimil Babka
2024-10-25 10:19 ` Lorenzo Stoakes
2024-10-25 10:23 ` Vlastimil Babka
2024-10-23 20:38 ` [PATCH v2 8/8] mm: defer second attempt at merge on mmap() Lorenzo Stoakes
2024-10-25 9:43 ` Vlastimil Babka
2024-10-25 10:20 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10c78981-998c-41a9-86d0-6282bd1b1772@suse.cz \
--to=vbabka@suse.cz \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=peterx@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox