From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C895FC433ED for ; Tue, 27 Apr 2021 03:29:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3322B611ED for ; Tue, 27 Apr 2021 03:29:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3322B611ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 96E746B0036; Mon, 26 Apr 2021 23:29:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91E886B006E; Mon, 26 Apr 2021 23:29:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E5BC6B0070; Mon, 26 Apr 2021 23:29:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 5FDFD6B0036 for ; Mon, 26 Apr 2021 23:29:27 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0F8A6181AEF31 for ; Tue, 27 Apr 2021 03:29:27 +0000 (UTC) X-FDA: 78076716774.11.37F749B Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 7574E2000255 for ; Tue, 27 Apr 2021 03:29:28 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5AFA3D6E; Mon, 26 Apr 2021 20:29:25 -0700 (PDT) Received: from [10.163.75.249] (unknown [10.163.75.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C18FB3F694; Mon, 26 Apr 2021 20:29:23 -0700 (PDT) From: Anshuman Khandual Subject: Re: [PATCH 1/6] mm: Make __dump_page static To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Cc: Andrew Morton , linux-kernel@vger.kernel.org References: <20210416231531.2521383-1-willy@infradead.org> <20210416231531.2521383-2-willy@infradead.org> Message-ID: <10b90e32-972a-2a55-082c-b576aa5c569d@arm.com> Date: Tue, 27 Apr 2021 09:00:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210416231531.2521383-2-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7574E2000255 X-Stat-Signature: jjfiotrcd65cszwru971xr99dn6xm3t5 Received-SPF: none (arm.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=foss.arm.com; client-ip=217.140.110.172 X-HE-DKIM-Result: none/none X-HE-Tag: 1619494168-863312 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/17/21 4:45 AM, Matthew Wilcox (Oracle) wrote: > The only caller of __dump_page() now opencodes dump_page(), so > remove it as an externally visible symbol. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/mmdebug.h | 3 +-- > mm/debug.c | 2 +- > mm/page_alloc.c | 3 +-- > 3 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h > index 5d0767cb424a..1935d4c72d10 100644 > --- a/include/linux/mmdebug.h > +++ b/include/linux/mmdebug.h > @@ -9,8 +9,7 @@ struct page; > struct vm_area_struct; > struct mm_struct; > > -extern void dump_page(struct page *page, const char *reason); > -extern void __dump_page(struct page *page, const char *reason); > +void dump_page(struct page *page, const char *reason); > void dump_vma(const struct vm_area_struct *vma); > void dump_mm(const struct mm_struct *mm); > > diff --git a/mm/debug.c b/mm/debug.c > index 0bdda8407f71..84cdcd0f7bd3 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -42,7 +42,7 @@ const struct trace_print_flags vmaflag_names[] = { > {0, NULL} > }; > > -void __dump_page(struct page *page, const char *reason) > +static void __dump_page(struct page *page, const char *reason) > { > struct page *head = compound_head(page); > struct address_space *mapping; > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 5a35f21b57c6..0152670c6f04 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -658,8 +658,7 @@ static void bad_page(struct page *page, const char *reason) > > pr_alert("BUG: Bad page state in process %s pfn:%05lx\n", > current->comm, page_to_pfn(page)); > - __dump_page(page, reason); > - dump_page_owner(page); > + dump_page(page, reason); > > print_modules(); > dump_stack(); > Reviewed-by: Anshuman Khandual