From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66D4FECAAD2 for ; Mon, 29 Aug 2022 12:07:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5478E940008; Mon, 29 Aug 2022 08:07:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F5AC940007; Mon, 29 Aug 2022 08:07:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34886940008; Mon, 29 Aug 2022 08:07:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1FF24940007 for ; Mon, 29 Aug 2022 08:07:58 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D9B66A0862 for ; Mon, 29 Aug 2022 12:07:57 +0000 (UTC) X-FDA: 79852506594.12.79FBEA0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id CF955160057 for ; Mon, 29 Aug 2022 12:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661774876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xvRlmqs214Dpgefm9SAxkwz6k6CnKHpZ0dlz408l89w=; b=MnYWh0iTijYG8gktzzxr5ACnR8os9vvoHWNMrgvPIgN0UNT1LJezzaeKIEE9SZ1zs5G+B+ srY1bt7GnCWZ8ZSf50J0DQ3clQ4TlWYo4VLMMgl4O7N7WN055rQTXIeA/AgZJCJNMdAsBn 9A8alDvVjTe4CVXi5VdG30BlDY/PEzU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-88-nCYMhi-UM0q9-knQwPsChg-1; Mon, 29 Aug 2022 08:07:54 -0400 X-MC-Unique: nCYMhi-UM0q9-knQwPsChg-1 Received: by mail-wr1-f70.google.com with SMTP id e13-20020adfa44d000000b002260797ca0cso1075380wra.20 for ; Mon, 29 Aug 2022 05:07:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=xvRlmqs214Dpgefm9SAxkwz6k6CnKHpZ0dlz408l89w=; b=JF2DBsUzHfuvIEDpuG/YjgsldxMM3mePP6pmC+e+OW029wYOiguyvr7BhDQ+H2ji/3 bF01qekZpAtjHGn5acXtJSXqoiSykPXZcWMq9L2cdZdtG3leIIwf8BJIxqDaOM5MOZp9 da8fTNRHVFpw3DIgUGzHBRHDAt86yBCFk7gq82G5yKJzJzrE96GsxBNn26i/uB7MUpZr OFsxyW60cpz01HtZg5i0XC1RG36JSaZ/UH0RZ+WoAKDQps3ZTn3R5Oc0Pd2MhxWVbLHa sKnUpftR7NMuh6kyXt49SmHzk9gH9wBSzY09t3Kmnq1AamrlU3jqlDYvTSQPnqBc7x4/ 5ANg== X-Gm-Message-State: ACgBeo24H4ypEEcaRcYGGwB9WOZBkEq56+SU///88aU8QDaZy1auTHDf RESqpSEDL5VpK1SlidU57TrtWbTx8mqF2SMxzvbxZBYmLtu0/mfL9pKW52+yvNaufjURV806j1U +X4IMWMdOgiI= X-Received: by 2002:a5d:68c9:0:b0:225:330b:2d0 with SMTP id p9-20020a5d68c9000000b00225330b02d0mr5809301wrw.243.1661774873806; Mon, 29 Aug 2022 05:07:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR40B6aIc3Kd7HqO+pm6F4fpndLD4ybKX0vv6qIxnrSvSPYic+blNQ9JwBkZ3/6303cVEkP7JA== X-Received: by 2002:a5d:68c9:0:b0:225:330b:2d0 with SMTP id p9-20020a5d68c9000000b00225330b02d0mr5809271wrw.243.1661774873476; Mon, 29 Aug 2022 05:07:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:3900:658b:bed0:4260:4c25? (p200300cbc7073900658bbed042604c25.dip0.t-ipconnect.de. [2003:cb:c707:3900:658b:bed0:4260:4c25]) by smtp.gmail.com with ESMTPSA id f17-20020adfdb51000000b002252cb35184sm6771976wrj.25.2022.08.29.05.07.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Aug 2022 05:07:53 -0700 (PDT) Message-ID: <10a9d33a-58a3-10b3-690b-53100d4e5440@redhat.com> Date: Mon, 29 Aug 2022 14:07:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/6] mm/gup: introduce pin_user_page() To: John Hubbard , Andrew Morton Cc: Jens Axboe , Alexander Viro , Miklos Szeredi , Christoph Hellwig , "Darrick J . Wong" , Trond Myklebust , Anna Schumaker , Jan Kara , Logan Gunthorpe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, LKML References: <20220827083607.2345453-1-jhubbard@nvidia.com> <20220827083607.2345453-2-jhubbard@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220827083607.2345453-2-jhubbard@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661774877; a=rsa-sha256; cv=none; b=4G+JBEXV8O4yNDesemBoBnZeuMAM9PhiOZiAYK7wEKRpJIl4UONtobEXt3xq5rh48cXK+L TsgdWY3SM/hgASJuVCwXpXQ2VzhJHo5uVqDrEAZhYc+JCwH4NputDeyH/dRmS+Hz/DK7HL uXPHnMOZQYDvk13ipXztMoNZi1TdiZg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MnYWh0iT; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661774877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xvRlmqs214Dpgefm9SAxkwz6k6CnKHpZ0dlz408l89w=; b=rKD3HN5yS/HHc5/nPgLbs8W8xxaWl1iMKvw2s1G1zIVBEM0w9ZBxegTRJDN+jOKVfxasEz nbsEiMVmn8hicyZAGnRRGohiukMr6UfV9fmN1tzm8cZB9WfFsKTj8zl26VJUsQMs499XPz zMgDreV9b1PMStKQC8FqqX7JPXuWa4Q= X-Rspamd-Queue-Id: CF955160057 X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MnYWh0iT; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam08 X-Stat-Signature: 4e4urosfncmd8adskpd45hn9kydw69es X-HE-Tag: 1661774876-328797 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.08.22 10:36, John Hubbard wrote: > pin_user_page() is an externally-usable version of try_grab_page(), but > with semantics that match get_page(), so that it can act as a drop-in > replacement for get_page(). Specifically, pin_user_page() has a void > return type. > > pin_user_page() elevates a page's refcount using FOLL_PIN rules. This > means that the caller must release the page via unpin_user_page(). > > Signed-off-by: John Hubbard > --- > include/linux/mm.h | 1 + > mm/gup.c | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 34 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 982f2607180b..85a105157334 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1869,6 +1869,7 @@ long pin_user_pages_remote(struct mm_struct *mm, > long get_user_pages(unsigned long start, unsigned long nr_pages, > unsigned int gup_flags, struct page **pages, > struct vm_area_struct **vmas); > +void pin_user_page(struct page *page); > long pin_user_pages(unsigned long start, unsigned long nr_pages, > unsigned int gup_flags, struct page **pages, > struct vm_area_struct **vmas); > diff --git a/mm/gup.c b/mm/gup.c > index 5abdaf487460..245ccb41ed8c 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -3213,6 +3213,39 @@ long pin_user_pages(unsigned long start, unsigned long nr_pages, > } > EXPORT_SYMBOL(pin_user_pages); > > +/** > + * pin_user_page() - apply a FOLL_PIN reference to a page > + * > + * @page: the page to be pinned. > + * > + * This is similar to get_user_pages(), except that the page's refcount is > + * elevated using FOLL_PIN, instead of FOLL_GET. > + * > + * IMPORTANT: The caller must release the page via unpin_user_page(). > + * > + */ > +void pin_user_page(struct page *page) > +{ > + struct folio *folio = page_folio(page); > + > + WARN_ON_ONCE(folio_ref_count(folio) <= 0); > + We should warn if the page is anon and !exclusive. I assume the intend is to use pin_user_page() only to duplicate pins, right? -- Thanks, David / dhildenb